Re: [Qemu-devel] [RFC for-3.2 PATCH 0/7] pcie: Enhanced link speed and width support

I can confirm that these patches work as expected. Thank you kindly Alex for your hard work! Tested-by: Geoffrey McRae On 2018-11-15 07:50, Alex Williamson wrote: QEMU exposes gen1 PCI-express interconnect devices supporting only 2.5GT/s and x1 width. It might not seem obvious that a

Re: [Qemu-devel] [PATCH 1/2] ps2: Clear the queue on PS/2 mouse reset and obey device disable

On 2018-05-07 22:41, Gerd Hoffmann wrote: On Mon, May 07, 2018 at 10:26:24PM +1000, geoff--- via Qemu-devel wrote: On 2018-05-07 22:21, Gerd Hoffmann wrote: > On Mon, May 07, 2018 at 10:00:22PM +1000, geoff--- via Qemu-devel wrote: > > This allows guest's to correctly reinitialize and

Re: [Qemu-devel] [PATCH 2/2] ps2: Fix mouse stream corruption due to lost data

On 2018-05-07 22:34, Gerd Hoffmann wrote: diff --git a/hw/input/ps2.c b/hw/input/ps2.c index 6edf046820..011290920f 100644 --- a/hw/input/ps2.c +++ b/hw/input/ps2.c @@ -192,12 +192,50 @@ void ps2_queue(PS2State *s, int b) { PS2Queue *q = >queue; -if (q->count >= PS2_QUEUE_SIZE - 1) +

Re: [Qemu-devel] [PATCH 1/2] ps2: Clear the queue on PS/2 mouse reset and obey device disable

On 2018-05-07 22:21, Gerd Hoffmann wrote: On Mon, May 07, 2018 at 10:00:22PM +1000, geoff--- via Qemu-devel wrote: This allows guest's to correctly reinitialize and identify the mouse should the guest decide to re-scan or reset during mouse input events. Signed-off-by: Geoffrey McRae <

[Qemu-devel] [PATCH 2/2] ps2: Fix mouse stream corruption due to lost data

This fixes an issue by adding bounds checking to multi-byte packets where the PS/2 mouse data stream may become corrupted due to data being discarded when the PS/2 ringbuffer is full. Interrupts for Multi-byte responses are postponed until the final byte has been queued. These changes fix a bug

[Qemu-devel] [PATCH 1/2] ps2: Clear the queue on PS/2 mouse reset and obey device disable

This allows guest's to correctly reinitialize and identify the mouse should the guest decide to re-scan or reset during mouse input events. Signed-off-by: Geoffrey McRae --- hw/input/ps2.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/input/ps2.c

Re: [Qemu-devel] [PATCH v7 0/9] i386: Enable TOPOEXT to support hyperthreading on AMD CPU

Works well for me, thanks! Tested-by: Geoffrey McRae On 2018-04-27 02:26, Babu Moger wrote: This series enables the TOPOEXT feature for AMD CPUs. This is required to support hyperthreading on kvm guests. This addresses the issues reported in these bugs:

[Qemu-devel] Linux Guest Memory Performance

Hi All, I am having some very strange issues with Qemu and memory copy performance. It seems that when performing buffer -> buffer copies of 8MB or lower the performance is horrid. Test program: #include #include #include #include #include static inline uint64_t nanotime() { struct

Re: [Qemu-devel] [PATCH v2 0/3] ivshmem: MSI bug fixes

I just updated to the latest build and applied this patch set, now on VM reset the qemu crashes with the following assert: ivshmem.c:467: ivshmem_add_kvm_msi_virq: Assertion `!s->msi_vectors[vector].pdev' failed. On 2017-11-15 18:31, Ladi Prosek wrote: Fixes bugs in the ivshmem device

Re: [Qemu-devel] [PATCH 3/3] ivshmem: Improve MSI irqfd error handling

On 2017-11-14 04:27, Markus Armbruster wrote: Ladi Prosek writes: Adds a rollback path to ivshmem_enable_irqfd() and fixes ivshmem_disable_irqfd() to bail if irqfd has not been enabled. Signed-off-by: Ladi Prosek Is this a theoretical bug, or can

Re: [Qemu-devel] [PATCH 1/3] ivshmem: Don't update non-existent MSI routes

Thanks Ladi, I had not yet had time to dig into these, this patch set resolves all issues I was aware of. Tested-by: Geoffrey McRae On 2017-11-11 04:34, Ladi Prosek wrote: As of commit 660c97eef6f8 ("ivshmem: use kvm irqfd for msi notifications"), QEMU crashes with:

[Qemu-devel] PCI Passthrough + AMD + NPT

Hi All, I have started to dig into why ntp seems to slow down graphics performance on AMD systems using PCI passthrough and figured I would report what I have so far discovered. I have noted the primary point of failure seems to be specifically with PhysX. This is why people only see a slow

Re: [Qemu-devel] ivshmem Windows Driver

On 2017-10-19 20:51, Ladi Prosek wrote: On Thu, Oct 19, 2017 at 11:41 AM, wrote: On 2017-10-19 20:07, ge...@hostfission.com wrote: On 2017-10-19 20:01, Ladi Prosek wrote: On Thu, Oct 19, 2017 at 10:44 AM, wrote: On 2017-10-19 19:35, Ladi

Re: [Qemu-devel] ivshmem Windows Driver

On 2017-10-19 20:07, ge...@hostfission.com wrote: On 2017-10-19 20:01, Ladi Prosek wrote: On Thu, Oct 19, 2017 at 10:44 AM, wrote: On 2017-10-19 19:35, Ladi Prosek wrote: On Wed, Oct 18, 2017 at 5:04 PM, wrote: Hi Ladi & Yan, I am pleased

Re: [Qemu-devel] ivshmem Windows Driver

On 2017-10-19 20:01, Ladi Prosek wrote: On Thu, Oct 19, 2017 at 10:44 AM, wrote: On 2017-10-19 19:35, Ladi Prosek wrote: On Wed, Oct 18, 2017 at 5:04 PM, wrote: Hi Ladi & Yan, I am pleased to present the completed driver for review, please

Re: [Qemu-devel] ivshmem Windows Driver

On 2017-10-19 19:35, Ladi Prosek wrote: On Wed, Oct 18, 2017 at 5:04 PM, wrote: Hi Ladi & Yan, I am pleased to present the completed driver for review, please see: https://github.com/gnif/kvm-guest-drivers-windows Awesome! Feel free to open pull request, it should

Re: [Qemu-devel] ivshmem Windows Driver

Hi Ladi & Yan, I am pleased to present the completed driver for review, please see: https://github.com/gnif/kvm-guest-drivers-windows All issues previously mentioned have been addressed and all missing functionality has been added. Please note that this work has exposed a bug in the qemu

Re: [Qemu-devel] ivshmem Windows Driver

On 2017-10-18 17:50, Ladi Prosek wrote: On Wed, Oct 18, 2017 at 7:50 AM, wrote: On 2017-10-18 16:31, Ladi Prosek wrote: Hi Geoff, On Mon, Oct 16, 2017 at 8:31 PM, wrote: Hi Yan & Ladi. I have written an initial implementation that supports

Re: [Qemu-devel] ivshmem Windows Driver

On 2017-10-18 16:31, Ladi Prosek wrote: Hi Geoff, On Mon, Oct 16, 2017 at 8:31 PM, wrote: Hi Yan & Ladi. I have written an initial implementation that supports just the shared memory mapping at this time. I plan to add events also but before I go further I would

Re: [Qemu-devel] ivshmem Windows Driver

Yan. On 15 Oct 2017, at 12:32, geoff--- via Qemu-devel <qemu-devel@nongnu.org> wrote: Hi All, I am writing some code that needs to share a block of ram between a Windows guest and Linux host. For this I am using the ivshmem device and I have written a very primitive driver for windows th

[Qemu-devel] ivshmem Windows Driver

Hi All, I am writing some code that needs to share a block of ram between a Windows guest and Linux host. For this I am using the ivshmem device and I have written a very primitive driver for windows that allows a single application to request to memory map the pci bar (shared memory) into

[Qemu-devel] [PATCH] [pckbd] Prevent IRQs when the guest disables the mouse

When the guest OS needs to send the mouse commands it will at least in the case of Windows 10 set the KBD_MODE_DISABLE_MOUSE bit to prevent interrupts from causing stream desynchronisation. Here is Windows 10 attempting to issue a PS/2 mouse reset without this fix where you can see the mouse