Re: [Qemu-devel] [PATCH 36/38] target-unicore32: Use mul*2 for do_mult

2013-02-26 Thread guanxuetao
Cc: Guan Xuetao g...@mprc.pku.edu.cn Signed-off-by: Richard Henderson r...@twiddle.net Acked-by: Guan Xuetao g...@mprc.pku.edu.cn --- target-unicore32/translate.c | 83 ++-- 1 file changed, 11 insertions(+), 72 deletions(-) diff --git

Re: [Qemu-devel] 绛�澶�: [PATCH qom-cpu for-1.4] targe t-unicore32: Rename CPU subtypes

2013-02-10 Thread guanxuetao
As indicated above, this patch has a bug, sorry. I will send a v2. Forking in linux-user will be broken (cpu_copy()), everything else should work though, no? Can you please test qemu.git master and confirm that it is not broken without this patch? I do not have any unicore32 image for

Re: [Qemu-devel] 绛�澶�: [RFC 19/19] target-unicore32: Refactor deb ug output macros

2013-02-10 Thread guanxuetao
Am 29.01.2013 10:23, schrieb Guan Xuetao: -���浠跺��浠�- ���浠朵�#65533;: Andreas F盲rber [mailto:afaer...@suse.de] 堕�#65533;: Sunday, January 27, 2013 21:32 ��朵欢浜#65533;: qemu-devel@nongnu.org �#65533;: Andreas F盲rber; Guan Xuetao (maintainer:UniCore32) 涓婚��: [RFC 19/19]

Re: [Qemu-devel] [RFC qom-cpu 14/15] target-unicore32: Introduce QOM realizefn for UniCore32CPU

2013-01-16 Thread guanxuetao
Introduce a realizefn and set realized = true in uc32_cpu_init(). Signed-off-by: Andreas F盲rber afaer...@suse.de LGTM. Acked-by: Guan Xuetao g...@mprc.pku.edu.cn --- target-unicore32/cpu.c| 15 +++ target-unicore32/helper.c |2 +- 2 Dateien ge盲ndert, 16 Zeilen

Re: [Qemu-devel] [PATCH 3/5] target-unicore32: avoid using cpu_single_env

2012-10-30 Thread guanxuetao
Pass around CPUState instead of using global cpu_single_env. Signed-off-by: Blue Swirl blauwir...@gmail.com Acked-by: Guan Xuetao g...@mprc.pku.edu.cn --- target-unicore32/softmmu.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/target-unicore32/softmmu.c

Re: [Qemu-devel] [PATCH 1/5] disas: avoid using cpu_single_env

2012-10-30 Thread guanxuetao
Pass around CPUState instead of using global cpu_single_env. Signed-off-by: Blue Swirl blauwir...@gmail.com For unicore32 part: Acked-by: Guan Xuetao g...@mprc.pku.edu.cn --- disas.c | 149 ++--- disas.h |

Re: [Qemu-devel] [PATCH 15/21] target-unicore32: switch to AREG0 free mode

2012-09-05 Thread guanxuetao
Add an explicit CPUState parameter instead of relying on AREG0 and switch to AREG0 free mode. Signed-off-by: Blue Swirl blauwir...@gmail.com Thanks, Tested-by: Guan Xuetao g...@mprc.pku.edu.cn --- configure |2 +- target-unicore32/Makefile.objs |2 -

Re: [Qemu-devel] [PATCH 00/19] unicore32: Add unicore32-softmmu support

2012-08-09 Thread guanxuetao
This still breaks build. Please fix, something like ret = 0 when the variable is declared should be enough. /src/qemu/hw/puv3_gpio.c: In function 'puv3_gpio_read': /src/qemu/hw/puv3_gpio.c:48:5: error: 'ret' may be used uninitialized in this function [-Werror=maybe-uninitialized]

Re: [Qemu-devel] [RESEND PULL REQUEST] UniCore32 PUV3 machine support

2012-08-04 Thread guanxuetao
On Wed, Aug 1, 2012 at 3:13 AM, g...@mprc.pku.edu.cn wrote: are available in the git repository at: git://github.com/gxt/QEMU.git unicore32 I'm still getting these errors, please fix: CClibhw32/hw/puv3_gpio.o /src/qemu/hw/puv3_gpio.c: In function 'puv3_gpio_read':

Re: [Qemu-devel] [PATCHv3 1/3] unicore32: Split UniCore-F64 instruction helpers from helper.c

2012-08-04 Thread guanxuetao
On Wed, Aug 1, 2012 at 3:07 AM, g...@mprc.pku.edu.cn wrote: From: Guan Xuetao g...@mprc.pku.edu.cn This patch just splits ucf64 instruction simulation helpers from helper.c. Also, two checkpatch warnings are solved. v1-v2: adjust copyright information for new ucf64_helper.c The patches

Re: [Qemu-devel] [PATCHv2] unicore32-softmmu: Add a minimal curses screen support

2012-08-01 Thread guanxuetao
Am 01.08.2012 05:09, schrieb g...@mprc.pku.edu.cn: Why is a TCG helper missing with curses directly? Shouldn't that use QEMU's console infrastructure and leave it to the user whether to use curses as a backend at runtime? What is the problem you are trying to solve? If you just need

Re: [Qemu-devel] [PATCHv4 07/14] unicore32-softmmu: Add puv3 soc/board support

2012-07-13 Thread guanxuetao
2012/7/13 Guan Xuetao g...@mprc.pku.edu.cn: This patch only add puv3 soc/board support, which introduces puv3 machine description, and specifies console type. Signed-off-by: Guan Xuetao g...@mprc.pku.edu.cn --- default-configs/unicore32-softmmu.mak |1 + hw/puv3.c

Re: [Qemu-devel] [PATCHv3 07/14] unicore32-softmmu: Add puv3 soc/board support

2012-06-24 Thread guanxuetao
On Wed, Jun 20, 2012 at 1:56 AM, Guan Xuetao g...@mprc.pku.edu.cn wrote: On Mon, 2012-06-18 at 20:02 +, Blue Swirl wrote: [snip] diff --git a/hw/puv3.h b/hw/puv3.h new file mode 100644 index 000..bcfc978 --- /dev/null +++ b/hw/puv3.h @@ -0,0 +1,49 @@ +/* + * Misc PKUnity

Re: [Qemu-devel] [PATCHv3 12/14] unicore32-softmmu: Add puv3 dma support

2012-06-24 Thread guanxuetao
On Wed, Jun 20, 2012 at 2:10 AM, Guan Xuetao g...@mprc.pku.edu.cn wrote: On Mon, 2012-06-18 at 19:59 +, Blue Swirl wrote: [snip] hw_error() also aborts, it would be nice to avoid that. However, the situation is somewhat different from the instruction case, since only privileged guest

Re: [Qemu-devel] [PATCHv3 02/14] unicore32-softmmu: Add coprocessor 0(sysctrl) and 1(ocd) instruction support

2012-06-24 Thread guanxuetao
[snip] +unrecognized: + �� ��cpu_abort(env, Wrong register (%d) or wrong operation (%d) in cp0_set!\n, + �� �� �� �� �� ��creg, cop); The call to cpu_abort() would mean that the guest is able to terminate QEMU at will, which is not OK. What does real HW do? In my opinion, I just want to

Re: [Qemu-devel] [PATCHv3 02/14] unicore32-softmmu: Add coprocessor 0(sysctrl) and 1(ocd) instruction support

2012-06-24 Thread guanxuetao
Does this pass scripts/checkpatch.pl? These should become if (cop != 0) { goto unrecognized; } Thanks for pointing it out, and sorry for that. I will correct it in next version. You can run scripts/checkpatch.pl before you submit the patch. Regards, chenwj Thanks, I will

Re: [Qemu-devel] [PATCH 5/9] unicore32-softmmu: initialize ucv2 cpu

2012-05-29 Thread guanxuetao
Am 28.05.2012 11:43, schrieb guanxue...@mprc.pku.edu.cn: Am 25.05.2012 13:29, schrieb Guan Xuetao: Signed-off-by: Guan Xuetao g...@mprc.pku.edu.cn --- target-unicore32/cpu.c | 17 + target-unicore32/cpu.h |2 +- 2 files changed, 14 insertions(+), 5 deletions(-) diff

Re: [Qemu-devel] [PATCH 8/9] unicore32-softmmu: add config and makefile support

2012-05-29 Thread guanxuetao
Am 28.05.2012 12:08, schrieb guanxue...@mprc.pku.edu.cn: Am 25.05.2012 13:29, schrieb Guan Xuetao: This patch adds configure and makefile support for unicore32-softmmu. All puv3-soc devices are put into hw/pkunity directory, so this dir will be added when unicore32-softmmu is selected.

Re: [Qemu-devel] [PATCH 7/9] unicore32-softmmu: add puv3 soc support

2012-05-28 Thread guanxuetao
Am 25.05.2012 13:29, schrieb Guan Xuetao: This patch only add minimal necessary system-control modules simulation for successfully kernel booting and busybox running. Signed-off-by: Guan Xuetao g...@mprc.pku.edu.cn --- hw/pkunity/puv3.c | 130 +

Re: [Qemu-devel] [PATCH 8/9] unicore32-softmmu: add config and makefile support

2012-05-28 Thread guanxuetao
Am 25.05.2012 13:29, schrieb Guan Xuetao: This patch adds configure and makefile support for unicore32-softmmu. All puv3-soc devices are put into hw/pkunity directory, so this dir will be added when unicore32-softmmu is selected. Signed-off-by: Guan Xuetao g...@mprc.pku.edu.cn ---

Re: [Qemu-devel] [PATCH 6/9] unicore32-softmmu: add generic cpu state save/load functions

2012-05-28 Thread guanxuetao
Am 25.05.2012 13:29, schrieb Guan Xuetao: This patch adds generic cpu state save/load functions for UniCore32 ISA. All architecture related registers are saved or loaded, and no optimization. Signed-off-by: Guan Xuetao g...@mprc.pku.edu.cn --- target-unicore32/machine.c | 99

Re: [Qemu-devel] [PATCH 6/9] unicore32-softmmu: add generic cpu state save/load functions

2012-05-28 Thread guanxuetao
Hi Guan, +void cpu_save(QEMUFile *f, void *opaque) +{ +int i; +CPUUniCore32State *env = (CPUUniCore32State *)opaque; + +for (i = 0; i 32; i++) { +qemu_put_be32(f, env-regs[i]); +} +qemu_put_be32(f, cpu_asr_read(env)); +qemu_put_be32(f, env-bsr); +

Re: [Qemu-devel] [PATCH 7/9] unicore32-softmmu: add puv3 soc support

2012-05-28 Thread guanxuetao
Am 25.05.2012 13:29, schrieb Guan Xuetao: This patch only add minimal necessary system-control modules simulation for successfully kernel booting and busybox running. Signed-off-by: Guan Xuetao g...@mprc.pku.edu.cn --- hw/pkunity/puv3.c | 130 +

Re: [Qemu-devel] [PATCH 5/9] unicore32-softmmu: initialize ucv2 cpu

2012-05-28 Thread guanxuetao
Am 25.05.2012 13:29, schrieb Guan Xuetao: Signed-off-by: Guan Xuetao g...@mprc.pku.edu.cn --- target-unicore32/cpu.c | 17 + target-unicore32/cpu.h |2 +- 2 files changed, 14 insertions(+), 5 deletions(-) diff --git a/target-unicore32/cpu.c b/target-unicore32/cpu.c