Re: [Qemu-devel] [PATCH v3] vnc: fix segfault in closed connection handling

2018-02-14 Thread Klim Kireev
ping On 02/07/2018 12:48 PM, Klim Kireev wrote: On one of our client's node, due to trying to read from closed ioc, a segmentation fault occured. Corresponding backtrace: 0 object_get_class (obj=obj@entry=0x0) 1 qio_channel_readv_full (ioc=0x0, iov=0x7ffe55277180 ... 2 qio_channel_read

Re: [Qemu-devel] "make check -j4" hangs

2018-02-12 Thread klim
On 02/09/2018 02:55 PM, Paolo Bonzini wrote: On 08/02/2018 22:54, Alistair Francis wrote: On Thu, Feb 8, 2018 at 1:12 PM, Peter Maydell wrote: On 8 February 2018 at 19:13, Thomas Huth wrote: I'm currently facing some issues with "make check -j4" (i.e. running the tests in parallel). Git bise

Re: [Qemu-devel] "make check -j4" hangs

2018-02-09 Thread Klim Kireev
On 02/08/2018 10:13 PM, Thomas Huth wrote: > On 30.01.2018 20:49, Paolo Bonzini wrote: >> On 25/01/2018 08:51, Klim Kireev wrote: >>> The following behavior was observed for QEMU configured by libvirt >>> to use guest agent as usual for the guests without virtio-serial

[Qemu-devel] [PATCH] vnc: fix segfault in closed connection handling

2018-02-07 Thread Klim Kireev
such an occurrence. Signed-off-by: Klim Kireev --- Changelog: v2: Attach the backtrace v3: Change checks ui/vnc-jobs.c | 6 -- ui/vnc.c | 15 ++- 2 files changed, 18 insertions(+), 3 deletions(-) diff --git a/ui/vnc-jobs.c b/ui/vnc-jobs.c index e326679dd0..868dddef4b 1006

Re: [Qemu-devel] [PATCH v2] vnc: fix segfault in closed connection handling

2018-02-07 Thread klim
On 02/07/2018 11:42 AM, klim wrote: On 01/31/2018 07:44 PM, Daniel P. Berrangé wrote: On Wed, Jan 31, 2018 at 07:25:21PM +0300, Klim Kireev wrote: On one of our client's node, due to trying to read from closed ioc, a segmentation fault occured. Corresponding backtrace: 0  object_get_

Re: [Qemu-devel] [PATCH v2] vnc: fix segfault in closed connection handling

2018-02-07 Thread klim
On 01/31/2018 07:44 PM, Daniel P. Berrangé wrote: On Wed, Jan 31, 2018 at 07:25:21PM +0300, Klim Kireev wrote: On one of our client's node, due to trying to read from closed ioc, a segmentation fault occured. Corresponding backtrace: 0 object_get_class (obj=obj@entry=0

[Qemu-devel] [PATCH] tests/test-filter-redirector: move close()

2018-02-01 Thread Klim Kireev
close socket after recieving. Signed-off-by: Klim Kireev --- tests/test-filter-redirector.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/test-filter-redirector.c b/tests/test-filter-redirector.c index f2566144cf..fbaf19bbd8 100644 --- a/tests/test-filter-redirector.c

[Qemu-devel] [PATCH v2] vnc: fix segfault in closed connection handling

2018-01-31 Thread Klim Kireev
vents due to some reasons the ioc_tag was set again and after vnc_disconnect_finish the handler is running with freed ioc, which led to the segmentation fault. The patch checks vs->disconnecting in places where we call qio_channel_add_watch to prevent such an occurrence. Signed-off-by: Kli

Re: [Qemu-devel] [PATCH] vnc: fix segfault in closed connection handling

2018-01-31 Thread klim
On 01/31/2018 04:16 PM, Marc-André Lureau wrote: Hi On Wed, Jan 31, 2018 at 2:06 PM, Klim Kireev wrote: On one of our client's node, due to trying to read from closed ioc, a segmentation fault occured. Corresponding backtrace: Oops, you probably forgot an extra space befor

[Qemu-devel] [PATCH v2] vnc: fix segfault in closed connection handling

2018-01-31 Thread Klim Kireev
vents due to some reasons the ioc_tag was set again and after vnc_disconnect_finish the handler is running with freed ioc, which led to the segmentation fault. I suggest to check ioc_tag in vnc_disconnect_finish to prevent such an occurrence. Signed-off-by: Klim Kireev --- Changelog: v2: Appl

[Qemu-devel] [PATCH] vnc: fix segfault in closed connection handling

2018-01-31 Thread Klim Kireev
e two events due to some reasons the ioc_tag was set again and after vnc_disconnect_finish the handler is running with freed ioc, which led to the segmentation fault. I suggest to check ioc_tag in vnc_disconnect_finish to prevent such an occurrence. Signed-off-by: Klim Kireev --- ui/vnc.c | 4 ++

[Qemu-devel] [PATCH v5] chardev/char-socket: add POLLHUP handler

2018-01-25 Thread Klim Kireev
or not. Signed-off-by: Klim Kireev --- Changelog: v2: Remove timer as a redundant feature v3: Remove read call and return G_SOURCE_REMOVE v4: Move to GSource API v5: Fix git typos chardev/char-socket.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/chardev/char-soc

[Qemu-devel] [PATCH v4] chardev/char-socket: add POLLHUP handler

2018-01-25 Thread Klim Kireev
or not. Signed-off-by: Klim Kireev --- Changelog: v2: Remove timer as a redundant feature v3: Remove read call and return G_SOURCE_REMOVE v4: Move to GSource API chardev/char-socket.c | 22 ++ dtc | 2 +- 2 files changed, 23 insertions(+), 1 deletion(-

[Qemu-devel] [PATCH v3] chardev/char-socket: add POLLHUP handler

2018-01-19 Thread Klim Kireev
or not. Signed-off-by: Klim Kireev --- Changelog: v2: Remove timer as a redundant feature v3: Remove read call and return G_SOURCE_REMOVE chardev/char-socket.c | 25 - 1 file changed, 24 insertions(+), 1 deletion(-) diff --git a/chardev/char-socket.c b/chardev/char

Re: [Qemu-devel] [PATCH 0/5 v3] preparation for Parallels Disk xml driver

2018-01-19 Thread klim
On 01/12/2018 12:01 PM, Klim Kireev wrote: ping Parallels Desktop and Parallels Cloud Server uses images glued with the bundle description in XML format. This series contains very basic description of this XML files and makes preparations for actual implementation to be followed. Signed-off-by

Re: [Qemu-devel] [PATCH v2] chardev/char-socket: add POLLHUP handler

2018-01-18 Thread klim
On 01/18/2018 06:49 PM, Marc-André Lureau wrote: Hi On Thu, Jan 18, 2018 at 3:33 PM, Klim Kireev wrote: The following behavior was observed for QEMU configured by libvirt to use guest agent as usual for the guests without virtio-serial driver (Windows or the guest remaining in BIOS stage

[Qemu-devel] [PATCH v2] chardev/char-socket: add POLLHUP handler

2018-01-18 Thread Klim Kireev
or not. Signed-off-by: Klim Kireev --- Changelog: v2: Remove timer as a redundant feature chardev/char-socket.c | 29 - 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/chardev/char-socket.c b/chardev/char-socket.c index 77cdf487eb..d3fe903ab6 100644 ---

Re: [Qemu-devel] [PATCH] chardev/char-socket: add POLLHUP handler

2018-01-18 Thread klim
On 01/18/2018 12:44 PM, Paolo Bonzini wrote: On 18/01/2018 10:41, klim wrote: I propose to install a separate pullhup watcher regardless of whether the device waits for data or not. After closing the connection, the guest has a capability to read the data within timeout. I don't understan

Re: [Qemu-devel] [PATCH] chardev/char-socket: add POLLHUP handler

2018-01-18 Thread klim
On 01/16/2018 08:25 PM, Paolo Bonzini wrote: On 10/01/2018 14:18, Klim Kireev wrote: The following behavior was observed for QEMU configured by libvirt to use guest agent as usual for the guests without virtio-serial driver (Windows or the guest remaining in BIOS stage). In QEMU on first

[Qemu-devel] [PATCH 4/5] block/parallels: replace some magic numbers

2018-01-12 Thread Klim Kireev
Signed-off-by: Klim Kireev Reviewed-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Denis V. Lunev CC: Stefan Hajnoczi --- block/parallels.c | 5 +++-- block/parallels.h | 2 ++ 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/block/parallels.c b/block/parallels.c index

[Qemu-devel] [PATCH 2/5] configure: add dependency

2018-01-12 Thread Klim Kireev
understand libxml2 types. Signed-off-by: Denis V. Lunev Signed-off-by: Klim Kireev Signed-off-by: Edgar Kaziakhmedov CC: Stefan Hajnoczi --- block/Makefile.objs | 2 ++ configure | 27 +++ scripts/checkpatch.pl | 1 + 3 files changed, 30 insertions

[Qemu-devel] [PATCH 5/5] block/parallels: add backing support to readv/writev

2018-01-12 Thread Klim Kireev
From: Edgar Kaziakhmedov Since parallels format supports backing files, refine readv/writev (allocate_clusters) to redirect read/write requests to a backing file (if cluster is not available in the current bs). Signed-off-by: Edgar Kaziakhmedov Signed-off-by: Vladimir Sementsov-Ogievskiy Signe

[Qemu-devel] [PATCH 0/5 v3] preparation for Parallels Disk xml driver

2018-01-12 Thread Klim Kireev
Parallels Desktop and Parallels Cloud Server uses images glued with the bundle description in XML format. This series contains very basic description of this XML files and makes preparations for actual implementation to be followed. Signed-off-by: Edgar Kaziakhmedov Signed-off-by: Klim Kireev

[Qemu-devel] [PATCH 1/5] docs/interop/prl-xml: description of Parallels Disk format

2018-01-12 Thread Klim Kireev
This patch adds main information about Parallels Disk format, which consists of DiskDescriptor.xml and other files. Signed-off-by: Edgar Kaziakhmedov Signed-off-by: Klim Kireev Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Denis V. Lunev CC: Stefan Hajnoczi --- docs/interop/prl

[Qemu-devel] [PATCH 3/5] block/parallels: move some structures into header

2018-01-12 Thread Klim Kireev
To implement xml format, some defines and structures from parallels.c are required. Signed-off-by: Klim Kireev Reviewed-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Denis V. Lunev CC: Stefan Hajnoczi --- block/parallels.c | 53 +- block/parallels.h | 86

[Qemu-devel] [PATCH 4/5] block/parallels: replace some magic numbers

2018-01-10 Thread Klim Kireev
Signed-off-by: Klim Kireev Reviewed-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Denis V. Lunev CC: Stefan Hajnoczi --- block/parallels.c | 5 +++-- block/parallels.h | 2 ++ 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/block/parallels.c b/block/parallels.c index

[Qemu-devel] [PATCH 2/5] configure: add dependency

2018-01-10 Thread Klim Kireev
understand libxml2 types. Signed-off-by: Denis V. Lunev Signed-off-by: Klim Kireev Signed-off-by: Edgar Kaziakhmedov CC: Stefan Hajnoczi --- block/Makefile.objs | 2 ++ configure | 27 +++ scripts/checkpatch.pl | 1 + 3 files changed, 30 insertions

[Qemu-devel] [PATCH 5/5] block/parallels: add backing support to readv/writev

2018-01-10 Thread Klim Kireev
From: Edgar Kaziakhmedov Since parallels format supports backing files, refine readv/writev (allocate_clusters) to redirect read/write requests to a backing file (if cluster is not available in the current bs). Signed-off-by: Edgar Kaziakhmedov Signed-off-by: Vladimir Sementsov-Ogievskiy Signe

[Qemu-devel] [PATCH 1/5] docs/interop/prl-xml: description of Parallels Disk format

2018-01-10 Thread Klim Kireev
This patch adds main information about Parallels Disk format, which consists of DiskDescriptor.xml and other files. Signed-off-by: Edgar Kaziakhmedov Signed-off-by: Klim Kireev Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Denis V. Lunev CC: Stefan Hajnoczi --- docs/interop/prl

[Qemu-devel] [PATCH 3/5] block/parallels: move some structures into header

2018-01-10 Thread Klim Kireev
To implement xml format, some defines and structures from parallels.c are required. Signed-off-by: Klim Kireev Reviewed-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Denis V. Lunev CC: Stefan Hajnoczi --- block/parallels.c | 53 +- block/parallels.h | 86

[Qemu-devel] [PATCH 0/5 v2] preparation for Parallels Disk xml driver

2018-01-10 Thread Klim Kireev
Parallels Desktop and Parallels Cloud Server uses images glued with the bundle description in XML format. This series contains very basic description of this XML files and makes preparations for actual implementation to be followed. Signed-off-by: Edgar Kaziakhmedov Signed-off-by: Klim Kireev

Re: [Qemu-devel] [PATCH 1/5] docs/interop/prl-xml: description of Parallels Disk format

2018-01-10 Thread klim
On 01/04/2018 02:34 PM, Stefan Hajnoczi wrote: On Mon, Dec 18, 2017 at 02:09:07PM +0300, Denis V. Lunev wrote: From: Klim Kireev This patch adds main information about Parallels Disk format, which consists of DiskDescriptor.xml and other files. Signed-off-by: Edgar Kaziakhmedov Signed-off

Re: [Qemu-devel] [Qemu-block] [PATCH 2/5] configure: add dependency

2018-01-10 Thread klim
On 12/22/2017 03:38 PM, Roman Kagan wrote: On Mon, Dec 18, 2017 at 02:09:08PM +0300, Denis V. Lunev wrote: From: Klim Kireev This dependency is required for adequate Parallels images support. Typically the disk consists of several images which are glued by XML disk descriptor. Also XML hides

[Qemu-devel] [PATCH] chardev/char-socket: add POLLHUP handler

2018-01-10 Thread Klim Kireev
a or not. After closing the connection, the guest has a capability to read the data within timeout. Signed-off-by: Klim Kireev --- chardev/char-socket.c | 55 ++- 1 file changed, 54 insertions(+), 1 deletion(-) diff --git a/chardev/char-socket.c

[Qemu-devel] [PATCH v3] qemu-img: add the simplest format recognition

2017-12-01 Thread Klim Kireev
heuristic to recognize the image format for qcow, qcow2, vmdk, vhdx, vdi It warns users about guessed format and informs them about '-f' option. Signed-off-by: Klim Kireev --- qemu-img.c | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/qemu-im

[Qemu-devel] [PATCH v2] qemu-img: add the simplest format recognition

2017-12-01 Thread Klim Kireev
simple heuristic to recognize the image format for qcow, qcow2, vmdk, vhdx, vdi It warns users about guessed format and informs them about '-f' option. Signed-off-by: Klim Kireev --- qemu-img.c | 21 +++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/qe

[Qemu-devel] [PATCH] qemu-img: add the simplest format recognition

2017-12-01 Thread Klim Kireev
simple heuristic to recognize the image format for qcow, qcow2, vmdk, vhdx, vdi Signed-off-by: Klim Kireev Reviewed-by: Vladimir Sementsov-Ogievskiy --- qemu-img.c | 24 ++-- 1 file changed, 22 insertions(+), 2 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 02a6e27beb