[Qemu-devel] [Bug 899664] [NEW] Bad internet performance for Host to Guest or Guest to Host

2011-12-03 Thread max
Public bug reported: Hi, Internet performance for Host to Quest is low. The speed Guest to same Guest is 11.3 Gbits/sec The speed Host to same Host is similar (9.8-11 Gbits/sec) But the speed from Guest to Host is slow and around 1Gbit/sec. In the reality traffic never leave a Host. I expect

[Qemu-devel] [Bug 965867] Re: 9p virtual file system on qemu slow

2012-04-23 Thread max
One of possible problems could be a block size. In this case I am using ZFS with raidZ 4+1 drives. Each drive has 4Kb block. So optimal block size is 16384 bytes. By optimizing block size it possible to improve performance 10 folds but 9p stably provides 10 folds worse performance than native write

[Qemu-devel] [Bug 965867] Re: 9p virtual file system on qemu slow

2012-04-23 Thread max
>>>Can you try with security_model=passthrough? It provides the same results, see below: $ dd if=/dev/zero of=test count=10 10+0 records in 10+0 records out 5120 bytes (51 MB) copied, 19.8581 s, 2.6 MB/s $ dd if=/dev/zero of=test count=10 bs=16384 10+0 records in 10+

[Qemu-devel] [Bug 965867] Re: 9p virtual file system on qemu slow

2012-04-26 Thread max
Hi Mohan, this parameter provide significant improvement in big file access/write: VirtFS on /srv/shared type 9p (rw,trans=virtio,version=9p2000.L,msize=262144) $ dd if=/dev/zero of=test count=10 bs=

Re: [Qemu-devel] [PATCH] eepro100: prevent an infinite loop over same command block

2015-10-19 Thread max
I will try to test the PoC on real e100. But this work may need some more time. 发自我的 iPhone > 在 2015年10月20日,上午11:04,Jason Wang 写道: > > > >> On 10/17/2015 07:35 PM, Peter Maydell wrote: >>> On 16 October 2015 at 22:37, Stefan Weil wrote: >>> Maybe real hardware will run an endless loop? >>>

[Qemu-devel] [Bug 636095] [NEW] tap downscript is not executed when exiting qemu through "quit" monitor command

2010-09-11 Thread Max
Public bug reported: When you tell qemu to shutdown using the "quit" monitor command, the downscript of the tap interface is not executed. To reproduce: Create the test script /tmp/qemu-ifdown-test.sh : == #!/bin/bash touch /tmp/is_this_working == Run: == # chmod +x /tmp/qemu-ifdown-test.s

Re: [Qemu-devel] [PATCH v2 1/9] jobs: change start callback to run callback

2018-08-31 Thread Max Reitz
On 2018-08-30 02:06, John Snow wrote: > > > On 08/27/2018 05:30 AM, Max Reitz wrote: >> On 2018-08-24 00:08, John Snow wrote: >>> Presently we codify the entry point for a job as the "start" callback, >>> but a more apt name would be "run" to

Re: [Qemu-devel] [PATCH v3 5/9] block/mirror: utilize job_exit shim

2018-08-31 Thread Max Reitz
t, this is safe to > defer the possible flushing of any nodes to the job_finalize_single > cleanup stage. > > Signed-off-by: John Snow > --- > block/mirror.c | 29 +++-- > 1 file changed, 11 insertions(+), 18 deletions(-) Reviewed-by: Max Reitz

Re: [Qemu-devel] [PATCH v3 8/9] jobs: remove ret argument to job_completed; privatize it

2018-08-31 Thread Max Reitz
ob.h | 28 +++- > job.c | 11 ++- > trace-events | 2 +- > 3 files changed, 22 insertions(+), 19 deletions(-) Reviewed-by: Max Reitz signature.asc Description: OpenPGP digital signature

Re: [Qemu-devel] [PATCH v3 0/9] jobs: Job Exit Refactoring Pt 1

2018-08-31 Thread Max Reitz
s, dropped the superfluous g_strdup() in patch 2 and applied to my block branch: https://git.xanclic.moe/XanClic/qemu/commits/branch/block Max signature.asc Description: OpenPGP digital signature

Re: [Qemu-devel] [PULL 00/11] Block patches

2018-08-31 Thread Max Reitz
On 2018-08-31 16:24, Max Reitz wrote: > The following changes since commit 19b599f7664b2ebfd0f405fb79c14dd241557452: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-error-2018-08-27-v2' > into staging (2018-08-27 16:44:20 +0100) > > are availa

[Qemu-devel] [PULL 09/11] block/backup: make function variables consistently named

2018-08-31 Thread Max Reitz
From: John Snow Rename opaque_job to job to be consistent with other job implementations. Rename 'job', the BackupBlockJob object, to 's' to also be consistent. Suggested-by: Eric Blake Signed-off-by: John Snow Reviewed-by: Max Reitz Message-id: 20180830015734.19765-8-js.

[Qemu-devel] [PULL 02/11] tests: fix bdrv-drain leak

2018-08-31 Thread Max Reitz
Message-id: 20180809114417.28718-3-marcandre.lur...@redhat.com Signed-off-by: Max Reitz --- tests/test-bdrv-drain.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/test-bdrv-drain.c b/tests/test-bdrv-drain.c index 17bb8508ae..abc8bbe6f0 100644 --- a/tests/test-bdrv-drain.c +++ b/tests

[Qemu-devel] [PULL 03/11] jobs: change start callback to run callback

2018-08-31 Thread Max Reitz
lbacks later. As part of this clarification, change the signature to include an error object and a return code. The error ptr is not yet used, and the return code while captured, will be overwritten by actions in the job_completed function. Signed-off-by: John Snow Reviewed-by: Max Reitz Message

[Qemu-devel] [PULL 11/11] jobs: remove job_defer_to_main_loop

2018-08-31 Thread Max Reitz
From: John Snow Now that the job infrastructure is handling the job_completed call for all implemented jobs, we can remove the interface that allowed jobs to schedule their own completion. Signed-off-by: John Snow Reviewed-by: Max Reitz Message-id: 20180830015734.19765-10-js...@redhat.com

[Qemu-devel] [PULL 10/11] jobs: remove ret argument to job_completed; privatize it

2018-08-31 Thread Max Reitz
leted static to job.c and remove it from job.h; move the documentation of return code to the .run() callback and to the job->ret property, accordingly. Signed-off-by: John Snow Message-id: 20180830015734.19765-9-js...@redhat.com Reviewed-by: Max Reitz Signed-off-by: Max Reitz --- include/qe

[Qemu-devel] [PULL 01/11] file-posix: Skip effectiveless OFD lock operations

2018-08-31 Thread Max Reitz
From: Fam Zheng If we know we've already locked the bytes, don't do it again; similarly don't unlock a byte if we haven't locked it. This doesn't change the behavior, but fixes a corner case explained below. Libvirt had an error handling bug that an image can get its (ownership, file mode, SELin

[Qemu-devel] [PULL 05/11] jobs: add exit shim

2018-08-31 Thread Max Reitz
less tricky to write. Signed-off-by: John Snow Reviewed-by: Max Reitz Message-id: 20180830015734.19765-4-js...@redhat.com Reviewed-by: Jeff Cody Signed-off-by: Max Reitz --- include/qemu/job.h | 11 +++ job.c | 18 ++ 2 files changed, 29 insertions(+)

[Qemu-devel] [PULL 07/11] block/mirror: utilize job_exit shim

2018-08-31 Thread Max Reitz
flushing of any nodes to the job_finalize_single cleanup stage. Signed-off-by: John Snow Message-id: 20180830015734.19765-6-js...@redhat.com Reviewed-by: Max Reitz Reviewed-by: Jeff Cody Signed-off-by: Max Reitz --- block/mirror.c | 29 +++-- 1 file changed, 11 insertions

[Qemu-devel] [PULL 08/11] jobs: utilize job_exit shim

2018-08-31 Thread Max Reitz
flush. Signed-off-by: John Snow Reviewed-by: Max Reitz Message-id: 20180830015734.19765-7-js...@redhat.com Signed-off-by: Max Reitz --- block/backup.c| 16 block/create.c| 14 +++--- block/stream.c| 22 +++--- tests

[Qemu-devel] [PULL 06/11] block/commit: utilize job_exit shim

2018-08-31 Thread Max Reitz
implications for bjob->blk which will now be put down after this cleanup. Kevin highlights that we did not take any permissions for that backend at job creation time, so it is safe to reorder these operations. Signed-off-by: John Snow Reviewed-by: Max Reitz Message-id: 20180830015734.19765-5

[Qemu-devel] [PULL v2 01/10] tests: fix bdrv-drain leak

2018-08-31 Thread Max Reitz
Message-id: 20180809114417.28718-3-marcandre.lur...@redhat.com Signed-off-by: Max Reitz --- tests/test-bdrv-drain.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/test-bdrv-drain.c b/tests/test-bdrv-drain.c index 17bb8508ae..abc8bbe6f0 100644 --- a/tests/test-bdrv-drain.c +++ b/tests

[Qemu-devel] [PULL v2 02/10] jobs: change start callback to run callback

2018-08-31 Thread Max Reitz
lbacks later. As part of this clarification, change the signature to include an error object and a return code. The error ptr is not yet used, and the return code while captured, will be overwritten by actions in the job_completed function. Signed-off-by: John Snow Reviewed-by: Max Reitz Message

[Qemu-devel] [PULL 04/11] jobs: canonize Error object

2018-08-31 Thread Max Reitz
be removed shortly in a separate patch. Signed-off-by: John Snow Message-id: 20180830015734.19765-3-js...@redhat.com [mreitz: Dropped a superfluous g_strdup()] Reviewed-by: Eric Blake Signed-off-by: Max Reitz --- include/qemu/job.h| 14 -- block/backup.c|

[Qemu-devel] [PULL 00/11] Block patches

2018-08-31 Thread Max Reitz
The following changes since commit 19b599f7664b2ebfd0f405fb79c14dd241557452: Merge remote-tracking branch 'remotes/armbru/tags/pull-error-2018-08-27-v2' into staging (2018-08-27 16:44:20 +0100) are available in the Git repository at: https://git.xanclic.moe/XanClic/qemu.git tags/pull-block-

[Qemu-devel] [PULL v2 08/10] block/backup: make function variables consistently named

2018-08-31 Thread Max Reitz
From: John Snow Rename opaque_job to job to be consistent with other job implementations. Rename 'job', the BackupBlockJob object, to 's' to also be consistent. Suggested-by: Eric Blake Signed-off-by: John Snow Reviewed-by: Max Reitz Message-id: 20180830015734.19765-8-js.

[Qemu-devel] [PULL v2 05/10] block/commit: utilize job_exit shim

2018-08-31 Thread Max Reitz
implications for bjob->blk which will now be put down after this cleanup. Kevin highlights that we did not take any permissions for that backend at job creation time, so it is safe to reorder these operations. Signed-off-by: John Snow Reviewed-by: Max Reitz Message-id: 20180830015734.19765-5

[Qemu-devel] [PULL v2 06/10] block/mirror: utilize job_exit shim

2018-08-31 Thread Max Reitz
flushing of any nodes to the job_finalize_single cleanup stage. Signed-off-by: John Snow Message-id: 20180830015734.19765-6-js...@redhat.com Reviewed-by: Max Reitz Reviewed-by: Jeff Cody Signed-off-by: Max Reitz --- block/mirror.c | 29 +++-- 1 file changed, 11 insertions

[Qemu-devel] [PULL v2 00/10] Block patches

2018-08-31 Thread Max Reitz
The following changes since commit 19b599f7664b2ebfd0f405fb79c14dd241557452: Merge remote-tracking branch 'remotes/armbru/tags/pull-error-2018-08-27-v2' into staging (2018-08-27 16:44:20 +0100) are available in the Git repository at: https://git.xanclic.moe/XanClic/qemu.git tags/pull-block-

[Qemu-devel] [PULL v2 03/10] jobs: canonize Error object

2018-08-31 Thread Max Reitz
be removed shortly in a separate patch. Signed-off-by: John Snow Message-id: 20180830015734.19765-3-js...@redhat.com [mreitz: Dropped a superfluous g_strdup()] Reviewed-by: Eric Blake Signed-off-by: Max Reitz --- include/qemu/job.h| 14 -- block/backup.c|

[Qemu-devel] [PULL v2 09/10] jobs: remove ret argument to job_completed; privatize it

2018-08-31 Thread Max Reitz
leted static to job.c and remove it from job.h; move the documentation of return code to the .run() callback and to the job->ret property, accordingly. Signed-off-by: John Snow Message-id: 20180830015734.19765-9-js...@redhat.com Reviewed-by: Max Reitz Signed-off-by: Max Reitz --- include/qe

[Qemu-devel] [PULL v2 04/10] jobs: add exit shim

2018-08-31 Thread Max Reitz
less tricky to write. Signed-off-by: John Snow Reviewed-by: Max Reitz Message-id: 20180830015734.19765-4-js...@redhat.com Reviewed-by: Jeff Cody Signed-off-by: Max Reitz --- include/qemu/job.h | 11 +++ job.c | 18 ++ 2 files changed, 29 insertions(+)

[Qemu-devel] [PULL v2 07/10] jobs: utilize job_exit shim

2018-08-31 Thread Max Reitz
flush. Signed-off-by: John Snow Reviewed-by: Max Reitz Message-id: 20180830015734.19765-7-js...@redhat.com Signed-off-by: Max Reitz --- block/backup.c| 16 block/create.c| 14 +++--- block/stream.c| 22 +++--- tests

[Qemu-devel] [PULL v2 10/10] jobs: remove job_defer_to_main_loop

2018-08-31 Thread Max Reitz
From: John Snow Now that the job infrastructure is handling the job_completed call for all implemented jobs, we can remove the interface that allowed jobs to schedule their own completion. Signed-off-by: John Snow Reviewed-by: Max Reitz Message-id: 20180830015734.19765-10-js...@redhat.com

[Qemu-devel] [PATCH 1/2] tests/tcg/xtensa: move exception handlers to separate section

2018-08-31 Thread Max Filippov
Not all CPU configurations may have enough space for handler code between exception/interrupt vectors. Leave jumps to the handlers at the vectors, but move all handlers past the vectors area. Signed-off-by: Max Filippov --- tests/tcg/xtensa/linker.ld.S | 37

[Qemu-devel] [PATCH 0/2] tests/tcg/xtensa: exception vectors/handlers improvement

2018-08-31 Thread Max Filippov
exceptions are generated. Max Filippov (2): tests/tcg/xtensa: move exception handlers to separate section tests/tcg/xtensa: only generate defined exception handlers tests/tcg/xtensa/linker.ld.S | 37 ++--- tests/tcg/xtensa/vectors.S | 16 2 files

[Qemu-devel] [PATCH 2/2] tests/tcg/xtensa: only generate defined exception handlers

2018-08-31 Thread Max Filippov
Don't generate handlers for IRQ levels that are not defined for the CPU or for window overflow/underflow exceptions for configs w/o windowed registers. Signed-off-by: Max Filippov --- tests/tcg/xtensa/vectors.S | 16 1 file changed, 16 insertions(+) diff --git a/test

Re: [Qemu-devel] [PATCH v3 05/15] block/mirror: don't install backing chain on abort

2018-09-03 Thread Max Reitz
READY cancel, s->should_complete is 0 (which makes sense, because all the rest in this path is about replacing to_replace by target_bs, which we don't want to do on cancel), so this would not be executed. However, I think we do want to give the target the correct backing chain when the

Re: [Qemu-devel] [PATCH v3 06/15] block/mirror: conservative mirror_exit refactor

2018-09-03 Thread Max Reitz
vital code in assert(), as NDEBUG would make that code disappear. As far as I know, we have decided (at some point) not to ever enable NDEBUG in qemu, but, you know. Doing it right only costs one more line, and it would get you a Reviewed-by: Max Reitz > } > > static void mirror_throttle(MirrorBlockJob *s) signature.asc Description: OpenPGP digital signature

Re: [Qemu-devel] [PATCH v3 07/15] block/commit: refactor stream to use job callbacks

2018-09-03 Thread Max Reitz
On 2018-09-01 00:28, John Snow wrote: > Signed-off-by: John Snow > Reviewed-by: Max Reitz > --- > block/stream.c | 23 +++ > 1 file changed, 15 insertions(+), 8 deletions(-) You forgot to fix the commit title. ;-) Max signature.asc Description: OpenPGP digital signature

Re: [Qemu-devel] [PATCH v3 10/15] tests/test-blockjob-txn: move .exit to .clean

2018-09-03 Thread Max Reitz
On 2018-09-01 00:29, John Snow wrote: > The exit callback in this test actually only performs cleanup. > > Signed-off-by: John Snow > --- > tests/test-blockjob-txn.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Max Reitz signature.asc De

[Qemu-devel] [PATCH] linux-user: do setrlimit selectively

2018-09-04 Thread Max Filippov
g. it happens when running libstdc++ testsuite for xtensa target on x86_64 host. Don't call host setrlimit for memory-related resources when running 32-bit guest on 64-bit host. Signed-off-by: Max Filippov --- linux-user/syscall.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-)

Re: [Qemu-devel] [PATCH] linux-user: do setrlimit selectively

2018-09-04 Thread Max Filippov
On Tue, Sep 4, 2018 at 2:13 PM, Peter Maydell wrote: > On 4 September 2018 at 22:00, Max Filippov wrote: >> When running 32-bit guest on 64-bit host setrlimit guest calls that >> affect memory resources (RLIMIT_{AS,DATA,STACK}) don't always make sense >> as is. They

Re: [Qemu-devel] [PATCH] linux-user: do setrlimit selectively

2018-09-04 Thread Max Filippov
On Tue, Sep 4, 2018 at 3:10 PM, Peter Maydell wrote: > On 4 September 2018 at 23:02, Max Filippov wrote: >> On Tue, Sep 4, 2018 at 2:13 PM, Peter Maydell >> wrote: >>> I think the issue here is not related to 32-on-64 but to the fact >>> that we just pass th

Re: [Qemu-devel] [PATCH] linux-user: do setrlimit selectively

2018-09-04 Thread Max Filippov
On Tue, Sep 4, 2018 at 3:55 PM, Peter Maydell wrote: > On 4 September 2018 at 23:26, Max Filippov wrote: >> On Tue, Sep 4, 2018 at 3:10 PM, Peter Maydell >> wrote: >>> On 4 September 2018 at 23:02, Max Filippov wrote: > >>> You could make a case for al

[Qemu-devel] [PATCH 00/15] target/xtensa: preparation for FLIX support

2018-09-04 Thread Max Filippov
code. Max Filippov (15): target/xtensa: extract test for an illegal instruction target/xtensa: extract test for privileged instruction target/xtensa: extract test for syscall instruction target/xtensa: extract test for debug exception target/xtensa: extract test for window overflow

[Qemu-devel] [PATCH 04/15] target/xtensa: extract test for debug exception

2018-09-04 Thread Max Filippov
- mark break and break.n instructions; - collect debug cause bits from parameter 0 of instructions marked for debug exception; - put debug exception check right after syscall check; Signed-off-by: Max Filippov --- target/xtensa/translate.c | 23 +-- 1 file changed, 13

[Qemu-devel] [PATCH 02/15] target/xtensa: extract test for privileged instruction

2018-09-04 Thread Max Filippov
- mark privileged instructions; - put single privileged instruction check after disassembly loop; - translate_[di]cache: drop parameter 0, shift parameters one down; Signed-off-by: Max Filippov --- target/xtensa/translate.c | 387 +++--- 1 file changed

[Qemu-devel] [PATCH 03/15] target/xtensa: extract test for syscall instruction

2018-09-04 Thread Max Filippov
- mark syscall instruction; - put syscall exception check right after privileged exception check; Signed-off-by: Max Filippov --- target/xtensa/translate.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/target/xtensa/translate.c b/target/xtensa/translate.c

[Qemu-devel] [PATCH 01/15] target/xtensa: extract test for an illegal instruction

2018-09-04 Thread Max Filippov
results in local array; Signed-off-by: Max Filippov --- target/xtensa/cpu.h | 27 +++- target/xtensa/helper.c| 6 + target/xtensa/helper.h| 1 + target/xtensa/op_helper.c | 72 + target/xtensa/translate.c | 367 +- 5 files

[Qemu-devel] [PATCH 06/15] target/xtensa: extract test for window underflow exception

2018-09-04 Thread Max Filippov
- mark retw and retw.n instructions; - extract window inderflow test from retw helper; - put underflow exception check generation right after the overflow check; Signed-off-by: Max Filippov --- target/xtensa/helper.h| 1 + target/xtensa/op_helper.c | 24 +++- target

[Qemu-devel] [PATCH 07/15] target/xtensa: extract test for alloca exception

2018-09-04 Thread Max Filippov
- mark movsp instruction; - put test for alloca exception right after the test for window underflow; Signed-off-by: Max Filippov --- target/xtensa/translate.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/target/xtensa/translate.c b/target/xtensa/translate.c

[Qemu-devel] [PATCH 08/15] target/xtensa: extract test for cpdisabled exception

2018-09-04 Thread Max Filippov
disabled exception after the alloca test; Signed-off-by: Max Filippov --- target/xtensa/cpu.h | 1 + target/xtensa/translate.c | 230 -- 2 files changed, 123 insertions(+), 108 deletions(-) diff --git a/target/xtensa/cpu.h b/target/xtensa/cpu.h index

[Qemu-devel] [PATCH 12/15] target/xtensa: always end TB on CCOUNT access/CCOMPARE write

2018-09-04 Thread Max Filippov
Currently we only end TB in icount mode, because access to CCOUNT or write to CCOMPARE are IO operations. Simplify the behaviour a bit and end TB unconditionally. Signed-off-by: Max Filippov --- target/xtensa/translate.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff

[Qemu-devel] [PATCH 09/15] target/xtensa: extract test for division by zero

2018-09-04 Thread Max Filippov
- mark quos/quou/rems/remu instructions; - drop parameter 0 from the translate_quou and split translate_remu from it; - put test for division by zero exception right after the coprocessor exception test; Signed-off-by: Max Filippov --- target/xtensa/translate.c | 53

Re: [Qemu-devel] [PATCH] linux-user: do setrlimit selectively

2018-09-04 Thread Max Filippov
completely, so if that variant has better chances for positive review I'll gladly send it. -- Thanks. -- Max

[Qemu-devel] [PATCH 11/15] target/xtensa: change SR number checks to assertions

2018-09-04 Thread Max Filippov
Opcode decoding with libisa takes care about range of valid group SRs, like CCOMPARE, IBREAKA, DBREAKA or DBREAKC. Turn range checks in wsr implementations into assertions. Signed-off-by: Max Filippov --- target/xtensa/translate.c | 65 +-- 1 file

[Qemu-devel] [PATCH 10/15] target/xtensa: extract unconditional TB termination

2018-09-04 Thread Max Filippov
- mark all instructions that exit TB and require dynamic search for the next TB; - put TB termination right after the instruction translation loop; Signed-off-by: Max Filippov --- target/xtensa/translate.c | 67 --- 1 file changed, 28 insertions

[Qemu-devel] [PATCH 13/15] target/xtensa: extract unconditional TB termination via slot 0

2018-09-04 Thread Max Filippov
- mark instructions that require TB termination via slot 0; - put TB termination right after the instruction translation loop, if termination w/o TB linking wasn't requested; Signed-off-by: Max Filippov --- target/xtensa/translate.c | 83 --- 1

[Qemu-devel] [PATCH 14/15] target/xtensa: make rsr/wsr helpers return void

2018-09-04 Thread Max Filippov
Now that all logic for TB termination is extracted from rsr/wsr their return value is not used and may be dropped. Signed-off-by: Max Filippov --- target/xtensa/translate.c | 102 -- 1 file changed, 36 insertions(+), 66 deletions(-) diff --git a

[Qemu-devel] [PATCH 15/15] target/xtensa: extract gen_check_interrupts call

2018-09-04 Thread Max Filippov
- mark instructions that affect active IRQ level; - put call for gen_check_interrupts right after the instruction translation; when FLIX is enabled it will need to appear before other exits from the TB as well; Signed-off-by: Max Filippov --- target/xtensa/translate.c | 78

Re: [Qemu-devel] [PATCH v4 04/15] block/commit: refactor commit to use job callbacks

2018-09-05 Thread Max Reitz
b has not yet failed; >>> and abort can be called after prepare. >>> >>> complete -> prepare -> abort -> clean >>> complete -> abort -> clean >>> >>> Signed-off-by: John Snow >>> Reviewed-by: Max Reitz >>> --- &

Re: [Qemu-devel] [PATCH v4 05/15] block/mirror: don't install backing chain on abort

2018-09-05 Thread Max Reitz
Sure, it makes sense, but why is it in this patch now? :-) (Moving it into the next patch would make more sense, I think.) I'd like to give an R-b anyway, but I know that I shouldn't, so I won't. Max signature.asc Description: OpenPGP digital signature

Re: [Qemu-devel] [PATCH v4 06/15] block/mirror: conservative mirror_exit refactor

2018-09-05 Thread Max Reitz
; 1 file changed, 27 insertions(+), 7 deletions(-) Reviewed-by: Max Reitz (Although I believe the ?: hunk from the previous patch should be here. Also note that we have a couple of places that make use of the GNU extension for "?:" as a binary operator (as in "x ?: y" return

Re: [Qemu-devel] [PATCH v4 10/15] tests/test-blockjob-txn: move .exit to .clean

2018-09-05 Thread Max Reitz
On 2018-09-04 19:09, John Snow wrote: > The exit callback in this test actually only performs cleanup. > > Signed-off-by: John Snow > --- > tests/test-blockjob-txn.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Max Reitz signature.asc De

Re: [Qemu-devel] [PATCH v4 04/15] block/commit: refactor commit to use job callbacks

2018-09-05 Thread Max Reitz
On 2018-09-05 12:49, Kevin Wolf wrote: > Am 05.09.2018 um 12:27 hat Max Reitz geschrieben: >> On 2018-09-04 22:32, John Snow wrote: >>> >>> >>> On 09/04/2018 02:46 PM, Jeff Cody wrote: >>>> On Tue, Sep 04, 2018 at 01:09:19PM -0400, John Snow wrote: &

Re: [Qemu-devel] [PATCH v4 04/15] block/commit: refactor commit to use job callbacks

2018-09-05 Thread Max Reitz
On 2018-09-05 13:53, Kevin Wolf wrote: > Am 05.09.2018 um 13:37 hat Max Reitz geschrieben: >> On 2018-09-05 12:49, Kevin Wolf wrote: >>> Am 05.09.2018 um 12:27 hat Max Reitz geschrieben: >>>> On 2018-09-04 22:32, John Snow wrote: >>>>> >>>>&

Re: [Qemu-devel] [PATCH v2 03/10] block: Remove child references from bs->{options, explicit_options}

2018-09-05 Thread Max Reitz
block_stream hd2 0 hd0.qcow2 > > Now hd0 is the backing file of hd2, but hd2's options QDicts still > contain backing=hd1. > > Signed-off-by: Alberto Garcia > --- > block.c | 13 - > 1 file changed, 12 insertions(+), 1 deletion(-) Reviewed-by: Max Reitz signature.asc Description: OpenPGP digital signature

Re: [Qemu-devel] [PATCH v2 05/10] block: Allow child references on reopen

2018-09-05 Thread Max Reitz
>{options,explicit_options} after the reopening has been completed. > > Signed-off-by: Alberto Garcia > --- > block.c | 18 ++ > 1 file changed, 18 insertions(+) Reviewed-by: Max Reitz signature.asc Description: OpenPGP digital signature

Re: [Qemu-devel] [PATCH v2 06/10] block: Forbid trying to change unsupported options during reopen

2018-09-05 Thread Max Reitz
BDRV_OPT_CACHE_DIRECT and BDRV_OPT_READ_ONLY > from going back to the QDict. > > Signed-off-by: Alberto Garcia > --- > block.c | 22 +++--- > 1 file changed, 7 insertions(+), 15 deletions(-) Reviewed-by: Max Reitz signature.asc Description: OpenPGP digital signature

Re: [Qemu-devel] [PATCH v2 07/10] file-posix: Forbid trying to change unsupported options during reopen

2018-09-05 Thread Max Reitz
eturn an error if the user tries to > change any of them. > > Signed-off-by: Alberto Garcia > --- > block/file-posix.c | 9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-) Reviewed-by: Max Reitz signature.asc Description: OpenPGP digital signature

Re: [Qemu-devel] [PATCH v2 08/10] block: Allow changing 'discard' on reopen

2018-09-05 Thread Max Reitz
discard=on" >Cannot change the option 'discard' > > Since there's no reason why we shouldn't allow changing it and the > implementation is simple let's just do it. > > Signed-off-by: Alberto Garcia > Cc: Max Reitz > --- > block.c |

Re: [Qemu-devel] [PATCH v2 09/10] block: Allow changing 'detect-zeroes' on reopen

2018-09-05 Thread Max Reitz
en -o detect-zeroes=on" >Cannot change the option 'detect-zeroes' > > Since there's no reason why we shouldn't allow changing it and the > implementation is simple let's just do it. > >

Re: [Qemu-devel] [PATCH v2 10/10] block: Allow changing 'force-share' on reopen

2018-09-05 Thread Max Reitz
er this patch the above reopen call will > still return an error -although a different one- if the image is not > read-only: > >(qemu) qemu-io virtio0 "reopen -o force-share=on" >force-share=on can only be used with read-only images > > Signed-off-by: Alberto

[Qemu-devel] [PATCH v2] linux-user: do setrlimit selectively

2018-09-05 Thread Max Filippov
libstdc++ testsuite for xtensa target on x86_64 host. Don't call host setrlimit for memory-related resources. Signed-off-by: Max Filippov --- Changes v1->v2: - don't limit change to 32-bit guest on 64-bit host case linux-user/syscall.c | 8 +++- 1 file changed, 7 insertions(+

Re: [Qemu-devel] [PATCH for-3.1 v10 04/31] block: Add BDS.auto_backing_file

2018-09-07 Thread Max Reitz
On 2018-09-05 16:22, Alberto Garcia wrote: > On Thu 09 Aug 2018 11:35:01 PM CEST, Max Reitz wrote: >> If the backing file is overridden, this most probably does change the >> guest-visible data of a BDS. Therefore, we will need to consider this >> in bdrv_refresh_filename().

Re: [Qemu-devel] [PATCH for-3.1 v10 31/31] iotests: Test json:{} filenames of internal BDSs

2018-09-07 Thread Max Reitz
On 2018-09-05 16:44, Alberto Garcia wrote: > On Thu 09 Aug 2018 11:35:28 PM CEST, Max Reitz wrote: >> +vm.shutdown() >> + >> +#assert top_name[:5] == 'json:' >> +#top_options = json.loads(top_name[5:]) >> + >> +#if fi

Re: [Qemu-devel] [PATCH v4 05/15] block/mirror: don't install backing chain on abort

2018-09-07 Thread Max Reitz
On 2018-09-05 17:39, John Snow wrote: > > > On 09/05/2018 06:40 AM, Max Reitz wrote: >> On 2018-09-04 19:09, John Snow wrote: >>> In cases where we abort the block/mirror job, there's no point in >>> installing the new backing chain before we finish abort

Re: [Qemu-devel] [PATCH for-3.1 v10 04/31] block: Add BDS.auto_backing_file

2018-09-07 Thread Max Reitz
On 2018-09-07 14:28, Alberto Garcia wrote: > On Fri 07 Sep 2018 01:32:58 PM CEST, Max Reitz wrote: >> On 2018-09-05 16:22, Alberto Garcia wrote: >>> On Thu 09 Aug 2018 11:35:01 PM CEST, Max Reitz wrote: >>>> If the backing file is overridden, this most probably does

Re: [Qemu-devel] [PATCH v5 04/16] block/commit: refactor commit to use job callbacks

2018-09-07 Thread Max Reitz
-> clean > > During refactor, a potential problem with bdrv_drop_intermediate > was identified, The patched behavior is no worse than the pre-patch (s/T/t/) (Max) > behavior, so leave a FIXME for now to be fixed in a future patch. > > Signed-off-by: John Snow

Re: [Qemu-devel] [PATCH v5 05/16] block/mirror: don't install backing chain on abort

2018-09-07 Thread Max Reitz
On 2018-09-06 15:02, John Snow wrote: > In cases where we abort the block/mirror job, there's no point in > installing the new backing chain before we finish aborting. > > Signed-off-by: John Snow > --- > block/mirror.c | 2 +- > 1 file changed, 1 insertion(+), 1 del

Re: [Qemu-devel] [PATCH v5 06/16] block/mirror: conservative mirror_exit refactor

2018-09-07 Thread Max Reitz
d mirror_exit(Job *job) > > /** > * mirror_exit_common: handle both abort() and prepare() cases. > * for .prepare, returns 0 on success and -errno on failure. > * for .abort cases, denoted by abort = true, MUST return 0. > */ Any case: Reviewed-by: Max Reitz signature.asc Description: OpenPGP digital signature

Re: [Qemu-devel] [PATCH v5 16/16] blockdev: document transactional shortcomings

2018-09-07 Thread Max Reitz
at that time. > > Signed-off-by: John Snow > --- > blockdev.c | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) Reviewed-by: Max Reitz signature.asc Description: OpenPGP digital signature

Re: [Qemu-devel] [PATCH v5 00/16] jobs: Job Exit Refactoring Pt 2

2018-09-07 Thread Max Reitz
the mirror_exit() comment you proposed in patch 6, and applied to my block branch: https://git.xanclic.moe/XanClic/qemu/commits/branch/block Max signature.asc Description: OpenPGP digital signature

[Qemu-devel] [PATCH] target/xtensa: support input from chardev console

2018-09-08 Thread Max Filippov
Complete xtensa-semi chardev console implementation: allow reading input characters from file descriptor 0 and call sys_select_one simcall on it. Signed-off-by: Max Filippov --- target/xtensa/xtensa-semi.c | 55 ++--- 1 file changed, 52 insertions(+), 3

Re: [Qemu-devel] [PATCH for-3.1 v10 00/31] block: Fix some filename generation issues

2018-09-10 Thread Max Reitz
On 10.09.18 17:18, Kevin Wolf wrote: > Am 09.08.2018 um 23:34 hat Max Reitz geschrieben: >> Once more, I’ll spare both me and you another iteration of the cover >> letter, so see here: >> >> http://lists.nongnu.org/archive/html/qemu-block/2017-09/msg01030.html >> &

[Qemu-devel] [PATCH v2] target/xtensa: support input from chardev console

2018-09-10 Thread Max Filippov
Complete xtensa-semi chardev console implementation: allow reading input characters from file descriptor 0 and call sys_select_one simcall on it. Signed-off-by: Max Filippov --- Changes v1->v2: - put CharBackend and input buffer into the XtensaSimConsole structure target/xtensa/xtensa-sem

[Qemu-devel] [PATCH] target/xtensa: fix s32c1i TCGMemOp flags

2018-09-10 Thread Max Filippov
s32c1i must load and store value with target endianness, not host. This results in an infinite loop in atomic cmpxchg sequences when target endianness doesn't match host endianness. Fixes: 9fb40342d4b3 ("target/xtensa: support MTTCG") Cc: qemu-sta...@nongnu.org Signed-off-b

Re: [Qemu-devel] Can I only commit from active image to corresponding range of its backing file by qemu cmd?

2018-09-13 Thread Max Reitz
tains 3s from 2M to 3M; img.003 contains 4s from 0M to 1M (the range of img.000)) In that case, rebase -u might be what you want, so the following should work (although it can easily corrupt your data if it isn't the case[1]): $ qemu-img rebase -u -b img.000 img.003 $ qemu-img commit img.003 (And

Re: [Qemu-devel] [PATCH v3 08/10] block: Allow changing 'discard' on reopen

2018-09-13 Thread Max Reitz
d=on" >Cannot change the option 'discard' > > Since there's no reason why we shouldn't allow changing it and the > implementation is simple let's just do it. > > Signed-off-by: Alberto Garcia > --- > block.c | 11 +++ > 1 f

Re: [Qemu-devel] [PATCH v3 09/10] block: Allow changing 'detect-zeroes' on reopen

2018-09-13 Thread Max Reitz
| 64 > --- > include/block/block.h | 1 + > 2 files changed, 41 insertions(+), 24 deletions(-) Reviewed-by: Max Reitz signature.asc Description: OpenPGP digital signature

Re: [Qemu-devel] [PATCH v2 01/17] job: Fix missing locking due to mismerge

2018-09-13 Thread Max Reitz
oved the first aio_context_acquire(), the other fix removed > the other one. Now we have a bug again and the code is run without any > locking. > > Add it back in one of the places. > > Signed-off-by: Kevin Wolf > --- > job.c | 4 > 1 file changed, 4 insertions(+) R

Re: [Qemu-devel] [PATCH v2 02/17] blockjob: Wake up BDS when job becomes idle

2018-09-13 Thread Max Reitz
> threads. > > Signed-off-by: Kevin Wolf > Reviewed-by: Fam Zheng > --- > include/block/blockjob.h | 13 + > include/qemu/job.h | 3 +++ > blockjob.c | 18 ++ > job.c| 7 +++ >

Re: [Qemu-devel] [PATCH v2 06/17] job: Use AIO_WAIT_WHILE() in job_finish_sync()

2018-09-13 Thread Max Reitz
ed-off-by: Kevin Wolf > Reviewed-by: Fam Zheng > --- > job.c | 14 ++ > 1 file changed, 6 insertions(+), 8 deletions(-) Reviewed-by: Max Reitz signature.asc Description: OpenPGP digital signature

Re: [Qemu-devel] [PATCH v2 08/17] block: Add missing locking in bdrv_co_drain_bh_cb()

2018-09-13 Thread Max Reitz
> 3 files changed, 25 insertions(+) I suppose the coroutine lock you mean is the one aio_co_enter() takes? If so: Reviewed-by: Max Reitz (Sorry, I still really don't have much understanding of how coroutines, bottom halves, and all nice things like them work.) signature.asc Description: OpenPGP digital signature

Re: [Qemu-devel] [PATCH v2 09/17] block-backend: Add .drained_poll callback

2018-09-13 Thread Max Reitz
new requests. > > Signed-off-by: Kevin Wolf > Reviewed-by: Fam Zheng > --- > block/block-backend.c | 9 + > 1 file changed, 9 insertions(+) Reviewed-by: Max Reitz signature.asc Description: OpenPGP digital signature

Re: [Qemu-devel] Can I only commit from active image to corresponding range of its backing file by qemu cmd?

2018-09-13 Thread Max Reitz
On 13.09.18 19:05, Eric Blake wrote: > [adding Markus, because of an interesting observation about --image-opts > vs. JSON null - search for [1] below] > > On 9/13/18 8:22 AM, Max Reitz wrote: >> On 13.09.18 05:33, lampahome wrote: >>> I split data to 3 chunks and save

Re: [Qemu-devel] Can I only commit from active image to corresponding range of its backing file by qemu cmd?

2018-09-13 Thread Max Reitz
On 13.09.18 20:37, Max Reitz wrote: [...] > Or, we would have to use backing=null, but for some reason that doesn't > work. I'll have to investigate. Turns out this was fixed in e59a0cf17b1b9932b65e6fc25d6856976f5e4831. (Why does Fedora still have only qemu 2.11?) > So reb

Re: [Qemu-devel] [PATCH v2 10/17] block-backend: Fix potential double blk_delete()

2018-09-13 Thread Max Reitz
+++- > 1 file changed, 6 insertions(+), 1 deletion(-) Reviewed-by: Max Reitz signature.asc Description: OpenPGP digital signature

Re: [Qemu-devel] Can I only commit from active image to corresponding range of its backing file by qemu cmd?

2018-09-13 Thread Max Reitz
On 13.09.18 22:01, Eric Blake wrote: > On 9/13/18 1:37 PM, Max Reitz wrote: >> On 13.09.18 19:05, Eric Blake wrote: [...] >>> $ qemu-io -c 'discard 0 1m' --image-opts >>> driver=qcow2,backing=,file.driver=file,file.filename=img.003 >>> warning: Us

  1   2   3   4   5   6   7   8   9   10   >