Re: [PATCH 1/3] scsi: fetch unit attention when creating the request

2024-10-11 Thread Michael Tokarev
On 09.10.2024 21:00, Michael Galaxy wrote: Thanks for your help. - Michael On 10/9/24 11:28, Paolo Bonzini wrote: Yes, it looks like an easy backport. Adding Michael Tokarev and qemu-stable. Paolo On Wed, Oct 9, 2024 at 6:03 PM Michael Galaxy wrote: Hi All, We have stumbled upon this

Re: [PATCH] net: Check if nc is NULL in qemu_get_vnet_hdr_len()

2024-10-10 Thread Michael S. Tsirkin
5 ("tap: Remove qemu_using_vnet_hdr()") > Reported-by: Jonathan Cameron > Signed-off-by: Akihiko Odaki Acked-by: Michael S. Tsirkin Jason, you tree? > --- > net/net.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/net/net.c b/net/net.c > index 6938da05e077..

Re: [PATCH 1/3] scsi: fetch unit attention when creating the request

2024-10-09 Thread Michael Galaxy
Thanks for your help. - Michael On 10/9/24 11:28, Paolo Bonzini wrote: !---| This Message Is From an External Sender This message came from outside your organization

Re: [PATCH 1/3] scsi: fetch unit attention when creating the request

2024-10-09 Thread Michael Galaxy
we kindly ask to pull this identical patch for 7.2.15? Last year, it just went to master and landed in 8.0.50. We're planning to upgrade, but it will be quite some time before we get around to that, and I suspect others are also running 7.2.x in production. - Michael Galaxy On 7/12/23

Re: [PATCH] hw/net/net_rx_pkt: Remove deadcode

2024-10-09 Thread Michael Tokarev
09.10.2024 11:32, Jason Wang wrote: Queued. Jason, please do a git pull first ;) /mjt

Re: [PATCH v2] net/tap-win32: Fix gcc 14 format truncation errors

2024-10-08 Thread Michael Tokarev
"%s\\%s\\Connection", | ^~ 344 | NETWORK_CONNECTIONS_KEY, enum_name); ... Signed-off-by: Bernhard Beschow Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2607 Cc: qemu-sta...@nongnu.org Reviewed-by: Michael Tokarev /mjt

Re: [PATCH v1 0/2] GTK/SDL fixes for a black screen displayed by virtio-gpu

2024-10-07 Thread Michael Tokarev
07.10.2024 23:19, Dmitry Osipenko wrote: Is it a -stable material?  Myself I haven't seen this prob so far, so it might be not worth the effort.  Also, any idea when the prob has been introduced (or since when it has become real)? The problem is reproducible with a stable Qemu. With SDL displa

Re: [PATCH v1 0/2] GTK/SDL fixes for a black screen displayed by virtio-gpu

2024-10-07 Thread Michael Tokarev
07.10.2024 02:43, Dmitry Osipenko wrote: Hi, This patchset fixes black screen displayed by Qemu using virtio-gpu. There is a race condition bug with a timer that disables display output after it has been enabled by virtio-gpu. The problem is reproducible by running Qemu with a disabled GL vsync.

[Stable-9.1.1 13/32] softmmu: Support concurrent bounce buffers

2024-10-07 Thread Michael Tokarev
limit for PCI devices. Signed-off-by: Mattias Nissler Reviewed-by: Philippe Mathieu-Daudé Acked-by: Peter Xu Link: https://lore.kernel.org/r/20240819135455.2957406-1-mniss...@rivosinc.com Signed-off-by: Peter Xu (cherry picked from commit 637b0aa139565cb82a7b9269e62214f87082635c) Signed-off-b

[Stable-9.1.1 25/32] target/ppc: Fix lxvx/stxvx facility check

2024-10-07 Thread Michael Tokarev
oshkevich Reviewed-by: Fabiano Rosas Message-ID: <20240911141651.6914-1-faro...@suse.de> Signed-off-by: Richard Henderson (cherry picked from commit 8bded2e73e80823a67f730140788a3c5e60bf4b5) Signed-off-by: Michael Tokarev diff --git a/target/ppc/translate/vsx-impl.c.inc b/target/pp

[Stable-9.1.1 27/32] util/timer: avoid deadlock when shutting down

2024-10-07 Thread Michael Tokarev
time forward. Reported-by: Elisha Hollander Signed-off-by: Alex Bennée Reviewed-by: Pierrick Bouvier Message-Id: <20240916085400.1046925-15-alex.ben...@linaro.org> (cherry picked from commit bc02be4508d8753d1f6071b77d10f4661587df6f) Signed-off-by: Michael Tokarev diff --git a/util/qemu-tim

[Stable-9.1.1 16/32] mac_dbdma: Remove leftover `dma_memory_unmap` calls

2024-10-07 Thread Michael Tokarev
445e1bef72c) Signed-off-by: Michael Tokarev diff --git a/hw/ide/macio.c b/hw/ide/macio.c index e84bf2c9f6..15dd40138e 100644 --- a/hw/ide/macio.c +++ b/hw/ide/macio.c @@ -119,9 +119,6 @@ static void pmac_ide_atapi_transfer_cb(void *opaque, int ret) return; done: -dma_memory_unmap(&add

[Stable-9.1.1 21/32] target/ppc: Fix migration of CPUs with TLB_EMB TLB type

2024-10-07 Thread Michael Tokarev
fects the PPC 405, 440, 460 and e200 CPU families. Cc: qemu-sta...@nongnu.org Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2522 Reviewed-by: Peter Maydell Signed-off-by: Arman Nabiev Signed-off-by: Fabiano Rosas (cherry picked from commit 203beb6f047467a4abfc8267c234393cea3f471c) Signe

[Stable-9.1.1 02/32] iotests: fix expected output from gnutls

2024-10-07 Thread Michael Tokarev
from one of the NBD tests. Reported-by: Thomas Huth Signed-off-by: Daniel P. Berrangé (cherry picked from commit 48b8583698d96d6290726400789fcd51c55691b1) Signed-off-by: Michael Tokarev diff --git a/tests/qemu-iotests/233.out b/tests/qemu-iotests/233.out index 1910f7df20..d498d55e0e 100644

[Stable-9.1.1 28/32] block/reqlist: allow adding overlapping requests

2024-10-07 Thread Michael Tokarev
k-backend.c:1473 > #15 0x61528538da6c in blockstatus_to_extents (...) at ../nbd/server.c:2374 > #16 0x61528538deb1 in nbd_co_send_block_status (...) at > ../nbd/server.c:2481 > #17 0x61528538f424 in nbd_handle_request (...) at ../nbd/server.c:2978 > #18 0x61

[Stable-9.1.1 06/32] tests/docker: remove debian-armel-cross

2024-10-07 Thread Michael Tokarev
d from commit d0068b746a0a8cd4bb148527a0d199b130cd5288) Signed-off-by: Michael Tokarev diff --git a/.gitlab-ci.d/container-cross.yml b/.gitlab-ci.d/container-cross.yml index e3103940a0..9a3ebd885e 100644 --- a/.gitlab-ci.d/container-cross.yml +++ b/.gitlab-ci.d/container-cross.yml @@ -22,12 +22,6 @@

[Stable-9.1.1 29/32] target/arm: Avoid target_ulong for physical address lookups

2024-10-07 Thread Michael Tokarev
ked from commit 67d762e716a7127ecc114e9708254316dd521911) Signed-off-by: Michael Tokarev diff --git a/target/arm/internals.h b/target/arm/internals.h index 203a2dae14..38545552d0 100644 --- a/target/arm/internals.h +++ b/target/arm/internals.h @@ -1430,7 +1430,7 @@ typedef struct GetPhysAddrResult { * * f

[Stable-9.1.1 24/32] tcg: Fix iteration step in 32-bit gvec operation

2024-10-07 Thread Michael Tokarev
commit 9d8d5a5b9078a16b4c0862fe54248c5cc8435648) Signed-off-by: Michael Tokarev diff --git a/tcg/tcg-op-gvec.c b/tcg/tcg-op-gvec.c index 0308732d9b..78ee1ced80 100644 --- a/tcg/tcg-op-gvec.c +++ b/tcg/tcg-op-gvec.c @@ -3939,7 +3939,7 @@ void tcg_gen_gvec_cmps(TCGCond cond, unsigned vece, uint32_

[Stable-9.1.1 20/32] target/hppa: Fix random 32-bit linux-user crashes

2024-10-07 Thread Michael Tokarev
d188d8 ("target/hppa: Do not mask in copy_iaoq_entry") Cc: qemu-sta...@nongnu.org # v9.1+ Signed-off-by: Helge Deller Reviewed-by: Richard Henderson (cherry picked from commit d33d3adb573794903380e03e767e06470514cefe) Signed-off-by: Michael Tokarev diff --git a/target/hppa/cpu.h

[Stable-9.1.1 07/32] tests/docker: update debian i686 and mipsel images to bookworm

2024-10-07 Thread Michael Tokarev
ge-Id: <20240910173900.4154726-3-alex.ben...@linaro.org> (cherry picked from commit 19d2111059c87d3f58349f27b9be9dee81fc1681) Signed-off-by: Michael Tokarev diff --git a/tests/docker/dockerfiles/debian-i686-cross.docker b/tests/docker/dockerfiles/debian-i686-cross.docker index 3fe8ee623d..2328ee

[Stable-9.1.1 32/32] vnc: fix crash when no console attached

2024-10-07 Thread Michael Tokarev
_select()") Fixes: https://issues.redhat.com/browse/RHEL-50529 Cc: qemu-sta...@nongnu.org Signed-off-by: Marc-André Lureau Reviewed-by: Akihiko Odaki Reviewed-by: Michael Tokarev Signed-off-by: Michael Tokarev (cherry picked from commit 0e60fc80938d9ce84274a36ddfaaa640bdef2be8) Signed-off

[Stable-9.1.1 22/32] migration/multifd: Fix p->iov leak in multifd-uadk.c

2024-10-07 Thread Michael Tokarev
nitialization") Reported-by: Peter Xu Reviewed-by: Peter Xu Signed-off-by: Fabiano Rosas (cherry picked from commit 405e352d28c24991cacfdebccf67d56c4795cf6e) Signed-off-by: Michael Tokarev diff --git a/migration/multifd-uadk.c b/migration/multifd-uadk.c index d12353fb21..9a582fc919 100644 --- a

[Stable-9.1.1 04/32] crypto: check gnutls & gcrypt support the requested pbkdf hash

2024-10-07 Thread Michael Tokarev
-Daudé Signed-off-by: Daniel P. Berrangé (cherry picked from commit e6c09ea4f9e5f8af92a6453642b84b9efd52892f) Signed-off-by: Michael Tokarev diff --git a/crypto/pbkdf-gcrypt.c b/crypto/pbkdf-gcrypt.c index a8d8e64f4d..bc0719c831 100644 --- a/crypto/pbkdf-gcrypt.c +++ b/crypto/pbkdf-gcrypt.c

[Stable-9.1.1 26/32] hw/mips/jazz: fix typo in in-built NIC alias

2024-10-07 Thread Michael Tokarev
/mips/jazz: use qemu_find_nic_info()") Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: David Woodhouse Reviewed-by: Michael Tokarev Signed-off-by: Michael Tokarev (cherry picked from commit 2e4fdf566062c03456230fd8136b88c5c1e5c4bf) Signed-off-by: Michael Tokarev diff --

[Stable-9.1.1 18/32] hw/char/stm32l4x5_usart.c: Enable USART ACK bit response

2024-10-07 Thread Michael Tokarev
rom commit 6cce0dcc6f7aaaeb7f1756da510b04f67c99) Signed-off-by: Michael Tokarev diff --git a/hw/char/stm32l4x5_usart.c b/hw/char/stm32l4x5_usart.c index fc5dcac0c4..3cf200c080 100644 --- a/hw/char/stm32l4x5_usart.c +++ b/hw/char/stm32l4x5_usart.c @@ -154,6 +154,21 @@ REG32(RDR, 0x24) REG32(TDR, 0x28) FIELD(TDR, TDR, 0, 9)

[Stable-9.1.1 23/32] hw/loongarch/virt: Add description for virt machine type

2024-10-07 Thread Michael Tokarev
n IPI with LoongArch IPI) Signed-off-by: Bibo Mao Reviewed-by: Thomas Huth Reviewed-by: Michael Tokarev Signed-off-by: Michael Tokarev (cherry picked from commit 4265b4f358436252ef36164566f316458f1df671) Signed-off-by: Michael Tokarev diff --git a/hw/loongarch/virt.c b/hw/loongarch/vi

[Stable-9.1.1 30/32] hw/sd/sdcard: Fix handling of disabled boot partitions

2024-10-07 Thread Michael Tokarev
ge-id: 20240906164834.130257-1-...@pengutronix.de Reviewed-by: Peter Maydell [PMM: added note to commit message about effects of bug] Signed-off-by: Peter Maydell (cherry picked from commit 9601076b3b0bced7ed597d1470e3ff2f4e7177d6) Signed-off-by: Michael Tokarev diff --git a/hw/sd/sd.c b/hw/sd/sd.c

[Stable-9.1.1 19/32] target/arm: Correct ID_AA64ISAR1_EL1 value for neoverse-v1

2024-10-07 Thread Michael Tokarev
c59b3) Signed-off-by: Michael Tokarev diff --git a/target/arm/tcg/cpu64.c b/target/arm/tcg/cpu64.c index fe232eb306..8516daefca 100644 --- a/target/arm/tcg/cpu64.c +++ b/target/arm/tcg/cpu64.c @@ -685,7 +685,7 @@ static void aarch64_neoverse_v1_initfn(Object *obj) cpu->isar.id_

[Stable-9.1.1 31/32] testing: bump mips64el cross to bookworm and fix package list

2024-10-07 Thread Michael Tokarev
41002080333.127172-1-th...@redhat.com> Reviewed-by: Daniel P. Berrangé Signed-off-by: Thomas Huth (cherry picked from commit c60473d29254b79d9437eface8b342e84663ba66) Signed-off-by: Michael Tokarev diff --git a/tests/docker/dockerfiles/debian-mips64el-cross.docker b/tests/docker/docker

[Stable-9.1.1 12/32] gitlab: fix logic for changing docker tag on stable branches

2024-10-07 Thread Michael Tokarev
"QEMU_JOB_SKIPPED" in the final rule that was meant to be a 'catch all' for staging branches. As a result stable branches are still splattering dockers from the primary development branch. Signed-off-by: Daniel P. Berrangé Reviewed-by: Michael Tokarev Tested-by: Michael

[Stable-9.1.1 08/32] contrib/plugins/Makefile: Add a 'distclean' target

2024-10-07 Thread Michael Tokarev
o avoid regressions with "make distclean", add this command to one of the build jobs, too. Message-ID: <20240902154749.73876-1-th...@redhat.com> Reviewed-by: Pierrick Bouvier Signed-off-by: Thomas Huth (cherry picked from commit 1231bc7d12c373e445171dda9e7e5146eee7da55) Signed-off-b

[Stable-9.1.1 10/32] hw/intc/arm_gic: fix spurious level triggered interrupts

2024-10-07 Thread Michael Tokarev
4826.3558302-1-jan.kloet...@kernkonzept.com Reviewed-by: Peter Maydell [PMM: expanded comment a little and converted to coding-style form; expanded commit message with the historical backstory] Signed-off-by: Peter Maydell (cherry picked from commit 110684c9a69a02cbabfbddcd3afa921826ad565c) Signed-of

[Stable-9.1.1 11/32] ui/sdl2: set swap interval explicitly when OpenGL is enabled

2024-10-07 Thread Michael Tokarev
commit ae23cd00170baaa2777eb1ee87b70f472dbb3c44) Signed-off-by: Michael Tokarev diff --git a/ui/sdl2.c b/ui/sdl2.c index 98ed974371..51299f3645 100644 --- a/ui/sdl2.c +++ b/ui/sdl2.c @@ -115,6 +115,7 @@ void sdl2_window_create(struct sdl2_console *scon) SDL_SetHint(SDL_HINT_RENDER_BATCHI

[Stable-9.1.1 09/32] hw/audio/virtio-sound: fix heap buffer overflow

2024-10-07 Thread Michael Tokarev
. This also prevents a heap buffer overflow. See QEMU issue #2296. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2296 Signed-off-by: Volker Rümelin Message-Id: <20240901130112.8242-1-vr_q...@t-online.de> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin (cherry

[Stable-9.1.1 05/32] crypto: avoid leak of ctx when bad cipher mode is given

2024-10-07 Thread Michael Tokarev
From: Daniel P. Berrangé Fixes: Coverity CID 1546884 Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P. Berrangé (cherry picked from commit 586ac2c67d707c2588766c5195d94fa553cc25af) Signed-off-by: Michael Tokarev diff --git a/crypto/cipher-nettle.c.inc b

[Stable-9.1.1 03/32] crypto: run qcrypto_pbkdf2_count_iters in a new thread

2024-10-07 Thread Michael Tokarev
-by: Michael Tokarev diff --git a/crypto/pbkdf.c b/crypto/pbkdf.c index 8d198c152c..d1c06ef3ed 100644 --- a/crypto/pbkdf.c +++ b/crypto/pbkdf.c @@ -19,6 +19,7 @@ */ #include "qemu/osdep.h" +#include "qemu/thread.h" #include "qapi/error.h" #include "crypto

[Stable-9.1.1 14/32] softmmu/physmem: fix memory leak in dirty_memory_extend()

2024-10-07 Thread Michael Tokarev
: David Hildenbrand Link: https://lore.kernel.org/r/20240828090743.128647-1-da...@redhat.com Signed-off-by: Peter Xu (cherry picked from commit b84f06c2bee727b3870b4eeccbe3a45c5aea14c1) Signed-off-by: Michael Tokarev diff --git a/include/exec/ramlist.h b/include/exec/ramlist.h index 2ad2a81acc

[Stable-9.1.1 00/32] Patch Round-up for stable 9.1.1, freeze on 2024-10-16

2024-10-07 Thread Michael Tokarev
The following patches are queued for QEMU stable v9.1.1: https://gitlab.com/qemu-project/qemu/-/commits/staging-9.1 Patch freeze is 2024-10-16, and the release is planned for 2024-10-18: https://wiki.qemu.org/Planning/9.1 Please respond here or CC qemu-sta...@nongnu.org on any additional pa

[Stable-9.1.1 17/32] migration/multifd: Fix rb->receivedmap cleanup race

2024-10-07 Thread Michael Tokarev
: Peter Xu (cherry picked from commit 4ce56229087860805877075ddb29dd44578365a9) Signed-off-by: Michael Tokarev diff --git a/migration/migration.c b/migration/migration.c index 3dea06d577..ae2be31557 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -378,6 +378,11 @@ void migration_in

[Stable-9.1.1 15/32] softmmu/physmem.c: Keep transaction attribute in address_space_map()

2024-10-07 Thread Michael Tokarev
ke a MemTxAttrs argument") Reviewed-by: Philippe Mathieu-Daudé Link: https://lore.kernel.org/r/20240912070404.2993976-2-fea.w...@sifive.com Signed-off-by: Peter Xu (cherry picked from commit d8d5ca40048b04750de5a0ae0b2b9f153a391951) Signed-off-by: Michael Tokarev diff --git a/system/physmem.

[Stable-9.1.1 01/32] target/hppa: Fix PSW V-bit packaging in cpu_hppa_get for hppa64

2024-10-07 Thread Michael Tokarev
ned-off-by: Michael Tokarev diff --git a/target/hppa/cpu.h b/target/hppa/cpu.h index 2bcb3b602b..5478b183dc 100644 --- a/target/hppa/cpu.h +++ b/target/hppa/cpu.h @@ -211,7 +211,7 @@ typedef struct CPUArchState { uint32_t psw;/* All psw bits except the following: */ uint3

Re: [PATCH v3 0/2] meson: ensure we enable CMPXCHG128 on x86_64

2024-10-07 Thread Michael Tokarev
07.10.2024 20:23, Paolo Bonzini wrote: Alex discovered that CMPXCHG128 was not enabled when building for x86_64, resulting in slow execution for wide atomic instructions, creating a huge contention when combined with a high number of cpus (found while booting android aarch64 guest on x86_64 host

Re: [PATCH] net/tap-win32: Fix gcc 14 format truncation errors

2024-10-07 Thread Michael Tokarev
07.10.2024 13:13, Bernhard Beschow wrote: The patch fixes the following errors generated by GCC 14.2: ../src/net/tap-win32.c:343:19: error: '%s' directive output may be truncated writing up to 255 bytes into a region of size 176 [-Werror=format-truncation=] 343 | "%s\\%s\\Connec

Re: [PATCH] target/loongarch: Support 4K page size

2024-10-07 Thread Michael Tokarev
07.10.2024 18:09, Richard Henderson wrote: The #2491 issue appears to be for user-mode emulation.  Because the reported host is x86, I would expect guest page size == host page size to improve performance, not degrade it. Yes, it is about linux-user. If this is really about user-mode, then p

Re: [PATCH 1/2] meson: define qemu_isa_flags

2024-10-07 Thread Michael Tokarev
07.10.2024 17:46, Richard Henderson пишет: On 10/7/24 01:43, Paolo Bonzini wrote: Create a separate variable for compiler flags that enable specific instruction set extensions, so that they can be used with cc.compiles/cc.links. Note that -mfpmath=sse is a code generation option but it does not

Re: [PATCH] target/loongarch: Support 4K page size

2024-10-07 Thread Michael Tokarev
23.10.2023 05:40, Song Gao wrote: The LoongArch kernel supports 4K page size. Change TARGET_PAGE_BITS to 12. This change appears to have 2 issues. First, the subject is misleading, - it does not only introduces support for 4K page size, it actually *switches* to 4K page size. But this is sor

Re: [PATCH 0/6] refactor RDMA live migration based on rsocket API

2024-10-07 Thread Michael Galaxy
you have any problems with it, like if it has compatibility issues or if we need a different solution. We're open to change. I'm not familiar with the "current state" of this or how well it would even work. - Michael On Fri, Oct 4, 2024 at 4:06 PM Michael Galaxy wrote

Re: [PATCH v2 0/2] meson: ensure we enable CMPXCHG128 on x86_64

2024-10-07 Thread Michael Tokarev
mu_isa_flags meson: ensure -mcx16 is passed when detecting ATOMIC128 meson.build | 33 - 1 file changed, 20 insertions(+), 13 deletions(-) Series: Reviewed-By: Michael Tokarev Yeah, this is exactly what I thought about when replying to email by Pierrick Bouvier.

Re: [PATCH v2 2/4] linux-user/flatload: Take mmap_lock in load_flt_binary()

2024-10-06 Thread Michael Tokarev
22.08.2024 12:50, Philippe Mathieu-Daudé wrote: load_flt_binary() calls load_flat_file() -> page_set_flags(). page_set_flags() must be called with the mmap_lock held, otherwise it aborts: $ qemu-arm -L stm32/lib/ stm32/bin/busybox qemu-arm: ../accel/tcg/user-exec.c:505: page_set_flags: As

Re: [PATCH] tcg/ppc: Use TCG_REG_TMP2 for scratch index in prepare_host_addr

2024-10-06 Thread Michael Tokarev
-ge3867bad0d "tcg/ppc: Introduce HostAddress" Fixes: v8.0.0-744-g01a112e2e9 "tcg/ppc: Reorg tcg_out_tlb_read" Tested-By: Michael Tokarev Also noted for -stable. Thank you! /mjt

Re: [PATCH] linux-user: Fix parse_elf_properties GNU0_MAGIC check

2024-10-05 Thread Michael Tokarev
than my version, but should do the trick too. I wasn't sure for my patch because I missed the for (int i = 0; i < n / 4; i++) { bswap32s() } loop, - now I see where it gets performs the conversion, and see why my patch works (and why it should work too) :) Either way, Reviewed-by:

Re: [PATCH] meson: ensure we enable CMPXCHG128 on x86_64

2024-10-05 Thread Michael Tokarev
05.10.2024 19:22, Michael Tokarev wrote: 05.10.2024 19:20, Richard Henderson wrote: No, it doesn't fail to link.  That's why it took so long to notice. It does here quite often during bisection between 9.0 and 9.1. Lemme see.. So, it is just 2 steps: $ git bisect start v9.0.0 v9.

Re: [PATCH] meson: ensure we enable CMPXCHG128 on x86_64

2024-10-05 Thread Michael Tokarev
05.10.2024 19:20, Richard Henderson wrote: On 10/5/24 09:16, Michael Tokarev wrote: Besides, in the current situation where CONFIG_CMPXCHG128 is not defined due to this bug, the final link fails due to generated calls to -latomic, - which might mean we have something else wrong. No, it

Re: [PATCH] meson: fix machine option for x86_version

2024-10-05 Thread Michael Tokarev
05.10.2024 19:08, Michael Tokarev wrote: 05.10.2024 01:37, Pierrick Bouvier wrote: s/mbmi1/mbmi/ When configuring with -Dx86_version >= 3, meson step works, but compilation fails because option -mbmi1 is unknown. Fixes: v9.0.0-1771-gef7d1adfa8 "meson: allow configuring the x86-64

Re: [PATCH] meson: ensure we enable CMPXCHG128 on x86_64

2024-10-05 Thread Michael Tokarev
05.10.2024 01:01, Pierrick Bouvier wrote: Alex discovered that CMPXCHG128 was not enabled when building for x86_64, resulting in slow execution for wide atomic instructions, creating a huge contention when combined with a high number of cpus (found while booting android aarch64 guest on x86_64 ho

Re: [PATCH] meson: fix machine option for x86_version

2024-10-05 Thread Michael Tokarev
05.10.2024 01:37, Pierrick Bouvier пишет: s/mbmi1/mbmi/ When configuring with -Dx86_version >= 3, meson step works, but compilation fails because option -mbmi1 is unknown. Fixes: v9.0.0-1771-gef7d1adfa8 "meson: allow configuring the x86-64 baseline" Revieved-by: Michael Tok

Re: [PATCH v5 54/65] q35: Introduce smm_ranges property for q35-pci-host

2024-10-05 Thread Michael Tokarev
29.02.2024 09:37, Xiaoyao Li wrote: From: Isaku Yamahata Add a q35 property to check whether or not SMM ranges, e.g. SMRAM, TSEG, etc... exist for the target platform. TDX doesn't support SMM and doesn't play nice with QEMU modifying related guest memory ranges. This change introduces a newl

[PATCH] net/slirp: introduce slirp_os_socket to stay compatible with libslirp past 4.8.0

2024-10-05 Thread Michael Tokarev
together wiht slirp_os_socket type), for libslirp <= 4.8.0, and use it in callback function definitions. Link: https://gitlab.freedesktop.org/slirp/libslirp/-/commit/72f85005a2307fd0961543e3cea861ad7a4d201e Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2603 Signed-off-by: Mich

[PATCH v3] tests/qtest: Add XIVE tests for the powernv10 machine

2024-10-04 Thread Michael Kowal
inject operations Co-authored-by: Frederic Barrat Co-authored-by: Glenn Miles Co-authored-by: Michael Kowal Signed-off-by: Frederic Barrat Signed-off-by: Glenn Miles Signed-off-by: Michael Kowal --- MAINTAINERS| 1 + tests/qtest/pnv-xive2-common.h | 111

[PULL 19/23] tests/tcg/plugins: Remove remainder of the cris target

2024-10-04 Thread Michael Tokarev
From: Thomas Huth The cris target has recently been removed (see commit 44e4075bf4 - "target/cris: Remove the deprecated CRIS target"), but apparently this line has been forgotten. So clean it up now. Signed-off-by: Thomas Huth Reviewed-by: Alex Bennée Reviewed-by: Michael Tokarev

[PULL 01/23] hw/audio/virtio-snd: Remove unnecessary "exec/tswap.h" header

2024-10-04 Thread Michael Tokarev
Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Manos Pitsidianakis Reviewed-by: Michael Tokarev Signed-off-by: Michael Tokarev --- hw/audio/virtio-snd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/audio/virtio-snd.c b/hw/audio/virtio-snd.c index 69838181dd..c5581d7b3d 100644 --

[PULL 23/23] MAINTAINERS: Add myself as maintainer of e500 machines

2024-10-04 Thread Michael Tokarev
From: Bernhard Beschow Signed-off-by: Bernhard Beschow Reviewed-by: Cédric Le Goater Reviewed-by: Daniel Henrique Barboza Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Michael Tokarev --- MAINTAINERS | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS

[PULL 15/23] replay: Remove unused replay_disable_events

2024-10-04 Thread Michael Tokarev
From: "Dr. David Alan Gilbert" replay_disable_events has been unused since 2019's c8aa7895eb ("replay: don't drain/flush bdrv queue while RR is working") Remove it. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Pavel Dovgalyuk Reviewed-by: Thomas Huth

[PULL 16/23] hw/pci: Remove unused pcie_chassis_find_slot

2024-10-04 Thread Michael Tokarev
From: "Dr. David Alan Gilbert" pcie_chassis_find_slot has been unused since it was added. Remove it. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Thomas Huth Reviewed-by: Michael Tokarev Signed-off-by: Michael Tokarev --- hw/pci/pcie_port.c | 10 -- incl

[PULL 22/23] docs/devel: Mention post_load hook restrictions where we document the hook

2024-10-04 Thread Michael Tokarev
; repeat it in the main migration documentation, where a developer trying to implement a post_load hook is more likely to see it. Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Michael Tokarev Signed-off-by: Michael Tokarev --- docs/devel/migration/main.rst | 6

[PULL 21/23] tests/functional: Fix hash validation

2024-10-04 Thread Michael Tokarev
accepting each hash as valid. Let's do a proper check again now. Fixes:05e303210d ("tests/functional/qemu_test: Use Python hashlib ...") Signed-off-by: Thomas Huth Reviewed-by: Michael Tokarev Signed-off-by: Michael Tokarev --- tests/functional/qemu_test/asset.py | 2 +- 1

[PULL 11/23] hw: Remove unused fw_cfg_init_io

2024-10-04 Thread Michael Tokarev
From: "Dr. David Alan Gilbert" fw_cfg_init_io has been unused since 918a7f706b ("i386: load kernel on xen using DMA") Remove it. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Igor Mammedov Reviewed-by: Thomas Huth Reviewed-by: Michael Tokarev Signed-off-by: Mich

[PULL 04/23] MAINTAINERS: remove gensyscalls.sh from the linux-user section

2024-10-04 Thread Michael Tokarev
From: Laurent Vivier The file has been removed by c52e40596834 ("linux-user,loongarch: move to syscalltbl file"). Signed-off-by: Laurent Vivier Signed-off-by: Michael Tokarev --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index

[PULL 18/23] block-backend: Remove deadcode

2024-10-04 Thread Michael Tokarev
ned-off-by: Dr. David Alan Gilbert Reviewed-by: Thomas Huth Reviewed-by: Michael Tokarev Signed-off-by: Michael Tokarev --- block/block-backend.c | 73 - include/sysemu/block-backend-global-state.h | 8 --- 2 files changed, 81 deletions(-) diff --gi

[PULL 00/23] Trivial patches for 2024-10-04

2024-10-04 Thread Michael Tokarev
The following changes since commit 423be09ab9492735924e73a2d36069784441ebc6: Merge tag 'warn-pull-request' of https://gitlab.com/marcandre.lureau/qemu into staging (2024-10-03 10:32:54 +0100) are available in the Git repository at: https://gitlab.com/mjt0k/qemu.git tags/pull-trivial-patches

[PULL 14/23] remote: Remove unused remote_iohub_finalize

2024-10-04 Thread Michael Tokarev
From: "Dr. David Alan Gilbert" remote_iohub_finalize has never been used. Remove it. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Jagannathan Raman Reviewed-by: Thomas Huth Reviewed-by: Michael Tokarev Signed-off-by: Michael Tokarev --- hw/remote/iohub.c

[PULL 05/23] hw/xen: Remove deadcode

2024-10-04 Thread Michael Tokarev
hem. Signed-off-by: Dr. David Alan Gilbert Acked-by: Anthony PERARD Reviewed-by: Edgar E. Iglesias Reviewed-by: Thomas Huth Reviewed-by: Michael Tokarev Signed-off-by: Michael Tokarev --- hw/xen/xen-legacy-backend.c | 18 -- hw/xen/xen_devconfig.c | 8

[PULL 17/23] hw/net/rocker: Remove unused rocker_fp_ports

2024-10-04 Thread Michael Tokarev
From: "Dr. David Alan Gilbert" rocker_fp_ports hasn't been used since it was added back in 2015. Remove it. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Thomas Huth Reviewed-by: Michael Tokarev Signed-off-by: Michael Tokarev --- hw/net/rocker/rocker.c | 5 -

[PULL 12/23] ui/cursor: remove cursor_get_mono_image

2024-10-04 Thread Michael Tokarev
From: "Dr. David Alan Gilbert" cursor_get_mono_image has been unused since 2018's 0015ca5cba ("ui: remove support for SDL1.2 in favour of SDL2") Remove it. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Marc-André Lureau Reviewed-by: Thomas Huth Reviewed-by

[PULL 06/23] q35: Remove unused mch_mcfg_base

2024-10-04 Thread Michael Tokarev
From: "Dr. David Alan Gilbert" mch_mcfg_base has been unused since it was added by 6f1426ab0f ("ich9: APIs for pc guest info") back in 2013. Remove it. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Bernhard Beschow Reviewed-by: Thomas Huth Reviewed-by: Michael To

[PULL 13/23] vhost: Remove unused vhost_dev_{load|save}_inflight

2024-10-04 Thread Michael Tokarev
nflight. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Igor Mammedov Reviewed-by: Stefano Garzarella Reviewed-by: Thomas Huth Reviewed-by: Michael Tokarev Signed-off-by: Michael Tokarev --- hw/virtio/vhost.c | 56 --- include/hw/virtio/vhos

[PULL 07/23] net: Remove deadcode

2024-10-04 Thread Michael Tokarev
pback") in turn it was the last user of qemu_net_queue_receive_iov. Remove them. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Thomas Huth Reviewed-by: Michael Tokarev Signed-off-by: Michael Tokarev --- include/net/net.h | 4 include/net/queue.h | 4 net/hub.c

[PULL 20/23] hw/mips: Build fw_cfg.c once

2024-10-04 Thread Michael Tokarev
From: Philippe Mathieu-Daudé Nothing in fw_cfg.c requires target-specific knowledge, build it once for the 4 MIPS variants. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: Michael Tokarev Signed-off-by: Michael Tokarev --- hw/mips/meson.build | 2 +- 1 file

[PULL 09/23] hw/char: Remove unused serial_set_frequency

2024-10-04 Thread Michael Tokarev
emove it. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Thomas Huth Reviewed-by: Michael Tokarev Signed-off-by: Michael Tokarev --- hw/char/serial.c | 7 --- include/hw/char/serial.h | 2 -- 2 files changed, 9 deletions(-) diff --git a/hw/char/serial.c b/hw/char/serial.c index

[PULL 02/23] qemu-keymap: Release local allocation references

2024-10-04 Thread Michael Tokarev
lue of the "state" variable is only referred in the current execution of the function and to put it on the stack. Release references to allocations and suppress the error once for all. Signed-off-by: Akihiko Odaki Reviewed-by: Marc-André Lureau Reviewed-by: Michael Tokarev Signed-off

[PULL 08/23] hw/net/net_rx_pkt: Remove deadcode

2024-10-04 Thread Michael Tokarev
From: "Dr. David Alan Gilbert" net_rx_pkt_get_l3_hdr_offset and net_rx_pkt_get_iovec_len haven't been used since they were added. Remove them. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Thomas Huth Reviewed-by: Michael Tokarev Signed-off-by: Michael Tokarev (Mj

[PULL 10/23] linux-user: Remove unused handle_vm86_fault

2024-10-04 Thread Michael Tokarev
From: "Dr. David Alan Gilbert" handle_vm86_fault has been unused since: 1ade5b2fed ("linux-user/i386: Split out maybe_handle_vm86_trap") Remove it, and it's local macros. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Thomas Huth Reviewed-by: Michael Tokare

[PULL 03/23] vnc: fix crash when no console attached

2024-10-04 Thread Michael Tokarev
_select()") Fixes: https://issues.redhat.com/browse/RHEL-50529 Cc: qemu-sta...@nongnu.org Signed-off-by: Marc-André Lureau Reviewed-by: Akihiko Odaki Reviewed-by: Michael Tokarev Signed-off-by: Michael Tokarev --- ui/vnc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --

Re: [PATCH 0/6] refactor RDMA live migration based on rsocket API

2024-10-04 Thread Michael Galaxy
04:26:27PM -0500, Michael Galaxy wrote: What about the testing solution that I mentioned? Does that satisfy your concerns? Or is there still a gap here that needs to be met? I think such testing framework would be helpful, especially if we can kick it off in CI when preparing pull requests, then

Re: [PATCH 0/6] refactor RDMA live migration based on rsocket API

2024-10-03 Thread Michael Galaxy
py on both sides with either transport. What about the testing solution that I mentioned? Does that satisfy your concerns? Or is there still a gap here that needs to be met? - Michael

[PATCH trivial] gitlab-ci/build-oss-fuzz: print FAILED marker in case the test failed and run all tests

2024-10-03 Thread Michael Tokarev
failure, so it becomes obvious what exactly has failed. While at it, continue running other tests even in case of failure, and exit non-zero if at least one test failed. Signed-off-by: Michael Tokarev --- .gitlab-ci.d/buildtest.yml | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff

Re: Rust BoF and maintainer minutes and planning the roadmap to Rust

2024-10-03 Thread Michael Tokarev
03.10.2024 12:56, Alex Bennée wrote: ... Are there any other big projects coming down the line that have indicated a need for rust support? Obviously you don't have to worry about the Linux kernel but I wonder how much rust userspace you currently have packaged? Do you have the rust-vmm vhost-dev

Re: [PATCH] hw/net/net_rx_pkt: Remove deadcode

2024-10-03 Thread Michael Tokarev
19.09.2024 01:51, d...@treblig.org wrote: From: "Dr. David Alan Gilbert" net_rx_pkt_get_l3_hdr_offset and net_rx_pkt_get_iovec_len haven't been used since they were added. Remove them. Applied to the trivial-patches tree, removing net_rx_pkt_get_l3_hdr_offset() prototype from hw/net/net_rx_p

Re: [PATCH] vnc: fix crash when no console attached

2024-10-02 Thread Michael Tokarev
:1607 Fixes: e99441a3793b5 ("ui/curses: Do not use console_select()") Fixes: https://issues.redhat.com/browse/RHEL-50529 Cc: qemu-sta...@nongnu.org Signed-off-by: Marc-André Lureau Reviewed-by: Michael Tokarev I'm picking this one up to trivial-patches tree, as no one else got to i

Re: [PATCH] linux-user/elfload.c: keep GNU0_MAGIC in host byte order

2024-10-02 Thread Michael Tokarev
02.10.2024 16:51, Laurent Vivier wrote: Le 02/10/2024 à 11:11, Michael Tokarev a écrit : Other places of this file operate in host byte order.  Only this constant is defined as little-endian.  This does not work, for example, on s390x host when running an arm64 binary:   qemu-arm64: /usr/bin

Re: [PATCH] qemu-keymap: Release local allocation references

2024-10-02 Thread Michael Tokarev
23.07.2024 11:49, Akihiko Odaki wrote: Commit 2523baf7fb4d ("qemu-keymap: Make references to allocations static") made references to allocations static to ensure LeakSanitizer can track them. This trick unfortunately did not work with gcc version 14.0.1; that compiler is clever enough to know tha

[PATCH] linux-user/elfload.c: keep GNU0_MAGIC in host byte order

2024-10-02 Thread Michael Tokarev
/guest for which debian provides release architectures, namely: amd64 arm64 armel armhf i386 mips64el ppc64el riscv64 s390x Fixes: v5.1.0-2580-g83f990eb5adb "linux-user/elfload: Parse NT_GNU_PROPERTY_TYPE_0 notes" Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2596 Signed-off-b

Re: [PULL 3/5] block/reqlist: allow adding overlapping requests

2024-10-01 Thread Michael Tokarev
30.09.2024 11:43, Vladimir Sementsov-Ogievskiy wrote: From: Fiona Ebner Allow overlapping request by removing the assert that made it impossible. There are only two callers: 1. block_copy_task_create() It already asserts the very same condition before calling reqlist_init_req(). 2. cbw_snaps

[PATCH v9 1/2] linux-user: add openat2 support in linux-user

2024-10-01 Thread Michael Vogt
it seems similar to the exiting behavior when openat() is called with a dirfd to "/proc". Here too the fake file lookup may not catch the special file because no dirfd is used to determine if the path is in /proc. Signed-off-by: Michael Vogt Buglink: https://github.com/osbuild/bootc-image

[PATCH v9 0/2] linux-user: add openat2 support in linux-user

2024-10-01 Thread Michael Vogt
This is v9 of the openat2 support in linux-user. Thanks to Laurent for spotting another missing tswap64() in v8 (and my appologies that I overlooked this). Looking forward to your feedback/ideas! Thanks, Michael v8 -> v9 - use "tswap64()" in strace.c for how.{flags,mode,resol

[PATCH v9 2/2] linux-user: add strace support for openat2

2024-10-01 Thread Michael Vogt
`syscall_defs.h` so that strace.c can use them. Signed-off-by: Michael Vogt --- linux-user/qemu.h | 9 linux-user/strace.c | 44 +++ linux-user/strace.list| 3 +++ linux-user/syscall.c | 8 +-- linux-user/syscall_defs.h

Re: [PATCH v7 0/5] AWS Nitro Enclave emulation support

2024-10-01 Thread Michael S. Tsirkin
On Sun, Sep 22, 2024 at 03:44:36PM +0600, Dorjoy Chowdhury wrote: > [7] https://lists.oasis-open.org/archives/virtio-comment/202310/msg00387.html That list is dead, would you mind reposting to the new list, so we can vote on it? Thanks! -- MST

[PATCH v8 2/2] linux-user: add strace support for openat2

2024-09-30 Thread Michael Vogt
`syscall_defs.h` so that strace.c can use them. Signed-off-by: Michael Vogt --- linux-user/qemu.h | 9 + linux-user/strace.c | 40 +++ linux-user/strace.list| 3 +++ linux-user/syscall.c | 8 +--- linux-user/syscall_defs.h

[PATCH v8 0/2] linux-user: add openat2 support in linux-user

2024-09-30 Thread Michael Vogt
This is v8 of the openat2 support in linux-user. Thanks for the feedback from Laurent on v7, really appreciated. This version addresses the feedback for v7. It's mostly details, see the changelog below. Looking forward to your feedback/ideas! Thanks, Michael v7 -> v8 - use

[PATCH v8 1/2] linux-user: add openat2 support in linux-user

2024-09-30 Thread Michael Vogt
it seems similar to the exiting behavior when openat() is called with a dirfd to "/proc". Here too the fake file lookup may not catch the special file because no dirfd is used to determine if the path is in /proc. Signed-off-by: Michael Vogt Buglink: https://github.com/osbuild/bootc-image

  1   2   3   4   5   6   7   8   9   10   >