[Qemu-devel] [PULL 19/22] linux-user: Fix fadvise64() syscall support for Mips32

2016-10-17 Thread riku . voipio
dar Rikalo <aleksandar.rik...@imgtec.com> Signed-off-by: Miroslav Tisma <miroslav.ti...@imgtec.com> Signed-off-by: Aleksandar Markovic <aleksandar.marko...@imgtec.com> Signed-off-by: Riku Voipio <riku.voi...@linaro.org> --- linux-user/mips/syscall_nr.h | 2 +- 1 file changed, 1 in

[Qemu-devel] [PULL 12/22] linux-user: use libc wrapper instead of direct mremap syscall

2016-10-17 Thread riku . voipio
64bit targets on 32bit hosts because of the default integer type promotions. Since glibc-2.4 is now a decade old, we can remove this workaround. Signed-off-by: Felix Janda <felix.ja...@posteo.de> Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> Signed-off-by: Riku Voipio <r

[Qemu-devel] [PULL 20/22] linux-user: added support for preadv() system call.

2016-10-17 Thread riku . voipio
which can be of different sizes on different platforms. The input arguments are converted to the appropriate host size when passed to safe_preadv(). Signed-off-by: Dejan Jovicevic <dejan.jovice...@rt-rk.com> Signed-off-by: Riku Voipio <riku.voi...@linaro.org> --- linux-u

[Qemu-devel] [PULL 22/22] linux-user: disable unicore32 linux-user build

2016-10-17 Thread riku . voipio
From: Riku Voipio <riku.voi...@linaro.org> In order to cleanup linux-user, we need support for most relatively modern syscalls. unicore32 lacks support for syscalls like epoll_pwait, preventing cleaning up the CONFIG_EPOLL mess. This patch can be reverted when unicore32 starts either supp

[Qemu-devel] [PULL 14/22] linux-user: Add support for clock_adjtime() syscall

2016-10-17 Thread riku . voipio
: Aleksandar Markovic <aleksandar.marko...@imgtec.com> Signed-off-by: Riku Voipio <riku.voi...@linaro.org> --- configure | 18 linux-user/strace.c| 76 ++ linux-user/strace.list | 3 ++ linux-user/syscall.c |

[Qemu-devel] [PULL 16/22] linux-user: Update mips_syscall_args[] array in main.c

2016-10-17 Thread riku . voipio
dar.marko...@imgtec.com> Signed-off-by: Riku Voipio <riku.voi...@linaro.org> --- linux-user/main.c | 24 ++-- 1 file changed, 22 insertions(+), 2 deletions(-) diff --git a/linux-user/main.c b/linux-user/main.c index 0e31dad..18d5a62 100644 --- a/linux-user/main.c +++ b/linux-user

[Qemu-devel] [PULL 15/22] linux-user: Add support for syncfs() syscall

2016-10-17 Thread riku . voipio
nsists of a straightforward invocation of host's syncfs(). Configure and strace support is included as well. Signed-off-by: Aleksandar Markovic <aleksandar.marko...@imgtec.com> Signed-off-by: Riku Voipio <riku.voi...@linaro.org> --- configure | 18 ++ linux-user/strace.l

[Qemu-devel] [PULL 10/22] linux-user: add RTA_PRIORITY in netlink

2016-10-17 Thread riku . voipio
From: Laurent Vivier <laur...@vivier.eu> Used by fedora21 on ppc64 in the network initialization Signed-off-by: Laurent Vivier <laur...@vivier.eu> Signed-off-by: Riku Voipio <riku.voi...@linaro.org> --- linux-user/syscall.c | 1 + 1 file changed, 1 insertion(+) diff

[Qemu-devel] [PULL 17/22] linux-user: Update ioctls definitions for Mips32

2016-10-17 Thread riku . voipio
From: Aleksandar Markovic <aleksandar.marko...@imgtec.com> Update linux-user/mips/termbits.h with ioctl definitions from kernel file arch/mips/include/uapi/asm/ioctls.h. Signed-off-by: Aleksandar Markovic <aleksandar.marko...@imgtec.com> Signed-off-by: Riku Voipio <riku.vo

[Qemu-devel] [PULL 13/22] linux-user: Fix definition of target_sigevent for 32-bit guests

2016-10-17 Thread riku . voipio
switch the 'int32_t' fields to 'abi_int'; this will only matter for guests with non-standard integer alignment like m68k. Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> Signed-off-by: Riku Voipio <riku.voi...@linaro.org> --- linux-user/syscall_defs.h | 16 ++--

[Qemu-devel] [PULL 05/22] linux-user: Fix socketcall() syscall support

2016-10-17 Thread riku . voipio
ted on some Qemu emulated sywstems (uer mode). Signed-off-by: Aleksandar Markovic <aleksandar.marko...@imgtec.com> Signed-off-by: Riku Voipio <riku.voi...@linaro.org> --- linux-user/strace.c | 39 --- linux-user/syscall.c | 119 --

[Qemu-devel] [PULL 09/22] linux-user: add kcmp() syscall

2016-10-17 Thread riku . voipio
From: Laurent Vivier <laur...@vivier.eu> Signed-off-by: Laurent Vivier <laur...@vivier.eu> Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> Signed-off-by: Riku Voipio <riku.voi...@linaro.org> --- linux-user/syscall.c | 10 ++ 1 file changed, 10 insertions(+)

[Qemu-devel] [PULL 04/22] linux-user: Fix msgrcv() and msgsnd() syscalls support

2016-10-17 Thread riku . voipio
fixes this by extending the conversion table to include ENOMSG. Also, LTP test msgrcv04 will be fixed for some platforms. Signed-off-by: Aleksandar Markovic <aleksandar.marko...@imgtec.com> Reviewed-by: Laurent Vivier <laur...@vivier.eu> Signed-off-by: Riku Voipio <riku.voi...@linaro

[Qemu-devel] [PULL 06/22] linux-user: Fix syslog() syscall support

2016-10-17 Thread riku . voipio
_NR_syslog" is also proprerly inserted when needed. Support for Qemu's "-strace" switch for syslog() syscall is included too. LTP tests syslog11 and syslog12 pass with this patch (while fail without it), on any platform. Signed-off-by: Aleksandar Markovic <aleksandar.marko...@i

[Qemu-devel] [PULL 07/22] linux-user: Remove a duplicate item from strace.list

2016-10-17 Thread riku . voipio
sandar Markovic <aleksandar.marko...@imgtec.com> Signed-off-by: Riku Voipio <riku.voi...@linaro.org> --- linux-user/strace.list | 3 --- 1 file changed, 3 deletions(-) diff --git a/linux-user/strace.list b/linux-user/strace.list index 2c7ad2b..4bbe0d3 100644 --- a/linux-user/strace.lis

[Qemu-devel] [PULL 11/22] linux-user: Don't use alloca() for epoll_wait's epoll event array

2016-10-17 Thread riku . voipio
Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> Signed-off-by: Riku Voipio <riku.voi...@linaro.org> --- linux-user/syscall.c | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index d66efa1..4e557a6

[Qemu-devel] [PULL 00/22] linux-user changes

2016-10-17 Thread riku . voipio
From: Riku Voipio <riku.voi...@linaro.org> The following changes since commit 7bf59dfec4234e75e31b3f397374cb5bab1a5b2c: Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-2.8-20161017' into staging (2016-10-17 12:59:54 +0100) are available in the git repository at:

[Qemu-devel] [PULL 01/22] linux-user: Add support for adjtimex() syscall

2016-10-17 Thread riku . voipio
xes failures of LTP tests adjtimex01 and adjtimex02, if executed in Qemu user mode. Signed-off-by: Aleksandar Rikalo <aleksandar.rik...@imgtec.com> Signed-off-by: Aleksandar Markovic <aleksandar.marko...@imgtec.com> Signed-off-by: Riku Voipio <riku.voi...@linaro.org> --- linux-user/str

[Qemu-devel] [PULL 02/22] linux-user: Add support for ustat() syscall

2016-10-17 Thread riku . voipio
does not change it. This patch also fixes failures of LTP tests ustat01, and ustat02, if executed on Qemu-emulated systems. Signed-off-by: Aleksandar Markovic <aleksandar.marko...@imgtec.com> Signed-off-by: Riku Voipio <riku.voi...@linaro.org> --- linux-user/syscall.c | 23 +++

[Qemu-devel] [PULL 08/22] linux-user: sparc64: Use correct target SHMLBA in shmat()

2016-10-17 Thread riku . voipio
bs.org/patch/646980/ http://patchwork.ozlabs.org/patch/673339/ Add the accidentally-dropped code. Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> Signed-off-by: Riku Voipio <riku.voi...@linaro.org> --- linux-user/sparc64/target_syscall.h | 7 +++ 1 file changed, 7 inserti

[Qemu-devel] [PULL 03/22] linux-user: Fix mq_open() syscall support

2016-10-17 Thread riku . voipio
From: Aleksandar Markovic <aleksandar.marko...@imgtec.com> Conversion of file creation flags (O_CREAT, ...) from target to host was missing. Also, this patch implements better error handling. Signed-off-by: Aleksandar Markovic <aleksandar.marko...@imgtec.com> Signed-off-by:

Re: [Qemu-devel] [PATCH v3 0/2] linux-user: preadv and pwritev emulation support

2016-10-17 Thread Riku Voipio
On Tue, Oct 11, 2016 at 11:52:45AM +0200, Dejan Jovicevic wrote: > v2 -> v3: > - Changed from safe_syscall4() to safe_syscall5() to rightly fit the > kernel implementation of preadv() and pwritev(). > - Modified commit message. > > v1 -> v2: > - Being that both of these system

Re: [Qemu-devel] [PATCH v2 0/5] linux-user: Several Mips-related patches

2016-10-17 Thread Riku Voipio
On Wed, Oct 12, 2016 at 02:30:20PM +0200, Aleksandar Markovic wrote: > From: Aleksandar Markovic > > v2 -> v3: > > - Updated commit message for patch 5. > > v1 -> v2: > > - Added patches 1 and 2. > - Omitted patch on sysfs(); this patch will be

Re: [Qemu-devel] [PATCH v7 03/10] linux-user: Add support for syncfs() syscall

2016-10-07 Thread Riku Voipio
On Thu, Sep 22, 2016 at 06:56:52PM +0200, Aleksandar Markovic wrote: > From: Aleksandar Markovic > > This patch implements syncfs() syscall support. The implementation > consists of a straightforward invocation of host's syncfs() only. > > Signed-off-by:

Re: [Qemu-devel] [PATCH v7 02/10] linux-user: Add support for clock_adjtime() syscall

2016-10-07 Thread Riku Voipio
On Thu, Sep 22, 2016 at 06:56:51PM +0200, Aleksandar Markovic wrote: > From: Aleksandar Markovic > > This patch implements Qemu user mode clock_adjtime() syscall support. > > The implementation is based on invocation of host's clock_adjtime(), and is > very

Re: [Qemu-devel] [PATCH] linux-user: use libc wrapper instead of direct mremap syscall

2016-10-07 Thread Riku Voipio
On Fri, Sep 30, 2016 at 07:39:27PM -0400, Felix Janda wrote: > This commit essentially reverts commit > 3af72a4d98dca033492102603734cbc63cd2694a, which has replaced > five-argument calls to mremap() by direct mremap syscalls for > compatibility with glibc older than version 2.4. > > The direct

Re: [Qemu-devel] [PATCH] linux-user: use libc wrapper instead of direct mremap syscall

2016-10-07 Thread Riku Voipio
On Fri, Sep 30, 2016 at 07:35:45PM -0700, Peter Maydell wrote: > On 30 September 2016 at 16:39, Felix Janda wrote: > > This commit essentially reverts commit > > 3af72a4d98dca033492102603734cbc63cd2694a, which has replaced > > five-argument calls to mremap() by direct

Re: [Qemu-devel] [PATCH] linux-user: Fix definition of target_sigevent for 32-bit guests

2016-10-07 Thread Riku Voipio
On Tue, Oct 04, 2016 at 02:08:24PM +0100, Peter Maydell wrote: > Ping ? Applied, thanks. > thanks > -- PMM > > On 2 September 2016 at 18:40, Peter Maydell wrote: > > The sigevent structure includes a union with some fields which > > are pointers. For the QEMU

Re: [Qemu-devel] [PATCH 1/3] linux-user: detect pwritev support on configure

2016-10-07 Thread Riku Voipio
On Thu, Oct 06, 2016 at 03:59:29PM +0200, Dejan Jovicevic wrote: > Modified the configure file so that, during configuration, a check > is performed to determine if the system call pwritev is supported > by the host. The check for preadv support already exists. Since preadv/pwritev

Re: [Qemu-devel] [PATCH] linux-user: sparc64: Use correct target SHMLBA in shmat()

2016-10-05 Thread Riku Voipio
On Tue, Oct 04, 2016 at 06:13:47PM +0100, Peter Maydell wrote: > On 4 October 2016 at 18:02, Laurent Vivier wrote: > > > > > > Le 04/10/2016 à 15:13, Peter Maydell a écrit : > >> In commit 40df8c0c0722 support was added for target-specific > > > > I don't have commit

Re: [Qemu-devel] [PATCH 2/2] linux-user: Don't use alloca() for epoll_wait's epoll event array

2016-10-05 Thread Riku Voipio
On Tue, Oct 04, 2016 at 02:09:33PM +0100, Peter Maydell wrote: > Ping? It looks like patch 1/2 of this series got into the > recent linux-user pullreq, but this one (2/2) didn't. Do > you want a resend as a standalone patch? No need, I've pulled it from patchwork, for some reason this didn't get

Re: [Qemu-devel] proposal: drop linux-user unicore32 support from QEMU

2016-09-28 Thread Riku Voipio
> > The problem we see is that the system call numbers in qemus > > unicore32/syscall_nr.h dont match what is linux mainline kernel. From the > > toolchain linked, you seem to have kernel headers and syscall numbers > > based on a custom 2.6.32 fork. If one builds unicore32 binaries based on > >

[Qemu-devel] [PATCH] checkpatch.pl: disable arch-specific test for syscall tests

2016-09-27 Thread riku . voipio
From: Riku Voipio <riku.voi...@linaro.org> Linux-user and bsd-user code need ifdef guards for new system calls that aren't implemented on all host/target combinations. Allow ifdefs for system calls when defined as __NR_foo. Signed-off-by: Riku Voipio <riku.voi...@linaro.org>

Re: [Qemu-devel] [PATCH] checkpatch.pl: disable arch-specific test for linux-user

2016-09-27 Thread Riku Voipio
On 27 September 2016 at 14:58, Paolo Bonzini <pbonz...@redhat.com> wrote: > > > On 26/09/2016 21:58, riku.voi...@linaro.org wrote: >> From: Riku Voipio <riku.voi...@linaro.org> >> >> Linux-user and bsd-user code needs lots of arch-specific ifdefs, >

Re: [Qemu-devel] [PATCH] checkpatch.pl: disable arch-specific test for linux-user

2016-09-26 Thread Riku Voipio
On 27 September 2016 at 00:08, Peter Maydell <peter.mayd...@linaro.org> wrote: > On 26 September 2016 at 12:58, <riku.voi...@linaro.org> wrote: >> From: Riku Voipio <riku.voi...@linaro.org> >> >> Linux-user and bsd-user code needs lots of arch-spe

[Qemu-devel] [PATCH] checkpatch.pl: disable arch-specific test for linux-user

2016-09-26 Thread riku . voipio
From: Riku Voipio <riku.voi...@linaro.org> Linux-user and bsd-user code needs lots of arch-specific ifdefs, so disable the warning. Signed-off-by: Riku Voipio <riku.voi...@linaro.org> --- scripts/checkpatch.pl | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --g

Re: [Qemu-devel] [PATCH v7 00/10] linux-user: Fix assorted Qemu user mode issues

2016-09-24 Thread Riku Voipio
On Thu, Sep 22, 2016 at 06:56:49PM +0200, Aleksandar Markovic wrote: > This series fixes certain Qemu user mode issues. The fixes mainly originate > from observation of LTP tests failures for execution in Qemu user mode on > various platforms. The series also contains a cleanup patch. Thanks, all

Re: [Qemu-devel] [PATCH v7 0/7] linux-user: Fix miscellaneous Mips-specific issues

2016-09-24 Thread Riku Voipio
On Sat, Sep 24, 2016 at 10:05:28AM +, Riku Voipio wrote: > On Thu, Sep 22, 2016 at 07:24:36AM +0100, Leon Alrae wrote: > > > > Applied to target-mips queue, thanks. > > > > That's a bit unorthodox way but you have my acked-by then.. > > > Since the

Re: [Qemu-devel] [PATCH v7 0/7] linux-user: Fix miscellaneous Mips-specific issues

2016-09-24 Thread Riku Voipio
On Thu, Sep 22, 2016 at 07:24:36AM +0100, Leon Alrae wrote: > > > Applied to target-mips queue, thanks. > > That's a bit unorthodox way but you have my acked-by then.. > Since these are mips-specific fixes I assumed it doesn't really matter > whether it goes via your or my tree (I picked up a

Re: [Qemu-devel] proposal: drop linux-user unicore32 support from QEMU

2016-09-23 Thread Riku Voipio
On Thu, Sep 22, 2016 at 11:09:55PM +0800, MPRC wrote: > Hi, I'm fixing the syscall problem for linux-user/unicore32 in qemu. > > I write a "hello world" program to test linux-user/unicore32 in qemu 2.7 with > toolchain of uc4-1.0.5(you can download it through >

[Qemu-devel] [PULL 26/26] linux-user: fix TARGET_NR_select

2016-09-22 Thread riku . voipio
dell <peter.mayd...@linaro.org> Signed-off-by: Laurent Vivier <laur...@vivier.eu> Signed-off-by: Riku Voipio <riku.voi...@linaro.org> --- linux-user/arm/target_syscall.h| 1 + linux-user/i386/target_syscall.h | 1 + linux-user/m68k/target_syscall.h | 2

[Qemu-devel] [PULL 25/26] linux-user: Fix incorrect offset of tuc_stack in ARM do_sigframe_return_v2

2016-09-22 Thread riku . voipio
t from do_sigreturn_v2 and do_rt_sigreturn_v2. Suggested-by: Peter Maydell <peter.mayd...@linaro.org> Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> Signed-off-by: Timothy Edward Baldwin <t.e.baldwi...@members.leeds.ac.uk> Signed-off-by: Riku Voipio <riku.voi...@linaro.or

[Qemu-devel] [PULL 22/26] linux-user: Implement force_sigsegv() via force_sig()

2016-09-22 Thread riku . voipio
<peter.mayd...@linaro.org> Signed-off-by: Riku Voipio <riku.voi...@linaro.org> --- linux-user/signal.c | 17 ++--- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/linux-user/signal.c b/linux-user/signal.c index 60fda18..900ee35 100644 --- a/linux-user/signal.c +

[Qemu-devel] [PULL 23/26] linux-user: Remove unnecessary nptl_flags variable from do_fork()

2016-09-22 Thread riku . voipio
unnecessary variable. Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> Signed-off-by: Riku Voipio <riku.voi...@linaro.org> --- linux-user/syscall.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 27a

[Qemu-devel] [PULL 24/26] linux-user: Sanity check clone flags

2016-09-22 Thread riku . voipio
ving bizarrely when we let the clone succeed but didn't provide the semantics requested by the flags. Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> Signed-off-by: Riku Voipio <riku.voi...@linaro.org> --- linux-user/syscall.c | 66 +

[Qemu-devel] [PULL 18/26] linux-user: Pass si_type information to queue_signal() explicitly

2016-09-22 Thread riku . voipio
. [RV adjusted to apply] Reviewed-by: Richard Henderson <r...@twiddle.net> Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> Signed-off-by: Riku Voipio <riku.voi...@linaro.org> --- linux-user/main.c| 124 +-- linux-user/qemu.h

[Qemu-devel] [PULL 14/26] linux-user: Use glib malloc functions in load_symbols()

2016-09-22 Thread riku . voipio
inaro.org> Signed-off-by: Riku Voipio <riku.voi...@linaro.org> --- linux-user/elfload.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/linux-user/elfload.c b/linux-user/elfload.c index 0d07b85..3d751f8 100644 --- a/linux-user/elfload.c +++ b/linux-user/elf

[Qemu-devel] [PULL 21/26] linux-user: SIGSEGV from sigreturn need not be fatal

2016-09-22 Thread riku . voipio
ndler is invoked. Reviewed-by: Richard Henderson <r...@twiddle.net> Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> Signed-off-by: Riku Voipio <riku.voi...@linaro.org> --- linux-user/signal.c | 81 +++-- 1 file changed, 54 insertio

[Qemu-devel] [PULL 19/26] linux-user: SIGSEGV on signal entry need not be fatal

2016-09-22 Thread riku . voipio
nction of that name: make sure that we don't try to re-take a failed SIGSEGV, and force a synchronous signal. Reviewed-by: Richard Henderson <r...@twiddle.net> Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> Signed-off-by: Riku Voipio <riku.voi...@linaro.org> ---

[Qemu-devel] [PULL 12/26] linux-user: Fix error handling in flatload.c target_pread()

2016-09-22 Thread riku . voipio
noted by Coverity). Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> Signed-off-by: Riku Voipio <riku.voi...@linaro.org> --- linux-user/flatload.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/linux-user/flatload.c b/linux-user/flatload.c index 42d1079..a35a560 10064

[Qemu-devel] [PULL 13/26] linux-user: Check dump_write() return in elf_core_dump()

2016-09-22 Thread riku . voipio
g> Signed-off-by: Riku Voipio <riku.voi...@linaro.org> --- linux-user/elfload.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/linux-user/elfload.c b/linux-user/elfload.c index e9a3882..0d07b85 100644 --- a/linux-user/elfload.c +++ b/linux-user/elfload.c @@ -3050,7 +30

[Qemu-devel] [PULL 20/26] linux-user: ARM: Give SIGSEGV if signal frame setup fails

2016-09-22 Thread riku . voipio
son <r...@twiddle.net> Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> Signed-off-by: Riku Voipio <riku.voi...@linaro.org> --- linux-user/signal.c | 23 +-- 1 file changed, 17 insertions(+), 6 deletions(-) diff --git a/linux-user/signal.c b/linux-use

[Qemu-devel] [PULL 07/26] linux-user: Range check the nfds argument to ppoll syscall

2016-09-22 Thread riku . voipio
ed-off-by: Peter Maydell <peter.mayd...@linaro.org> Signed-off-by: Riku Voipio <riku.voi...@linaro.org> --- linux-user/syscall.c | 5 + 1 file changed, 5 insertions(+) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index eecccbb..7a50a57 100644 --- a/linux-user/syscall.

[Qemu-devel] [PULL 16/26] linux-user: ppc64: set MSR_CM bit for BookE 2.06 MMU

2016-09-22 Thread riku . voipio
ix it by setting the MSR_CM bit for this MMU model. Signed-off-by: Michael Walle <mich...@walle.cc> Reviewed-by: Alexander Graf <ag...@suse.de> Signed-off-by: Riku Voipio <riku.voi...@linaro.org> --- linux-user/main.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff

[Qemu-devel] [PULL 10/26] linux-user: Check lock_user() return value for NULL

2016-09-22 Thread riku . voipio
From: Peter Maydell <peter.mayd...@linaro.org> lock_user() can return NULL, which typically means the syscall should fail with EFAULT. Add checks in various places where Coverity spotted that we were missing them. Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> Signed-off-by:

[Qemu-devel] [PULL 17/26] linux-user: Recheck for pending synchronous signals too

2016-09-22 Thread riku . voipio
those are in fact the only kind of new signal that the signal frame setup process might produce. Reviewed-by: Richard Henderson <r...@twiddle.net> Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> Signed-off-by: Riku Voipio <riku.voi...@linaro.org> --- linux-user/signal.c | 7 ++

[Qemu-devel] [PULL 06/26] linux-user: Check for bad event numbers in epoll_wait

2016-09-22 Thread riku . voipio
lowing values to the lock_user() size calculation Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> Signed-off-by: Riku Voipio <riku.voi...@linaro.org> --- linux-user/syscall.c | 5 + linux-user/syscall_defs.h | 3 +++ 2 files changed, 8 insertions(+) diff --git a/linu

[Qemu-devel] [PULL 09/26] linux-user: Pass missing MAP_ANONYMOUS to target_mmap() call

2016-09-22 Thread riku . voipio
estion is for handling ancient SVr4 iBCS2 binaries. Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> Signed-off-by: Riku Voipio <riku.voi...@linaro.org> --- linux-user/elfload.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/elfload.c b/linux-user/elfload.c inde

[Qemu-devel] [PULL 01/26] linux-user: Fix handling of iovec counts

2016-09-22 Thread riku . voipio
From: Peter Maydell <peter.mayd...@linaro.org> In the kernel the length of an iovec is generally handled as an unsigned long, not an integer; fix the parameter to lock_iovec() accordingly. Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> Signed-off-by: Riku Voipio <riku.vo

[Qemu-devel] [PULL 02/26] linux-user: Fix errno for sendrecvmsg with large iovec length

2016-09-22 Thread riku . voipio
Peter Maydell <peter.mayd...@linaro.org> Signed-off-by: Riku Voipio <riku.voi...@linaro.org> --- linux-user/syscall.c | 9 + 1 file changed, 9 insertions(+) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 71f40e3..9d18326 100644 --- a/linux-user/syscall.

[Qemu-devel] [PULL 05/26] linux-user: Use direct syscall for utimensat

2016-09-22 Thread riku . voipio
ecause if the direct syscall fails ENOSYS then the libc functions would also fail ENOSYS. (The system call has been in the kernel since 2.6.22 anyway.) Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> Signed-off-by: Riku Voipio <riku.voi...@linaro.org> --- linux-user/syscall.c |

[Qemu-devel] [PULL 11/26] linux-user: Fix incorrect use of host errno in do_ioctl_dm()

2016-09-22 Thread riku . voipio
From: Peter Maydell <peter.mayd...@linaro.org> do_ioctl_dm() should return target errno values, not host ones; correct an accidental use of a host errno in an error path. Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> Signed-off-by: Riku Voipio <riku.voi...@linaro.org&g

[Qemu-devel] [PULL 08/26] linux-user: report signals being taken in strace output

2016-09-22 Thread riku . voipio
eliver it a signal. Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> Signed-off-by: Riku Voipio <riku.voi...@linaro.org> --- linux-user/qemu.h | 10 + linux-user/signal.c | 4 ++ linux-user/strace.c | 106 3 files chang

[Qemu-devel] [PULL 15/26] linux-user: Use correct target SHMLBA in shmat()

2016-09-22 Thread riku . voipio
r them. Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> Signed-off-by: Riku Voipio <riku.voi...@linaro.org> --- linux-user/arm/target_syscall.h| 7 ++ linux-user/mips/target_syscall.h | 7 ++ linux-user/mips64/target_syscall.h | 7 ++ linux-user/sh4/target

[Qemu-devel] [PULL 04/26] linux-user: Implement FS_IOC_GETFLAGS and FS_IOC_SETFLAGS ioctls

2016-09-22 Thread riku . voipio
x.file-systems/80164. Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> Signed-off-by: Riku Voipio <riku.voi...@linaro.org> --- linux-user/ioctls.h | 3 +++ linux-user/syscall_defs.h | 6 ++ 2 files changed, 9 insertions(+) diff --git a/linux-user/ioctls.h b/linux-u

[Qemu-devel] [PULL 00/26] linux-user update

2016-09-22 Thread riku . voipio
From: Riku Voipio <riku.voi...@linaro.org> The following changes since commit a008535b9fa396226ff9cf78b8ac5f3584bda58e: build-sys: fix make install regression (2016-09-20 11:32:43 +0100) are available in the git repository at: git://git.linaro.org/people/riku.voipio/qemu.git tag

[Qemu-devel] [PULL 03/26] linux-user: Allow bad msg_name for recvfrom on connected socket

2016-09-22 Thread riku . voipio
urning a TARGET_EFAULT if the copy failed, but instead passing a known-bad address to the host kernel, which can then return EFAULT or ignore the value appropriately. Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> Signed-off-by: Riku Voipio <riku.voi...@linaro.org> --- linux-u

Re: [Qemu-devel] [PATCH v5 1/8] linux-user: Add support for adjtimex() syscall

2016-09-22 Thread Riku Voipio
e new platforms (aarch64, ppc64le) have opted to support it. > Thanks, > Aleksandar > > > From: Riku Voipio [riku.voi...@iki.fi] > Sent: Wednesday, September 21, 2016 9:42 PM > To: Aleksandar Markovic > Cc: qemu-devel@nongnu.org; peter.mayd

Re: [Qemu-devel] [PATCH] linux-user: fix mremap for 64bit targets on 32bit hosts

2016-09-22 Thread Riku Voipio
Hi, On Sat, Sep 17, 2016 at 09:20:14PM -0400, Felix Janda wrote: > Signed-off-by: Felix Janda Have you run the mremap tests of ltp with this on your host/guest combo? > --- > linux-user/mmap.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git

Re: [Qemu-devel] [PATCH v5 1/8] linux-user: Add support for adjtimex() syscall

2016-09-21 Thread Riku Voipio
On Wed, Sep 14, 2016 at 10:19:54PM +0200, Aleksandar Markovic wrote: > From: Aleksandar Markovic > > This patch implements Qemu user mode adjtimex() syscall support. > > Syscall adjtimex() reads and optionally sets parameters for a clock > adjustment algorithm

Re: [Qemu-devel] [PATCH] linux-user: fix TARGET_NR_select

2016-09-21 Thread Riku Voipio
On Sun, Sep 04, 2016 at 03:49:22PM +0200, Laurent Vivier wrote: > Le 11/07/2016 à 18:59, Peter Maydell a écrit : > > On 8 July 2016 at 00:17, Laurent Vivier wrote: > >> TARGET_NR_select can have three different implementations: > >> > >> 1- to always return -ENOSYS > >> > >>

Re: [Qemu-devel] [PATCH 09/26] qemu-user: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)

2016-09-21 Thread Riku Voipio
On Fri, Sep 16, 2016 at 03:56:00PM +0200, Laurent Vivier wrote: > This patch is the result of coccinelle script > scripts/coccinelle/exit.cocci > > Signed-off-by: Laurent Vivier <lviv...@redhat.com> > CC: Riku Voipio <riku.voi...@iki.fi> Acked-by: Riku Voipio <rik

Re: [Qemu-devel] [PATCH] linux-user: Fix incorrect offset of tuc_stack in ARM do_sigframe_return_v2

2016-09-21 Thread Riku Voipio
On Fri, Sep 09, 2016 at 09:02:55PM +0100, Peter Maydell wrote: > On 9 September 2016 at 19:35, Timothy E Baldwin > wrote: > > struct target_ucontext_v2 is not at the begining of the signal frame, > > therefore do_sigaltstack was being passed bogus arguments. > >

Re: [Qemu-devel] [PATCH v7 0/7] linux-user: Fix miscellaneous Mips-specific issues

2016-09-21 Thread Riku Voipio
On Wed, Sep 21, 2016 at 02:16:54PM +0100, Leon Alrae wrote: > On Mon, Sep 19, 2016 at 01:44:37PM +0200, Aleksandar Markovic wrote: > > From: Aleksandar Markovic > > > > v6->v7: > > > > - Rebased to the latest code. > > - Patch 1/1 expanded to act on alpha and

Re: [Qemu-devel] [PATCH 0/6] linux-user: Handle SEGV on signal entry/exit correctly

2016-09-21 Thread Riku Voipio
On Thu, Jul 28, 2016 at 04:44:44PM +0100, Peter Maydell wrote: > This patchset fixes bugs in our handling of failure to read > or write guest memory on entry and exit from a signal handler. > This is supposed to cause a SIGSEGV, but the guest is permitted > a chance to handle the SIGSEGV (assuming

Re: [Qemu-devel] [PATCH] linux-user: ppc64: set MSR_CM bit for BookE 2.06 MMU

2016-09-21 Thread Riku Voipio
On Wed, Sep 21, 2016 at 12:59:58PM +0200, Michael Walle wrote: > Am 2016-08-16 15:56, schrieb Michael Walle: > >Am 2016-08-16 15:41, schrieb Riku Voipio: > >>On Tue, Aug 16, 2016 at 03:32:56PM +0200, Michael Walle wrote: > >>>Am 2016-07-22 17:57, schrieb Alexander G

[Qemu-devel] [PATCH] build-sys: fix make install regression

2016-09-20 Thread riku . voipio
From: Riku Voipio <riku.voi...@linaro.org> Since bd6092e Replace qmp-commands.hx by docs/qmp-commands.txt make install fails if building out of source-tree. Cc: Marc-André Lureau <marcandre.lur...@redhat.com> Cc: Markus Armbruster <arm...@redhat.com> Signed-off-by: Rik

Re: [Qemu-devel] [PATCH for-2.7] linux-user: Fix llseek with high bit of offset_low set

2016-08-16 Thread Riku Voipio
Hi, applied to linux-user-for upstream. Riku On Mon, Aug 15, 2016 at 10:41:35PM +0900, Chanho Park wrote: > It works perfectly. > Thanks. > > Tested-by: Chanho Park > > On Fri, Aug 12, 2016 at 2:59 AM, Peter Maydell > wrote: > > The llseek

Re: [Qemu-devel] [PATCH] linux-user: ppc64: set MSR_CM bit for BookE 2.06 MMU

2016-08-16 Thread Riku Voipio
On Tue, Aug 16, 2016 at 03:32:56PM +0200, Michael Walle wrote: > Am 2016-07-22 17:57, schrieb Alexander Graf: > >On 07/22/2016 05:18 PM, Michael Walle wrote: > >>64 bit user mode doesn't work for the e5500 core because the MSR_CM bit > >>is > >>not set which enables the 64 bit mode for this MMU

[Qemu-devel] [PULL 2/5] linux-user: Fix memchr() argument in open_self_cmdline()

2016-08-04 Thread riku . voipio
could be shorter. This was spotted by Coverity (because it could result in our trying to pass a negative length argument to write()). Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> Signed-off-by: Riku Voipio <riku.voi...@linaro.org> --- linux-user/syscall.c | 2 +- 1 file ch

[Qemu-devel] [PULL 4/5] linux-user: Fix target_semid_ds structure definition

2016-08-04 Thread riku . voipio
; Signed-off-by: Riku Voipio <riku.voi...@linaro.org> --- linux-user/syscall.c | 17 ++--- linux-user/x86_64/target_structs.h | 15 +++ 2 files changed, 25 insertions(+), 7 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 5bc42

[Qemu-devel] [PULL 0/5] linux-user fixes for 2.7

2016-08-04 Thread riku . voipio
From: Riku Voipio <riku.voi...@linaro.org> The following changes since commit 09704e6ded83fa0bec14baf32f800f6512156ca0: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2016-08-04 10:24:27 +0100) are available in the git repository at: git://git.lina

[Qemu-devel] [PULL 1/5] linux-user: Use correct alignment for long long on i386 guests

2016-08-04 Thread riku . voipio
pecify the i386-specific alignment requirement. Reported-by: Icenowy Zheng <icen...@aosc.xyz> Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> Reviewed-by: Laurent Vivier <laur...@vivier.eu> Signed-off-by: Riku Voipio <riku.voi...@linaro.org> --- include/exec/user/abity

[Qemu-devel] [PULL 5/5] linux-user: Handle brk() attempts with very large sizes

2016-08-04 Thread riku . voipio
eter.mayd...@linaro.org> Signed-off-by: Riku Voipio <riku.voi...@linaro.org> --- linux-user/syscall.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index df6f2a9..833f853 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.

[Qemu-devel] [PULL 3/5] linux-user: Don't write off end of new_utsname buffer

2016-08-04 Thread riku . voipio
omment typo while we're in the neighbourhood. Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> Signed-off-by: Riku Voipio <riku.voi...@linaro.org> --- linux-user/syscall.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/linux-user/syscall.c b/linux-us

Re: [Qemu-devel] [PATCH] linux-user: Use correct alignment for long long on i386 guests

2016-08-01 Thread Riku Voipio
On Thu, Jul 28, 2016 at 12:57:59PM +0100, Peter Maydell wrote: > For i386, the ABI specifies that 'long long' (8 byte values) > need only be 4 aligned, but we were requiring them to be > 8-aligned. This meant we were laying out the target_epoll_event > structure wrongly. Add a suitable ifdef to

[Qemu-devel] [PULL v2 00/16] linux-user changes for v2.7

2016-07-19 Thread riku . voipio
From: Riku Voipio <riku.voi...@linaro.org> The following changes since commit ad31cd4c6945d7e0f0546d92d29dcd12325b4e4a: Merge remote-tracking branch 'remotes/jnsnow/tags/ide-pull-request' into staging (2016-07-19 11:47:07 +0100) are available in the git repository at: git://git.lina

[Qemu-devel] [PULL 13/16] TIOCGPTN and related terminal control ioctls were not converted to the guest ioctl format on x86_64 targets. Convert these ioctls to enable terminal functionality on x86_64 g

2016-07-19 Thread riku . voipio
From: Timothy Pearson <tpear...@raptorengineering.com> Signed-off-by: Timothy Pearson <tpear...@raptorengineering.com> Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> Signed-off-by: Riku Voipio <riku.voi...@linaro.org> --- linux-user/x86_64/termbits.h | 12 ++-

[Qemu-devel] [PULL 08/16] linux-user: Correct type for BLKSSZGET

2016-07-19 Thread riku . voipio
ecture. In particular, kpartx uses this ioctl to write to an int on the stack, which tends to result in it crashing immediately. Reported-by: Chanho Park <chanho61.p...@samsung.com> Reviewed-by: Laurent Vivier <laur...@vivier.eu> Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> Si

[Qemu-devel] [PULL 14/16] linux-user: define missing sparc syscalls

2016-07-19 Thread riku . voipio
From: Laurent Vivier <laur...@vivier.eu> NR_lookup_dcookie, NR_fadvise64, NR_fadvise64_64 Signed-off-by: Laurent Vivier <laur...@vivier.eu> Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> Signed-off-by: Riku Voipio <riku.voi...@linaro.org> --- linux-user/sparc/sysc

[Qemu-devel] [PULL 12/16] linux-user: Add some new blk ioctls

2016-07-19 Thread riku . voipio
device geometry for /dev/loop5 Unsupported ioctl: cmd=0x127c Unsupported ioctl: cmd=0x127c Unsupported ioctl: cmd=0x1277 Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> Signed-off-by: Riku Voipio <riku.voi...@linaro.org> --- linux-user/ioctls.h | 29 ++

[Qemu-devel] [PULL 05/16] linux-user: add nested netlink types

2016-07-19 Thread riku . voipio
d nested type 26 Unimplemented nested type 18 Unimplemented nested type 26 This patch implements nested types 18 (IFLA_LINKINFO) and 26 (IFLA_AF_SPEC). Signed-off-by: Laurent Vivier <laur...@vivier.eu> Signed-off-by: Riku Voipio <riku.voi...@linaro.org> ---

[Qemu-devel] [PULL 09/16] linux-user: Correct type for LOOP_GET_STATUS{, 64} ioctls

2016-07-19 Thread riku . voipio
aurent Vivier <laur...@vivier.eu> Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> Signed-off-by: Riku Voipio <riku.voi...@linaro.org> --- linux-user/ioctls.h| 4 ++-- linux-user/syscall_types.h | 9 + 2 files changed, 7 insertions(+), 6 deletions(-) diff

[Qemu-devel] [PULL 16/16] linux-user: AArch64 has sync_file_range, not sync_file_range2

2016-07-19 Thread riku . voipio
fixes the sync_file_range syscall which otherwise gets its arguments in the wrong order. Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> Signed-off-by: Riku Voipio <riku.voi...@linaro.org> --- linux-user/aarch64/syscall_nr.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/

[Qemu-devel] [PULL 11/16] linux-user: Handle short lengths in host_to_target_sockaddr()

2016-07-19 Thread riku . voipio
aulted on the bad address. Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> Signed-off-by: Riku Voipio <riku.voi...@linaro.org> --- linux-user/syscall.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c inde

[Qemu-devel] [PULL 07/16] linux-user: Add loop control ioctls

2016-07-19 Thread riku . voipio
vier.eu> Signed-off-by: Riku Voipio <riku.voi...@linaro.org> --- linux-user/ioctls.h | 4 linux-user/linux_loop.h | 11 ++- linux-user/syscall_defs.h | 4 3 files changed, 18 insertions(+), 1 deletion(-) diff --git a/linux-user/ioctls.h b/linux-user/ioctls.

[Qemu-devel] [PULL 15/16] linux-user: Fix type for SIOCATMARK ioctl

2016-07-19 Thread riku . voipio
orrect the type. Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> Signed-off-by: Riku Voipio <riku.voi...@linaro.org> --- linux-user/ioctls.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/ioctls.h b/linux-user/ioctls.h index 4b36baa..7e2c133 10064

[Qemu-devel] [PULL 04/16] linux-user: convert sockaddr_ll from host to target

2016-07-19 Thread riku . voipio
f}, 20) = 28 ... Signed-off-by: Laurent Vivier <laur...@vivier.eu> Signed-off-by: Riku Voipio <riku.voi...@linaro.org> --- linux-user/syscall.c | 5 + 1 file changed, 5 insertions(+) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index f9ce9d8..919b589 100644 ---

[Qemu-devel] [PULL 02/16] linux-user: fix netlink memory corruption

2016-07-19 Thread riku . voipio
ke "apt-get update" or "dnf update hangs". Signed-off-by: Laurent Vivier <laur...@vivier.eu> Signed-off-by: Riku Voipio <riku.voi...@linaro.org> --- linux-user/syscall.c | 32 1 file changed, 24 insertions(+), 8 deletions(-) diff --git a

[Qemu-devel] [PULL 06/16] linux-user: Check sigsetsize argument to syscalls

2016-07-19 Thread riku . voipio
means some LTP test cases which check error cases now pass.) Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> Signed-off-by: Riku Voipio <riku.voi...@linaro.org> Reviewed-by: Laurent Vivier <laur...@vivier.eu> --- linux-user/syscall.c | 47 +++

<    1   2   3   4   5   6   7   8   9   10   >