,
what features do you need in anaconda. Maybe I can add them to the
github.com/sahlberg/libiscsi.git library ?
regards
ronnie sahlberg
On Wed, Mar 7, 2012 at 7:13 AM, Mike Christie wrote:
> On 03/06/2012 01:58 PM, Mike Christie wrote:
>> On 03/06/2012 06:19 AM, Hannes Reinecke wrote:
is what it takes.
What do you want me to do ?
Tell me and I will do it.
regards
ronnie sahlberg
On Tue, Mar 6, 2012 at 9:38 PM, Michael Tokarev wrote:
> On 06.03.2012 14:07, Daniel P. Berrange wrote:
>> On Sat, Mar 03, 2012 at 03:54:19PM +0400, Michael Tokarev wrote:
>>> It look
Resending the patch with the strncmp() bug fixed.
Its been a long long week when you mess up something as simple as this.
regards
ronnie sahlberg
ptor value from the provided string and fdopen
it.
This allows to use /dev/fd/ syntax on all platforms, those that do provide
this indeface in /dev and an emulation of this for the platforms that do not
provide /dev/fd
Signed-off-by: Ronnie Sahlberg
---
qemu-config.c | 16
ptor value from the provided string and fdopen
it.
This allows to use /dev/fd/ syntax on all platforms, those that do provide
this indeface in /dev and an emulation of this for the platforms that do not
provide /dev/fd
Signed-off-by: Ronnie Sahlberg
---
qemu-config.c | 16
with /dev/fd/ then try to read the descriptorvalue and fdopen()
it.
It means that we can use -readconfig /dev/fd/ on all platforms. On those
that provide a /dev/fd we just open that file. On those that do not we emulate
it.
regards
ronnie sahlberg
/libiscsi/downloads
That resolves all issues you are concerned about ?
regards
ronnie sahlberg
On Tue, Feb 14, 2012 at 12:24 AM, Daniel P. Berrange
wrote:
> I was investigating how to build latest QEMU with the iSCSI block driver
> enabled. I saw that configure wanted a libiscsi.so, so I ins
Signed-off-by: Ronnie Sahlberg
---
configure |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/configure b/configure
index fb0e18e..294c0c1 100755
--- a/configure
+++ b/configure
@@ -2503,9 +2503,9 @@ if test "$libiscsi" != "no" ; then
#inc
Please find a patch that changes the name of the iscsi library from libiscsi to
libiscsiclient
While libiscsi is a very nice name that works on all platforms, including
win32, it clashes with a linux library.
regards
ronnie sahlberg
n, dataout, response/sense)
scsi *
}
if your transport also supports multiple datain/out blobs for a single
task, in order to reassemble the data we would also need a
offset/length for each datain/out blob.
regards
ronnie sahlberg
On Tue, Feb 28, 2012 at 8:59 PM, Stefan Hajnoczi wrote:
> Wi
Ok so what about this
You use a filename starting with "/proc/self/fd/" and you dont have a
proc filesystem mounted? you are on your own!
regards
ronnie sahlberg
On Thu, Jan 26, 2012 at 8:27 PM, Kevin Wolf wrote:
> Am 26.01.2012 10:18, schrieb ronnie sahlberg:
>> Kevin
oc/self/fd/" as a prefix for normal
files is very small.
Small enough it will be justifiable to say "do that and you are on your own". ?
regards
ronnie sahlberg
On Thu, Jan 26, 2012 at 8:08 PM, Kevin Wolf wrote:
> Am 25.01.2012 16:57, schrieb Eric Blake:
>> On 01/24/201
h writeable/burnable media for about 6 months and no one
noticed, so maybe not too many people use such features :-(
regards
ronnie sahlberg
On Thu, Jan 26, 2012 at 7:09 PM, Paolo Bonzini wrote:
> On 01/25/2012 09:13 PM, Artyom Tarasenko wrote:
>>
>> On 1/25/12, Paolo Bonzini
ned-off-by: Ronnie Sahlberg
---
block/iscsi.c | 139 +++
qemu-config.c | 27 +++
qemu-doc.texi | 54 +-
qemu-options.hx | 16 +--
vl.c|8 +++
5 files changed, 229 insertions(+), 15 deletion
first try to use a configuration
section that matches the target name.
If no such block is found, it will fall-back to try the default [iscsi] section
instead.
regards
ronnie sahlberg
Update the readconfig filename parsing to allow specifying an existing,
inherited, filedescriptor as 'fd:'
This is useful when you want to pass potentially sensitive onfiguration data to
qemu without having it hit the filesystem/stable-storage
Signed-off-by: Ronnie Sahlberg
---
qem
g possibly sensitive such, into qemu without this data hitting
the filesystem or a disk.
regards
ronnie sahlberg
Fair enough.
I will send a separate tiny patch to add 'fd:' support to specify
to qemu to -readconfig from a preexisting filedescriptor.
Other protocols like 'exec:' can easily be added later as needed.
regards
ronnie sahlberg
On Thu, Jan 26, 2012 at 2:57 AM, Eric Blak
On Tue, Jan 24, 2012 at 5:07 AM, Eric Blake wrote:
>
> Can -readconfig support reading from an inherited fd, rather than only
> taking a file name that qemu has to open()?
>
...
>
> Can you give an actual command line that uses -readconfig, as part of
> your example?
>
Thanks for the review Eric.
different targets, you can also configure this on a per
target basis by using a group name:
[iscsi "iqn.target.name"]
...
Signed-off-by: Ronnie Sahlberg
---
block/iscsi.c | 139 +++
qemu-config.c | 27 +++
qem
n
instead.
regards
ronnie sahlberg
On Thu, Jan 19, 2012 at 11:17 PM, Kevin Wolf wrote:
> Am 18.12.2011 05:48, schrieb Ronnie Sahlberg:
>> This patch adds configuration variables for iSCSI to set
>> initiator-name to use when logging in to the target,
>> which type of header-digest to negotiate with the targe
/* stage one, called before -S monitor is invoked */
.open_stage_2() /* called after -S finishes and when it starts to boot
the guest CPU */
?
regards
ronnie sahlberg
On Fri, Dec 23, 2011 at 8:08 PM, Paolo Bonzini wrote:
> On 12/22/2011 09:51 PM, ronnie sahlberg wrote:
>>
>&g
Why not just buy a non-OEM version ?
They are surely not tied to a specific piece of hardware and its
licence should allow to run on "arbitrary PC HW you happen to want to
install/run it on once activated"
On Fri, Dec 23, 2011 at 5:11 PM, wrote:
>
>
>>"My patch" does not produce any SLIC at a
file for users that run qemu
directly from the command line and are not using -S.
comments ?
regards
ronnie sahlberg
On Mon, Dec 19, 2011 at 12:48 AM, Paolo Bonzini wrote:
> On 12/18/2011 05:48 AM, Ronnie Sahlberg wrote:
>>
>> This patch adds configuration variables for iSCSI t
-doc
Signed-off-by: Ronnie Sahlberg
---
block/iscsi.c | 114 ++-
qemu-config.c | 27 +
qemu-doc.texi | 28 +-
qemu-options.hx | 16 ++--
vl.c|8
5 files changed, 186 insertions(+), 7
List,
Please find attached a patch that adds configuration variables for iSCSI to
set CHAP username/password, header-digest settings and the iqn to use when
logging in to the target.
The patch is updated to produce an error if the username is set but no password
was given.
regards
ronnie
-doc
Signed-off-by: Ronnie Sahlberg
---
block/iscsi.c | 107 +-
qemu-config.c | 27 ++
qemu-doc.texi | 28 ++-
qemu-options.hx | 16 ++--
vl.c|8
5 files changed, 179 insertions(+), 7
setting to negotiate
* chap username
* chap password
Documentation for both manpage and qemu-doc are also updated
regards
ronnie sahlberg
Hi,
On Sat, Nov 12, 2011 at 10:11 AM, Andreas Färber wrote:
> Hi,
>
> Am 11.11.2011 22:46, schrieb Ronnie Sahlberg:
>> Add a new section about using iSCSI LUNs with qemu
>> and provide a short example on how to set up a target and access it
>> using the built-in in
Add a new section about using iSCSI LUNs with qemu
and provide a short example on how to set up a target and access it
using the built-in initiator
Signed-off-by: Ronnie Sahlberg
---
qemu-doc.texi | 56
1 files changed, 56 insertions
List,
Please find an updated patch to add documentation for iSCSI and a simple
example how to set up a target to use with qemu.
It addresses the issues rised by the review of the first patch.
regards
ronnie sahlberg
Add a new section about using iSCSI LUNs with qemu
and provide a short example on how to set up a target and access it
using the built-in initiator
Signed-off-by: Ronnie Sahlberg
---
qemu-doc.texi | 53 +
1 files changed, 53 insertions(+), 0
emove that part of the patch if you think this does not belong in
the qemu docs.
regards
ronnie sahlberg
s on how to set it up on
the server side as well.
A section in 3.6 for iscsi could for example show how to create an
image and export via STGT so that QEMU can access it as an iscsi lun.
regards
ronnie sahlberg
On Fri, Oct 28, 2011 at 8:32 PM, Kevin Wolf wrote:
> Am 28.10.2011 11:13, sch
Signed-off-by: Ronnie Sahlberg
---
qemu-options.hx | 27 +++
1 files changed, 27 insertions(+), 0 deletions(-)
diff --git a/qemu-options.hx b/qemu-options.hx
index c55080c..38d0f57 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -1778,6 +1778,33 @@ Example for
Signed-off-by: Ronnie Sahlberg
---
qemu-options.hx |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/qemu-options.hx b/qemu-options.hx
index bf2ebb3..c55080c 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -1761,10 +1761,10 @@ compiled and linked against libiscsi
These patches
1, fixes a typo in a previous patch NDB -> NBD
2, adds description of sheepdog URL syntax to the manpage
This patch adds a short description of how to specify a NBD device
to QEMU.
Syntax for both TCP and Unix Domain Sockets are provided as well
as examples.
Signed-off-by: Ronnie Sahlberg
---
qemu-options.hx | 21 +
1 files changed, 21 insertions(+), 0 deletions(-)
diff
Please find a patch to add a description of the NBD URL to the manpage.
This describes both TCP and domain socket syntax.
(I could not actually test the domain syntax case since my nbd-server
crashes:-( )
regards
ronnie sahlberg
Signed-off-by: Ronnie Sahlberg
---
qemu-options.hx | 42 ++
1 files changed, 42 insertions(+), 0 deletions(-)
diff --git a/qemu-options.hx b/qemu-options.hx
index 5d2a776..7c434f8 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -148,6 +148,9
List
Following patch adds a new section to the manpage to describe the special URL
syntax used for various block backends.
It adds a subsection with examples on the newly added iSCSI backend.
Perhaps all other backeds can be added with examples to this section as well?
In which case I add patch
Hi,
On Tue, Oct 25, 2011 at 7:17 PM, Kevin Wolf wrote:
> Am 25.10.2011 10:04, schrieb ronnie sahlberg:
>>> iscsi_destroy_url() is only ever called here. Do we leak it in the normal
>>> path?
>>
>> It didnt leak but the the label was confusing. I have changed
t; path?
It didnt leak but the the label was confusing. I have changed it from
"failed" to "finished" since this part
is executed for both normal and failures.
Thanks
Ronnie Sahlberg
From f5fc5880a3071188dbfec903bc1ea1247a1e375c Mon Sep 17 00:00:00 2001
From: Ronnie Sahlberg
http://wiki.qemu.org/Main_Page
Someone may want to have a look over the website, the links in the
"Contribute" section in the column on the left.
All pages seem to primarily discuss the quality of Pandora jewelry and
how beneficial it would be to purchase such.
sahlberg
On Mon, Oct 10, 2011 at 7:46 AM, ronnie sahlberg
wrote:
> ping?
>
>
> On Thu, Sep 29, 2011 at 4:54 PM, Stefan Hajnoczi
> wrote:
>> On Wed, Sep 21, 2011 at 07:37:55PM +1000, Ronnie Sahlberg wrote:
>>> This provides built-in support for iSCSI to QEMU.
>&
ping?
On Thu, Sep 29, 2011 at 4:54 PM, Stefan Hajnoczi
wrote:
> On Wed, Sep 21, 2011 at 07:37:55PM +1000, Ronnie Sahlberg wrote:
>> This provides built-in support for iSCSI to QEMU.
>> This has the advantage that the iSCSI devices need not be made visible to
>> the host, w
List,
What remains before this patch can be accepted?
Previous patch received good feedback and severa people indicated that
they would find the feature useful for several use cases.
regards
ronnie sahlberg
On Wed, Sep 21, 2011 at 7:52 PM, ronnie sahlberg
wrote:
> On Wed, Sep 21, 2011 at 7
On Wed, Sep 21, 2011 at 7:45 PM, Paolo Bonzini wrote:
> On 09/21/2011 11:37 AM, Ronnie Sahlberg wrote:
>>
>> This driver interfaces with the multiplatform posix library for iscsi
>> initiator/client access to iscsi devices hosted at
>> git://github.com/sahlberg/libi
Stefan,
Thanks for your review.
I feel that iscsi would be beneficial for several usecases.
I have implemented all changes you pointed out, except two, and resent
an updated patch to the list.
Please see below.
regards
ronnie sahlberg
On Mon, Sep 12, 2011 at 7:14 PM, Stefan Hajnoczi
wrote
be set with
LIBISCSI_CHAP_PASSWORD="password" to avoid it showing up in the process list
Signed-off-by: Ronnie Sahlberg
---
Makefile.objs |1 +
block/iscsi.c | 596 +
configure | 31 +++
trace-events |7 +
4 fil
that it becomes acceptable for inclusion into QEMU.
regards
ronnie sahlberg
, so I would not really want to make too many statements in
the area other than in some tests I performed, performance was good
enough for my use.
I would be very happy if someone competent in tuning
qemu/scsi/open-iscsi (==that means, not me) would do a real
comparasion.
regards
ronnie sahlberg
of 512 bytes
since a read-modify-write cycle across a network would probably be
prohibitively expensive.
.bdrv_flush() I can easily add a synchronous implementation of this
unless your patch is expected to be merged
in the near future.
regards
ronnie sahlberg
On Mon, Sep 12, 2011 at 7:14 PM
password via environment variables :
LIBISCSI_CHAP_USERNAME=... LIBISCSI_CHAP_PASSWORD=...
I will document this better in the next patch.
Libiscsi only support CHAP at this stage. Which other authentication
schemes do you have in mind? Perhaps I can add them.
regards
ronnie sahlberg
t
can be used, so yes,
I could build a small simple iscsi target at some stage for qemu for
usecases where TGTD or other solutions are inconvenient.
regards
ronnie sahlberg
with
LIBISCSI_CHAP_PASSWORD="password" to avoid it showing up in the process list
Example:
./x86_64-softmmu/qemu-system-x86_64 -m 1024 -cdrom
iscsi://127.0.0.1/iqn.ronnie.test/2 --drive
file=iscsi://127.0.0.1/iqn.ronnie.test/1 -boot d -enable-kvm
Signed-off-by: Ronni
and use iSCSI resources without the need for
root privilege on the host to map the devices to local scsi devices.
Please merge this patch to master or explain how I should change the patch so
that it becomes acceptable for inclusion into QEMU.
regards
ronnie sahlberg
Sorry about the missing subject line in the previous mail
Got confused when using git-send-patch :-)
regards
ronnie sahlberg
On Sun, Jun 12, 2011 at 12:47 PM, Ronnie Sahlberg
wrote:
> Please find attached a patch to add built-in support for iSCSI into QEMU.
> Please review and/or appl
LIBISCSI_CHAP_PASSWORD="password" to avoid it showing up in the process list
Example:
./x86_64-softmmu/qemu-system-x86_64 -m 1024 -cdrom
iscsi://127.0.0.1/iqn.ronnie.test/2 --drive
file=iscsi://127.0.0.1/iqn.ronnie.test/1 -boot d -enable-kvm
Signed-off-by: Ronnie Sahlberg
---
Makefile.o
Please find attached a patch to add built-in support for iSCSI into QEMU.
Please review and/or apply this patch.
This is the latest version of this patch and I think I have addressed all
previous concerns and suggestions.
Using built-in iSCSI support has many advantages for certain use cases :
LIBISCSI_CHAP_PASSWORD="password" to avoid it showing up in the process list
Example:
-drive file=iscsi://10.1.1.1:3260/iqn.ronnie.test/1
Signed-off-by: Ronnie Sahlberg
---
Makefile.objs |1 +
block/iscsi.c | 596 +
configure
exposing these devices to
the host. Which is nice if/when you have a very large number of LUNs that are
dedicated for virtual guests.
This patch is updated to set FUA for all writes, unless any of the NOCACHE or
CACHE_WB flags are set for the device.
Please review and/or apply.
regards
ronnie
Ok, I am confused
On Fri, Apr 22, 2011 at 4:13 PM, Christoph Hellwig wrote:
> On Fri, Apr 22, 2011 at 04:08:57PM +1000, ronnie sahlberg wrote:
>> So I should set FUA when
>> BDRV_O_CACHE_WB==0 or BDRV_O_NOCACHE==1
>> right?
>
> At this point you need to set it if eit
e bit
>> BDRV_O_CACHE_WB is not set.
>
> At this point you need to check for BDRV_O_CACHE_WB and BDRV_O_NOCACHE
> as they both have writeback cache semantics. I submitted a patch to clean
> that up, but it didn't get merged yet.
>
So I should set FUA when
BDRV_O_CACHE_
List,
This updated version of the patch adds setting FUA on all writes
unless the writeback flag is set.
regards
ronnie sahlberg
On Thu, Apr 21, 2011 at 10:49 PM, Christoph Hellwig wrote:
> On Thu, Apr 21, 2011 at 09:36:12PM +1000, ronnie sahlberg wrote:
>> There are some high-volume arrays that advertise support but fail any
>> cdb with FUA, FUA_NV bits set with sense, so it needs to be made optional.
>
Stephan,
I understand.
Let me re-send a patch tomorrow that can optionally enable/force FUA
bits for write.
There are some high-volume arrays that advertise support but fail any
cdb with FUA, FUA_NV bits set with sense, so it needs to be made optional.
regards
ronnie sahlberg
On Thu, Apr 21
On Thu, Apr 21, 2011 at 8:58 PM, Stefan Hajnoczi wrote:
> On Thu, Apr 21, 2011 at 10:28 AM, ronnie sahlberg
> wrote:
>> On Thu, Apr 21, 2011 at 7:09 PM, Christoph Hellwig wrote:
>>> We only claim WCE=1 to the guest if cache=writeback or cache=none are
>>> set. So
f very little interest to me. As long as libiscsi is not
significantly worse than open-iscsi I care very little about why.
regards
ronnie sahlberg
On Thu, Apr 21, 2011 at 7:09 PM, Christoph Hellwig wrote:
>> In my patch, there are NO data integrity issues.
>> Data is sent out on the
ust involves reading data off the lun.
I think this discussion is strange. I would like discussion about the
merits of my patch and if features like built-in
iscsi support that enterprise users find useful are desireable in
QEMU. I do not find discussions about semantics of
my particular iscsi targe
n libiscsi since it does not
cache at all, ever.
regards
ronnie sahlberg
On Thu, Apr 21, 2011 at 6:50 PM, Christoph Hellwig wrote:
> On Thu, Apr 21, 2011 at 06:43:10PM +1000, Ronnie Sahlberg wrote:
>> Some basic tests thatve been performed show it to be significantly faster
>> th
LIBISCSI_CHAP_PASSWORD="password" to avoid it showing up in the process list
Example:
-drive file=iscsi://10.1.1.1:3260/iqn.ronnie.test/1
-cdrom iscsi://10.1.1.1:3260/iqn.ronnie.test/2
Signed-off-by: Ronnie Sahlberg
---
Makefile.objs |1 +
block/iscs
cache=none: 387 seconds
QEMU with cache=none,aio=native : 218 seconds
Please review and consider for inclusion.
regards
ronnie sahlberg
From: Ronnie Sahlberg
Subject: iSCSI support for QEMU
In-Reply-To:
LIBISCSI_CHAP_PASSWORD="password" to avoid it showing up in the process list
Example:
-drive file=iscsi://10.1.1.1:3260/iqn.ronnie.test/1
-cdrom iscsi://10.1.1.1:3260/iqn.ronnie.test/2
Signed-off-by: Ronnie Sahlberg
---
Makefile.objs |1 +
block/iscs
The following patch adds a new block driver to QEMU/KVM for iSCSI.
This utilizes the userspace client library for iscsi at
https://github.com/sahlberg/libiscsi and will link with this library if
available.
This allows using iSCSI resources with QEMU/KVM without making them visible to
the unde
Hi Stefan
Thanks for reviewing the patch. I have addressed all your items, some
with comments below, and will resubmit the patch shortly.
Comments below.
regards
ronnie sahlberg
On Sun, Feb 20, 2011 at 2:34 AM, Stefan Hajnoczi wrote:
> On Fri, Feb 4, 2011 at 4:37 AM, wrote:
>> Fro
- Use the name opaque instead of private_data
- Use memset() instead of bzero()
Other changes
- Use the common library function to parse the iSCSI URL
- Add support for CHAP authentication
Signed-off-by: Ronnie Sahlberg
---
Makefile.objs |1 +
block/iscsi.c |
need to expose these LUNs to the
host.
The patch has been updated based on input from review of the initial patch
as well as had CHAP authentication added.
Please review and/or apply
Ronnie Sahlberg
. :-(
sg_inq --page=0x00 /dev/sg?
will show you what inq pages your device supports.
regards
ronnie sahlberg
On Tue, Dec 21, 2010 at 2:25 PM, Benjamin Herrenschmidt
wrote:
> Hi folks !
>
> There's an odd problem I've encountered with my scsi host (basically an
> powerpc "
Thanks.
I have implemented all of your suggestions and will submit version 2
of the patch shortly.
regards
ronnie sahlberg
On Tue, Dec 14, 2010 at 7:47 AM, Blue Swirl wrote:
> On Mon, Dec 13, 2010 at 8:05 AM, Ronnie Sahlberg
> wrote:
>> This patch adds a new block driver : b
://10.1.1.1:3260/iqn.ronnie.test/2
Signed-off-by: Ronnie Sahlberg
---
Makefile.objs |2 +-
block/iscsi.c | 528 +
configure | 29 +++
3 files changed, 558 insertions(+), 1 deletions(-)
create mode 100644 block/iscsi.c
diff --git a
Please find a new block driver that IF libiscsi is present on the system
will link with this userspace client library and make qemu able to
access iscsi devices directly without exposing them to the host.
The library used is multiplatform and available from
git://github.com/sahlberg/libiscsi.git
posix systems.
>
>> + /* not much we can do here */
>
> You need to assign str = NULL here. Otherwise its value is undefined
> on GNU systems.
Good catch. Done.
>
>> + }
>> + if (iscsi->error_string != NULL) {
>> + free(iscsi->error_string);
>> + }
>> + iscsi->error_string = str;
>> + va_end(ap);
>> +}
>> +
>> +
>> +char *
>
> const char *?
Done.
> Stefan
>
Thanks
Ronnie Sahlberg
the features that
qemu/kvm needs, I think there are a lot
of work in other areas that kvm/qemu does not need/use before it can
become standalone.
regards
ronnie sahlberg
should be very easy to add once the foundation is added into qemu.
I would very much like to see bus=scsi make this layer a transparent
passthrough layer too, just like it is today for the special case
where the file specified matches "/dev/sg"
ronnie sahlberg
ver block and should be able to reach good
performance, even with one single thread.
(I assume your VirtualBOX performance problem was not the threading in
itself but that the threads use blocking calls?)
regards
ronnie sahlberg
On Mon, Nov 22, 2010 at 10:13 AM, FUJITA Tomonori
wrote:
> On Mon, 22 Nov 2010 09:17:50 +1100
> ronnie sahlberg wrote:
>
>> This patch adds support for attaching directorly to iSCSI resources,
>> both DISK/SBC and CDROM/MMC, without the need to make the devices
>> vi
nal iscsi functionality
The syntax to specify a iscsi resource is
iscsi://[:port]//
Example :
-drive file=iscsi://127.0.0.1:3260/iqn.ronnie.test/1
-cdrom iscsi://127.0.0.1:3260/iqn.ronnie.test/2
Please review and/or commit.
regards
ronnie sahlberg
201 - 289 of 289 matches
Mail list logo
