Re: [PATCH V4 4/4] bsd-user: space required after semicolon

2021-01-20 Thread shiliyang
t; > Warner  > > On Sun, Jan 17, 2021, 7:21 PM shiliyang <mailto:shiliy...@huawei.com>> wrote: > > This patch fixes error style problems found by checkpatch.pl > <http://checkpatch.pl>: > ERROR: space required after that ',

[PATCH V4 4/4] bsd-user: space required after semicolon

2021-01-17 Thread shiliyang
This patch fixes error style problems found by checkpatch.pl: ERROR: space required after that ',' Signed-off-by: Liyang Shi --- bsd-user/elfload.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/bsd-user/elfload.c b/bsd-user/elfload.c index 2842dfe56b..c89c998c22

[PATCH V4 3/4] bsd-user: do not use C99 // comments

2021-01-17 Thread shiliyang
This patch fixes error messages found by checkpatch.pl: ERROR: do not use C99 // comments Signed-off-by: Liyang Shi --- bsd-user/elfload.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/bsd-user/elfload.c b/bsd-user/elfload.c index d5cab25607..2842dfe56b 100644 --- a/bsd

[PATCH V4 1/4] bsd-user: "foo * bar" should be "foo *bar"

2021-01-17 Thread shiliyang
This patch fixes error style problems found by checkpatch.pl: ERROR: "foo ** bar" should be "foo **bar". ERROR: "foo * bar" should be "foo *bar" Signed-off-by: Liyang Shi --- bsd-user/bsdload.c | 4 ++-- bsd-user/elfload.c | 16 2 files changed, 10 insertions(+), 10 deletions(-

[PATCH V4 2/4] bsd-user: suspect code indent for conditional statements

2021-01-17 Thread shiliyang
This patch fixes error style problems found by checkpatch.pl: ERROR: suspect code indent for conditional statements Signed-off-by: Liyang Shi --- bsd-user/elfload.c | 2 +- bsd-user/mmap.c| 25 + 2 files changed, 14 insertions(+), 13 deletions(-) diff --git a/bsd-us

[PATCH V4 0/4] bsd-user: Fix some code style problems

2021-01-17 Thread shiliyang
This patch series fixes error style problems found by checkpatch.pl. V3->V4: Fix code style problems with branch bsd-user-rebase-3.1. V2->V3: Make the patch into a series. V1->V2: Add cover letter message. Fix some style error in patch file before. Liyang Shi (4): bsd-user: "foo * bar" should

Re: [PATCH V3 0/4] bsd-user: Fix some code style problems

2021-01-13 Thread shiliyang
hub.com/qemu-bsd-user/qemu-bsd-user> branch > bsd-user-rebase-3.1and we'll make sure they get via our coming pull requests.. > > Warner > > On Wed, Jan 13, 2021 at 2:31 AM shiliyang <mailto:shiliy...@huawei.com>> wrote: > > This patch series

[PATCH V3 2/4] bsd-user: suspect code indent for conditional statements

2021-01-13 Thread shiliyang
This patch fixes error style problems found by checkpatch.pl: ERROR: suspect code indent for conditional statements Signed-off-by: Liyang Shi --- bsd-user/elfload.c | 10 +- bsd-user/syscall.c | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/bsd-user/elfload.c b/b

[PATCH V3 4/4] bsd-user: do not use C99 // comments

2021-01-13 Thread shiliyang
This patch fixes error messages found by checkpatch.pl: ERROR: do not use C99 // comments Signed-off-by: Liyang Shi --- bsd-user/elfload.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/bsd-user/elfload.c b/bsd-user/elfload.c index fab9da757c..ff571088f7 100644 --- a/bs

[PATCH V3 1/4] bsd-user: "foo * bar" should be "foo *bar"

2021-01-13 Thread shiliyang
This patch fixes error style problems found by checkpatch.pl: ERROR: "foo ** bar" should be "foo **bar". ERROR: "foo * bar" should be "foo *bar" Signed-off-by: Liyang Shi --- bsd-user/bsdload.c | 6 +++--- bsd-user/elfload.c | 22 +++--- bsd-user/qemu.h| 14 +++---

[PATCH V3 3/4] bsd-user: space required after semicolon

2021-01-13 Thread shiliyang
This patch fixes error style problems found by checkpatch.pl: ERROR: space required after that ';' Signed-off-by: Liyang Shi --- bsd-user/elfload.c | 2 +- bsd-user/syscall.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/bsd-user/elfload.c b/bsd-user/elfload.c index a

[PATCH V3 0/4] bsd-user: Fix some code style problems

2021-01-13 Thread shiliyang
This patch series fixes error style problems found by checkpatch.pl. V2->V3: Make the patch into a series. V1->V2: Add cover letter message. Fix some style error in patch file before. Liyang Shi (4): bsd-user: "foo * bar" should be "foo *bar" bsd-user: suspect code indent for conditional sta

Re: [PATCH] crypto: Fix some code style problems, add spaces around operator

2021-01-12 Thread shiliyang
Kindly ping. This patch still not on the master branch. Please take it on your tree. Thanks. On 2020/12/7 18:10, Philippe Mathieu-Daudé wrote: > On 12/7/20 9:37 AM, shiliyang wrote: >> This patch fixes error style problems found by checkpatch.pl: >> ERROR: spaces requi

[PATCH] crypto: Fix some code style problems, add spaces around operator

2020-12-07 Thread shiliyang
This patch fixes error style problems found by checkpatch.pl: ERROR: spaces required around that '*' ERROR: space required after that ',' ERROR: spaces required around that '|' Signed-off-by: Liyang Shi --- crypto/aes.c | 2 +- crypto/desrfb.c | 2 +- crypto/tlscredsx509.c | 2 +-

[PATCH V2 4/4] bsd-user: do not use C99 // comments

2020-11-05 Thread shiliyang
This patch fixes error messages found by checkpatch.pl: ERROR: do not use C99 // comments Signed-off-by: Liyang Shi --- bsd-user/elfload.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/bsd-user/elfload.c b/bsd-user/elfload.c index fab9da757c..ff571088f7 100644 --- a/bs

[PATCH V2 3/4] bsd-user: space required after semicolon

2020-11-05 Thread shiliyang
This patch fixes error style problems found by checkpatch.pl: ERROR: space required after that ';' Signed-off-by: Liyang Shi --- bsd-user/elfload.c | 2 +- bsd-user/syscall.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/bsd-user/elfload.c b/bsd-user/elfload.c index a

[PATCH V2 2/4] bsd-user: suspect code indent for conditional statements

2020-11-05 Thread shiliyang
This patch fixes error style problems found by checkpatch.pl: ERROR: suspect code indent for conditional statements Signed-off-by: Liyang Shi --- bsd-user/elfload.c | 10 +- bsd-user/syscall.c | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/bsd-user/elfload.c b/b

[PATCH V2 0/4] bsd-user: Fix some code style problems

2020-11-05 Thread shiliyang
This patch series fixes error style problems found by checkpatch.pl. V1->V2: Add cover letter message. Fix some style error in patch file before. Liyang Shi (4): bsd-user: "foo * bar" should be "foo *bar" bsd-user: suspect code indent for conditional statements bsd-user: space required afte

[PATCH V2 1/4] bsd-user: "foo * bar" should be "foo *bar"

2020-11-05 Thread shiliyang
This patch fixes error style problems found by checkpatch.pl: ERROR: "foo ** bar" should be "foo **bar". ERROR: "foo * bar" should be "foo *bar" Signed-off-by: Liyang Shi --- bsd-user/bsdload.c | 6 +++--- bsd-user/elfload.c | 22 +++--- bsd-user/qemu.h| 14 +++---

Re: [PATCH 1/4] bsd-user: space required after semicolon

2020-11-04 Thread shiliyang
On 2020/11/4 19:13, Philippe Mathieu-Daudé wrote: > On 11/4/20 12:08 PM, Thomas Huth wrote: >> On 04/11/2020 11.20, shiliyang wrote: >>> This patch fixes error style problems found by checkpatch.pl: >>> ERROR: space required after that ';' >>> >&

[PATCH 3/4] bsd-user: "foo * bar" should be "foo *bar"

2020-11-04 Thread shiliyang
This patch fixes error style problems found by checkpatch.pl: ERROR: "foo ** bar" should be "foo **bar". ERROR: "foo * bar" should be "foo *bar" Signed-off-by: Liyang Shi --- bsd-user/bsdload.c | 6 +++--- bsd-user/elfload.c | 22 +++--- bsd-user/qemu.h| 14 +++---

[PATCH 2/4] bsd-user: do not use C99 // comments

2020-11-04 Thread shiliyang
This patch fixes error style problems found by checkpatch.pl: ERROR: do not use C99 // comments Signed-off-by: Liyang Shi --- bsd-user/elfload.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/bsd-user/elfload.c b/bsd-user/elfload.c index 25e625d86b..30d2d6b7a1 100644 --

[PATCH 4/4] bsd-user: suspect code indent for conditional statements

2020-11-04 Thread shiliyang
This patch fixes error style problems found by checkpatch.pl: ERROR: suspect code indent for conditional statements Signed-off-by: Liyang Shi --- bsd-user/elfload.c | 10 +- bsd-user/main.c| 4 ++-- bsd-user/syscall.c | 2 +- 3 files changed, 8 insertions(+), 8 deletions(-) diff

[PATCH 1/4] bsd-user: space required after semicolon

2020-11-04 Thread shiliyang
This patch fixes error style problems found by checkpatch.pl: ERROR: space required after that ';' Signed-off-by: Liyang Shi --- bsd-user/elfload.c | 2 +- bsd-user/syscall.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/bsd-user/elfload.c b/bsd-user/elfload.c index 9

[PATCH] crypto: Add spaces around operator

2020-11-02 Thread shiliyang
I am reading crypto related code, find some code style problems while using checkpatch.pl to check crypto folder. Fix the error style problems. Signed-off-by: Liyang Shi --- crypto/aes.c | 6 +++--- crypto/desrfb.c | 2 +- crypto/tlscredsx509.c | 2 +- 3 files changed, 5 insertio

block: Fix some code style problems, "foo* bar" should be "foo *bar"

2020-10-29 Thread shiliyang
There have some code style problems be found when read the block driver code. So I fixes some problems of this error, ERROR: "foo* bar" should be "foo *bar". Signed-off-by: Liyang Shi Reported-by: Euler Robot --- block/blkdebug.c | 2 +- block/dmg.c | 2 +- block/qcow2.c| 4 ++-- bl

[PATCH] block: Fix some code style problems, "foo* bar" should be "foo *bar"

2020-10-29 Thread shiliyang
There have some code style problems be found when read the block driver code. So I fixes some problems of this error, ERROR: "foo* bar" should be "foo *bar". Signed-off-by: Liyang Shi Reported-by: Euler Robot --- block/blkdebug.c | 2 +- block/dmg.c | 2 +- block/qcow2.c| 4 ++-- bl