Re: [RFC PATCH] vhost_net: should not use max_queue_pairs for non-mq guest

2022-03-25 Thread Si-Wei Liu
On 3/25/2022 12:59 AM, Jason Wang wrote: On Fri, Mar 25, 2022 at 3:02 PM Si-Wei Liu wrote: On 3/21/2022 8:47 PM, Jason Wang wrote: On Sat, Mar 19, 2022 at 12:14 PM Si-Wei Liu wrote: With MQ enabled vdpa device and non-MQ supporting guest e.g. booting vdpa with mq=on over OVMF of single

Re: [PATCH] vdpa: Avoid reset when stop device

2022-03-25 Thread Si-Wei Liu
On 3/25/2022 12:18 AM, Michael Qiu wrote: On 2022/3/25 14:32, Si-Wei Liu Wrote: On 3/23/2022 2:20 AM, Jason Wang wrote: Adding Eugenio,  and Ling Shan. On Wed, Mar 23, 2022 at 4:58 PM <08005...@163.com> wrote: From: Michael Qiu Currently, when VM poweroff, it will trigge

Re: [PATCH] vdpa: Avoid reset when stop device

2022-03-25 Thread Si-Wei Liu
On 3/25/2022 2:00 AM, Michael Qiu wrote: On 2022/3/25 14:32, Si-Wei Liu wrote: On 3/23/2022 2:20 AM, Jason Wang wrote: Adding Eugenio,  and Ling Shan. On Wed, Mar 23, 2022 at 4:58 PM <08005...@163.com> wrote: From: Michael Qiu Currently, when VM poweroff, it will trigger vdpa

Re: [RFC PATCH] vhost_net: should not use max_queue_pairs for non-mq guest

2022-03-25 Thread Si-Wei Liu
On 3/21/2022 8:47 PM, Jason Wang wrote: On Sat, Mar 19, 2022 at 12:14 PM Si-Wei Liu wrote: With MQ enabled vdpa device and non-MQ supporting guest e.g. booting vdpa with mq=on over OVMF of single vqp, it's easy to hit assert failure as the following: ../hw/virtio/vhost-vdpa.c:560

Re: [PATCH] vdpa: Avoid reset when stop device

2022-03-25 Thread Si-Wei Liu
On 3/23/2022 2:20 AM, Jason Wang wrote: Adding Eugenio, and Ling Shan. On Wed, Mar 23, 2022 at 4:58 PM <08005...@163.com> wrote: From: Michael Qiu Currently, when VM poweroff, it will trigger vdpa device(such as mlx bluefield2 VF) reset twice, this leads to below issue: vhost VQ 2 ring

[RFC PATCH] vhost_net: should not use max_queue_pairs for non-mq guest

2022-03-18 Thread Si-Wei Liu
q=on/ mq=on (Linux) => n->max_queue_pairs(>1) max_vqp 8 / mq=off / mq=on (Linux) => n->max_queue_pairs(=1) [*] Please see FIXME in the code for open question and discussion Signed-off-by: Si-Wei Liu --- hw/net/vhost_net.c | 13 + hw/virtio/vhost-vdpa.c | 2

Re: [PATCH V2 1/2] vhost-vdpa: skip ram device from the IOTLB mapping

2021-06-10 Thread Si-Wei Liu
-by: Jason Wang Reviewed-by: Si-Wei Liu --- hw/virtio/vhost-vdpa.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c index 01d2101d09..dd4321bac2 100644 --- a/hw/virtio/vhost-vdpa.c +++ b/hw/virtio/vhost-vdpa.c

Re: [PATCH V2 2/2] vhost-vdpa: map virtqueue notification area if possible

2021-06-10 Thread Si-Wei Liu
to eventfd based notification gracefully. Signed-off-by: Jason Wang Reviewed-by: Si-Wei Liu --- Changes since v1: - use dev->vq_index to calculate the virtqueue index - remove the unused host_notifier_set --- hw/virtio/vhost-vdpa.c | 85 ++ include/hw/vir

Re: [PATCH 2/2] vhost-vdpa: doorbell mapping support

2021-05-06 Thread Si-Wei Liu
On 5/5/2021 7:17 PM, Jason Wang wrote: 在 2021/5/1 上午6:32, Si-Wei Liu 写道: On 4/15/2021 1:04 AM, Jason Wang wrote: This patch implements the doorbell mapping support for vhost-vDPA. This is simply done by using mmap()/munmap() for the vhost-vDPA fd during device start/stop. For the device

Re: [PATCH 2/2] vhost-vdpa: doorbell mapping support

2021-04-30 Thread Si-Wei Liu
On 4/15/2021 1:04 AM, Jason Wang wrote: This patch implements the doorbell mapping support for vhost-vDPA. This is simply done by using mmap()/munmap() for the vhost-vDPA fd during device start/stop. For the device without doorbell support, we fall back to eventfd based notification

[PATCH] vhost-vdpa: negotiate VIRTIO_NET_F_STATUS with driver

2020-10-01 Thread Si-Wei Liu
Vendor driver may not support or implement config interrupt delivery for link status notifications. In this event, vendor driver is expected to NACK the feature, but guest will keep link always up. Signed-off-by: Si-Wei Liu --- net/vhost-vdpa.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [Qemu-devel] [RFC PATCH 0/2] implement the failover feature for assigned network devices

2019-05-28 Thread si-wei liu
On 4/5/2019 4:22 PM, Michael S. Tsirkin wrote: On Fri, Apr 05, 2019 at 09:56:29AM +0100, Dr. David Alan Gilbert wrote: * Jens Freimann (jfreim...@redhat.com) wrote: ping FYI: I'm also working on a few related tools to detect driver behaviour when assigning a MAC to the vf device. Code is

Re: [Qemu-devel] [PATCH 0/4] add failover feature for assigned network devices

2019-05-28 Thread si-wei liu
On 5/21/2019 11:49 AM, Jens Freimann wrote: On Tue, May 21, 2019 at 07:37:19AM -0400, Michael S. Tsirkin wrote: On Tue, May 21, 2019 at 09:21:57AM +0200, Jens Freimann wrote: On Mon, May 20, 2019 at 04:56:57PM -0600, Alex Williamson wrote: > On Fri, 17 May 2019 14:58:16 +0200 > Jens

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v3 2/5] virtio_net: Add support for "Data Path Switching" during Live Migration.

2019-01-10 Thread si-wei liu
On 01/10/2019 07:20 PM, Michael S. Tsirkin wrote: On Thu, Jan 10, 2019 at 06:09:23PM -0800, si-wei liu wrote: On 01/09/2019 07:56 AM, Michael S. Tsirkin wrote: On Mon, Jan 07, 2019 at 05:29:41PM -0500, Venu Busireddy wrote: diff --git a/hw/acpi/pcihp.c b/hw/acpi/pcihp.c index 80d42e1

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v3 0/5] Support for datapath switching during live migration

2019-01-10 Thread si-wei liu
On 01/09/2019 05:39 AM, Michael S. Tsirkin wrote: On Tue, Jan 08, 2019 at 08:55:35PM -0800, si-wei liu wrote: On 1/7/2019 6:25 PM, Michael S. Tsirkin wrote: On Mon, Jan 07, 2019 at 05:45:22PM -0800, si-wei liu wrote: On 01/07/2019 03:32 PM, Michael S. Tsirkin wrote

Re: [Qemu-devel] [PATCH v3 2/5] virtio_net: Add support for "Data Path Switching" during Live Migration.

2019-01-10 Thread si-wei liu
On 01/09/2019 07:56 AM, Michael S. Tsirkin wrote: On Mon, Jan 07, 2019 at 05:29:41PM -0500, Venu Busireddy wrote: diff --git a/hw/acpi/pcihp.c b/hw/acpi/pcihp.c index 80d42e1..2a3ffd3 100644 --- a/hw/acpi/pcihp.c +++ b/hw/acpi/pcihp.c @@ -176,6 +176,25 @@ static void

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v3 0/5] Support for datapath switching during live migration

2019-01-08 Thread si-wei liu
On 1/7/2019 6:25 PM, Michael S. Tsirkin wrote: On Mon, Jan 07, 2019 at 05:45:22PM -0800, si-wei liu wrote: On 01/07/2019 03:32 PM, Michael S. Tsirkin wrote: On Mon, Jan 07, 2019 at 05:29:39PM -0500, Venu Busireddy wrote: Implement the infrastructure to support datapath switching during

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v3 0/5] Support for datapath switching during live migration

2019-01-07 Thread si-wei liu
if management software wants to drive the SR-IOV live migration on its own. It should not conflict with the hidden device model but just offers simplicity of implementation. Si-Wei Liu (2): vfio-pci: Add FAILOVER_PRIMARY_CHANGED event to shorten downtime during failover pci: query

Re: [Qemu-devel] [PATCH v3 4/5] vfio-pci: Add FAILOVER_PRIMARY_CHANGED event to shorten downtime during failover

2019-01-07 Thread si-wei liu
On 01/07/2019 03:41 PM, Alex Williamson wrote: On Mon, 7 Jan 2019 18:22:20 -0500 "Michael S. Tsirkin" wrote: On Mon, Jan 07, 2019 at 04:17:17PM -0700, Alex Williamson wrote: On Mon, 7 Jan 2019 17:29:43 -0500 Venu Busireddy wrote: From: Si-Wei Liu When a VF is

Re: [Qemu-devel] [PATCH 3/3] vfio-pci: Add FAILOVER_PRIMARY_CHANGED event to shorten downtime during failover

2018-12-10 Thread si-wei liu
On 12/10/2018 9:31 AM, Michael S. Tsirkin wrote: On Mon, Dec 10, 2018 at 11:15:48AM -0500, Venu Busireddy wrote: From: Si-Wei Liu When a VF is hotplugged into the guest, datapath switching will be performed immediately, which is sub-optimal in terms of timing, and could end up

Re: [Qemu-devel] [PATCH 2/3] virtio_net: Add support for "Data Path Switching" during Live Migration.

2018-12-10 Thread si-wei liu
On 12/10/2018 9:41 AM, Michael S. Tsirkin wrote: On Mon, Dec 10, 2018 at 11:15:47AM -0500, Venu Busireddy wrote: Added two new events, FAILOVER_PLUG_PRIMARY and FAILOVER_UNPLUG_PRIMARY. The first is emitted when the guest negotiates the F_STANDBY feature bit. The second is emitted when the

Re: [Qemu-devel] [PATCH v3 0/3] Use of unique identifier for pairing virtio and passthrough devices...

2018-07-09 Thread si-wei liu
On 7/9/2018 6:00 AM, Roman Kagan wrote: On Tue, Jul 03, 2018 at 03:27:23PM -0700, si-wei liu wrote: On 7/3/2018 2:58 AM, Roman Kagan wrote: So how is this coordination going to work? One possibility is that the PV device emits a QMP event upon the guest driver confirming the support

Re: [Qemu-devel] [PATCH v3 0/3] Use of unique identifier for pairing virtio and passthrough devices...

2018-07-03 Thread si-wei liu
On 7/3/2018 2:58 AM, Roman Kagan wrote: On Mon, Jul 02, 2018 at 02:14:52PM -0700, si-wei liu wrote: On 7/2/2018 9:14 AM, Roman Kagan wrote: On Fri, Jun 29, 2018 at 05:19:03PM -0500, Venu Busireddy wrote: The patch set "Enable virtio_net to act as a standby for a passthru device"

Re: [Qemu-devel] [PATCH v3 0/3] Use of unique identifier for pairing virtio and passthrough devices...

2018-07-02 Thread si-wei liu
On 7/2/2018 9:14 AM, Roman Kagan wrote: On Fri, Jun 29, 2018 at 05:19:03PM -0500, Venu Busireddy wrote: The patch set "Enable virtio_net to act as a standby for a passthru device" [1] deals with live migration of guests that use passthrough devices. However, that scheme uses the MAC address

<    1   2   3