[Qemu-devel] [PATCH] mirror: prevent 'top' mode mirroring when no backing file specified on the destination

2016-12-19 Thread sochin jiang
arlier and return error in case of misoperation. Signed-off-by: sochin jiang --- block/mirror.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/block/mirror.c b/block/mirror.c index 301ba92..3476696 100644 --- a/block/mirror.c +++ b/block/mirror.c @@ -1038,6 +1038,12 @@ void mirror_s

[Qemu-devel] Question: an IO hang problem

2018-03-13 Thread sochin . jiang
Hi, guys, Recently, I encountered an IO hang problem in occasion which I cannot reproduce it now. I analyzed this problem carefully, the critical stack is as following: After reading the codes in linux-aio.c(see ioq_submit() function), I found two situations could lead us here. 1) no AIO

[Qemu-devel] [PATCH v2] throttle: fix a qemu crash problem when calling blk_delete

2017-10-23 Thread sochin jiang
blk_io_limits_disable, leaves draining operation to blk_remove_bs in case that there is no BDS inserted. Futhermore, make sure throttle timers are initialized or attached before throttle_timers_destroy is called in throttle_group_unregister_tgm. Signed-off-by: sochin jiang --- block/block-backend.c

Re: [Qemu-devel] virtio-9p: hot-plug/unplug about virtio-9p device

2018-01-10 Thread sochin . jiang
On 2018/1/8 18:10, Greg Kurz wrote: > On Tue, 19 Dec 2017 13:41:12 +0800 > sochin.jiang wrote: > >> Hi, guys. >> >> I'm looking for the hot-plug/unplug features of virtio-9p device >> recently, and found there's a lack of support. >> >> I am wondering why ? Is there a reason. Actua

[Qemu-devel] virtio-9p: hot-plug/unplug about virtio-9p device

2017-12-18 Thread sochin . jiang
Hi, guys. I'm looking for the hot-plug/unplug features of virtio-9p device recently, and found there's a lack of support. I am wondering why ? Is there a reason. Actually, I write a qmp command to support fsdev_add, then a device_add qmp will successfully add a virtio-9p

[Qemu-devel] [PATCH] virtio-blk: notify guest directly

2017-12-19 Thread sochin . jiang
From: "sochin.jiang" Till now, we've already notify guest as a batch mostly, an extra BH won't decrease guest interrupts much, but cause a significant notification loss. Generally, we could have 15% or so performance lost in single queue IO models, as I tested. Signed-off-by: sochin.jiang -

Re: [Qemu-devel] [PATCH] virtio-blk: notify guest directly

2017-12-19 Thread sochin . jiang
In fact, I firstly found a performance loss before and after commit 9ffe337 using fio tools in suse11-sp3 guest(vitio-blk), especially when testing 4k single IO models(say, write, randwrite, read and randread, with iodepth set to 1), the result is 15%-20% performance loss since commit 9ffe337,

[Qemu-devel] [PATCH] scripts: correct a spelling error

2017-12-20 Thread sochin . jiang
From: "sochin.jiang" Correct a spelling error in prompt message. Signed-off-by: sochin.jiang --- scripts/git-submodule.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/git-submodule.sh b/scripts/git-submodule.sh index bc7224a..807ca0b 100755 --- a/scripts/git-sub