[PATCH v2 1/4] target/sparc/cpu: Rename the CPU models with a "+" in their names

2024-04-19 Thread Thomas Huth
ward compatibility for the old names via some simple checks in the sparc_cpu_class_by_name() function. Reviewed-by: Mark Cave-Ayland Signed-off-by: Thomas Huth --- qom/object.c | 8 target/sparc/cpu.c | 14 -- 2 files changed, 12 insertions(+), 10 deletions(-) d

Re: [PATCH 6/6] target/s390x/cpu_models_sysemu: Drop local @err in apply_cpu_model()

2024-04-19 Thread Thomas Huth
On 19/04/2024 08.57, Zhao Liu wrote: From: Zhao Liu Use @errp to fetech error information directly and drop the local virable @err. With the typos fixed: Reviewed-by: Thomas Huth

Re: [PATCH 5/6] target/s390x/cpu_models: Make kvm_s390_apply_cpu_model() return boolean

2024-04-19 Thread Thomas Huth
-off-by: Zhao Liu --- target/s390x/cpu_models.h| 5 +++-- target/s390x/cpu_models_sysemu.c | 3 +-- target/s390x/kvm/kvm.c | 15 --- 3 files changed, 12 insertions(+), 11 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH 4/6] target/s390x/cpu_models: Drop local @err in get_max_cpu_model()

2024-04-19 Thread Thomas Huth
(errp, err); +if (!kvm_s390_get_host_cpu_model(_model, errp)) { return NULL; } } else { With the typos fixed: Reviewed-by: Thomas Huth

Re: [PATCH 3/6] target/s390x/cpu_models: Make kvm_s390_get_host_cpu_model() return boolean

2024-04-19 Thread Thomas Huth
Error **errp) { +return true; } Thomas

Re: [PATCH 2/6] target/s390x/cpu_model: Drop local @err in s390_realize_cpu_model()

2024-04-19 Thread Thomas Huth
On 19/04/2024 08.57, Zhao Liu wrote: From: Zhao Liu Use @errp to fetech error information directly and drop the local s/fetech/fetch/ virable @err. s/virable/variable/ Suggested-by: Thomas Huth Signed-off-by: Zhao Liu --- target/s390x/cpu_models.c | 4 +--- 1 file changed, 1

Re: [PATCH 1/6] target/s390x/cpu_model: Make check_compatibility() return boolean

2024-04-19 Thread Thomas Huth
On 19/04/2024 08.57, Zhao Liu wrote: From: Zhao Liu As error.h suggested, the best practice for callee is to return something to indicate success / failure. With returned boolean, there's no need to check @err. Suggested-by: Thomas Huth Signed-off-by: Zhao Liu --- target/s390x

Re: [PATCH 4/5] docs/system/target-sparc: Improve the Sparc documentation

2024-04-18 Thread Thomas Huth
On 18/04/2024 22.27, Mark Cave-Ayland wrote: On 07/03/2024 17:43, Thomas Huth wrote: Add some words about how to enable or disable boolean features, and remove the note about a Linux kernel being available on the QEMU website (they have been removed long ago already). Signed-off-by: Thomas

Re: [PATCH] vhost-user-test: no set non-blocking for cal fd less than 0.

2024-04-18 Thread Thomas Huth
; fd < 0) { +qos_printf("call fd :%d, no set non-blocking\n", fd); +break; +} /* * This is a non-blocking eventfd. * The receive function forces it to be blocking, Could someone experienced with vhost-user please review this? Thanks, Thomas

[PATCH v3 06/13] ci: move external build environment setups to CentOS Stream 9

2024-04-18 Thread Thomas Huth
-off-by: Paolo Bonzini Reviewed-by: Thomas Huth Message-ID: <20240412103708.27650-1-pbonz...@redhat.com> Reviewed-by: Daniel P. Berrangé Signed-off-by: Thomas Huth --- .../stream/{8 => 9}/build-environment.yml | 31 ++--- .../stream/{8 => 9}/x86_64/configure

[PATCH v3 05/13] .travis.yml: Update the jobs to Ubuntu 22.04

2024-04-18 Thread Thomas Huth
can drop the entries from the individual jobs and use the global setting again. Reviewed-by: Daniel P. Berrangé Signed-off-by: Thomas Huth --- .travis.yml | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/.travis.yml b/.travis.yml index 8a3ae76a7c..56a2a01e14 1006

[PATCH v3 03/13] tests/docker/dockerfiles: Run lcitool-refresh after the lcitool update

2024-04-18 Thread Thomas Huth
ation environment. Our containers are disposable though, so a venv has no benefit. Removing the 'EXTERNALLY-MANAGED' allows the historical arbitrary use of 'pip' outside a venv. lcitool just does this unconditionally given the containers are not precious." Reviewed-by: Daniel P. Berrangé Signed-off-

[PATCH v3 11/13] block/nfs: Use URI parsing code from glib

2024-04-18 Thread Thomas Huth
ce the latter rather sounds like the users were breaking a law here. Reviewed-by: Eric Blake Signed-off-by: Thomas Huth --- block/nfs.c | 110 ++-- 1 file changed, 54 insertions(+), 56 deletions(-) diff --git a/block/nfs.c b/block/nfs.c index f7

[PATCH v3 09/13] block/gluster: Use URI parsing code from glib

2024-04-18 Thread Thomas Huth
of g_uri_get_path() as input). Reviewed-by: Eric Blake Reviewed-by: Daniel P. Berrangé Signed-off-by: Thomas Huth --- block/gluster.c | 71 - 1 file changed, 35 insertions(+), 36 deletions(-) diff --git a/block/gluster.c b/block/gluster.c index cc74af06dc

[PATCH v3 08/13] Remove glib compatibility code that is not required anymore

2024-04-18 Thread Thomas Huth
Now that we bumped the minumum glib version to 2.66, we can drop the old code. Suggested-by: Paolo Bonzini Reviewed-by: Daniel P. Berrangé Signed-off-by: Thomas Huth --- qga/commands-posix-ssh.c | 8 util/error-report.c | 10 -- 2 files changed, 18 deletions(-) diff

[PATCH v3 02/13] tests/lcitool/libvirt-ci: Update to the latest master branch

2024-04-18 Thread Thomas Huth
We need the latest fixes for the lcitool to be able to properly update our CentOS docker file to CentOS Stream 9. Reviewed-by: Daniel P. Berrangé Signed-off-by: Thomas Huth --- tests/lcitool/libvirt-ci | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/lcitool/libvirt-ci

[PATCH v3 12/13] block/ssh: Use URI parsing code from glib

2024-04-18 Thread Thomas Huth
or other mistakes. Reviewed-by: Richard W.M. Jones Signed-off-by: Thomas Huth --- block/ssh.c | 75 - 1 file changed, 40 insertions(+), 35 deletions(-) diff --git a/block/ssh.c b/block/ssh.c index 2748253d4a..a88171d4b5 100644 --- a/block/ssh.c

[PATCH v3 13/13] util/uri: Remove the old URI parsing code

2024-04-18 Thread Thomas Huth
Now that we switched all consumers of the URI code to use the URI parsing functions from glib instead, we can remove our internal URI parsing code since it is not used anymore. Reviewed-by: Eric Blake Signed-off-by: Thomas Huth --- include/qemu/uri.h | 99 --- util/uri.c | 1466

[PATCH v3 04/13] tests: Update our CI to use CentOS Stream 9 instead of 8

2024-04-18 Thread Thomas Huth
-are-coming-for-centos-stream-8-and-centos-linux-7/ "After May 31, 2024, CentOS Stream 8 will be archived and no further updates will be provided." Thus upgrade our CentOS Stream container to major version 9 now. Reviewed-by: Daniel P. Berrangé Signed-off-by: Thomas Huth --- .g

[PATCH v3 10/13] block/nbd: Use URI parsing code from glib

2024-04-18 Thread Thomas Huth
. Reviewed-by: Richard W.M. Jones Reviewed-by: Eric Blake Signed-off-by: Thomas Huth --- block/nbd.c | 76 ++--- 1 file changed, 37 insertions(+), 39 deletions(-) diff --git a/block/nbd.c b/block/nbd.c index ef05f7cdfd..589d28af83 100644 --- a/block

[PATCH v3 00/13] Drop old distros, bump glib and switch to glib URI parsing code

2024-04-18 Thread Thomas Huth
r simplification - Don't allow port 0 in the URIs Paolo Bonzini (1): ci: move external build environment setups to CentOS Stream 9 Thomas Huth (12): tests: Remove Ubuntu 20.04 container tests/lcitool/libvirt-ci: Update to the latest master branch tests/docker/dockerfiles: Run lcitool-re

[PATCH v3 07/13] Bump minimum glib version to v2.66

2024-04-18 Thread Thomas Huth
which will allow further clean-ups in the following patches. Reviewed-by: Daniel P. Berrangé Signed-off-by: Thomas Huth --- meson.build | 16 +--- include/glib-compat.h| 27 ++- qga/commands-posix-ssh.c | 4 ++-- 3 files changed, 5 insertions

[PATCH v3 01/13] tests: Remove Ubuntu 20.04 container

2024-04-18 Thread Thomas Huth
Since Ubuntu 22.04 is now available since two years, we can stop actively supporting the previous LTS version of Ubuntu now. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- tests/docker/dockerfiles/ubuntu2004.docker | 157 - tests/lcitool/refresh

Re: [PATCH v2 04/13] tests: Update our CI to use CentOS Stream 9 instead of 8

2024-04-18 Thread Thomas Huth
On 17/04/2024 18.15, Daniel P. Berrangé wrote: On Fri, Apr 12, 2024 at 03:24:06PM +0200, Thomas Huth wrote: RHEL 9 (and thus also the derivatives) are available since two years now, so according to QEMU's support policy, we can drop the active support for the previous major version 8 now. Thus

Re: [PATCH v2 09/13] block/gluster: Use URI parsing code from glib

2024-04-18 Thread Thomas Huth
On 12/04/2024 16.40, Eric Blake wrote: On Fri, Apr 12, 2024 at 03:24:11PM +0200, Thomas Huth wrote: Since version 2.66, glib has useful URI parsing functions, too. Use those instead of the QEMU-internal ones to be finally able to get rid of the latter. Signed-off-by: Thomas Huth --- block

Re: Deprecation/removal of nios2 target support

2024-04-17 Thread Thomas Huth
.  But, we need to get the ball rolling somewhere. Thanks for the heads-up, Sandra! FWIW: QEMU already marked the nios2 target as deprecated, too, and plans to remove it in version 9.1 (in autumn this year). Thomas

Re: [PATCH v3 01/22] hw/i386/pc: Deprecate 2.4 to 2.7 pc-i440fx machines

2024-04-16 Thread Thomas Huth
On 16/04/2024 16.49, Philippe Mathieu-Daudé wrote: On 16/4/24 16:23, Thomas Huth wrote: On 16/04/2024 15.52, Philippe Mathieu-Daudé wrote: Similarly to the commit c7437f0ddb "docs/about: Mark the old pc-i440fx-2.0 - 2.3 machine types as deprecated", deprecate the 2.4 to 2.

Re: [PATCH v3 01/22] hw/i386/pc: Deprecate 2.4 to 2.7 pc-i440fx machines

2024-04-16 Thread Thomas Huth
On 16/04/2024 15.52, Philippe Mathieu-Daudé wrote: Similarly to the commit c7437f0ddb "docs/about: Mark the old pc-i440fx-2.0 - 2.3 machine types as deprecated", deprecate the 2.4 to 2.7 machines. Suggested-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé --- docs/about/depr

[PATCH] qemu-options: Deprecate "-runas" and introduce "-run-with user=..." instead

2024-04-15 Thread Thomas Huth
the runtime behavior. Thus let's introduce a "user=..." parameter here now and deprecate the old "-runas" option. Signed-off-by: Thomas Huth --- docs/about/deprecated.rst | 6 ++ system/vl.c | 15 +++ qemu-options.hx | 11 +

Re: [PATCH 0/5] Sparc CPU naming and help text improvements

2024-04-15 Thread Thomas Huth
On 07/03/2024 18.43, Thomas Huth wrote: The Sparc CPU naming and the corresponding help text is somewhat confusing for the users. We should avoid spaces in the Names and provide clear information to the users what can be passed to the "-cpu" option. While we're at it, also remove th

[PATCH v2 0/2] Improvements for switches in hw/cpu/Kconfig

2024-04-15 Thread Thomas Huth
-bys Thomas Huth (2): hw: Fix problem with the A*MPCORE switches in the Kconfig files hw: Add a Kconfig switch for the TYPE_CPU_CLUSTER device hw/Kconfig | 1 + hw/arm/Kconfig | 18 +++--- hw/cpu/Kconfig | 15 --- hw/cpu/meson.build | 3 ++- hw/riscv

[PATCH v2 2/2] hw: Add a Kconfig switch for the TYPE_CPU_CLUSTER device

2024-04-15 Thread Thomas Huth
The cpu-cluster device is only needed for some few arm and riscv machines. Let's avoid compiling and linking it if it is not really necessary. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- hw/arm/Kconfig | 3 +++ hw/cpu/Kconfig | 3 +++ hw/cpu/meson.build | 3

[PATCH v2 1/2] hw: Fix problem with the A*MPCORE switches in the Kconfig files

2024-04-15 Thread Thomas Huth
/ folder) and by making sure that the file hw/cpu/Kconfig is now properly included from hw/Kconfig. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- hw/Kconfig | 1 + hw/arm/Kconfig | 15 --- hw/cpu/Kconfig | 12 +--- 3 files changed, 10 insertions

Re: [PATCH v4 5/5] tests/qtest : Add testcase for DM163

2024-04-14 Thread Thomas Huth
G_FSI_APB2OPB_ASPEED') ? ['aspeed_fsi-test'] : []) + \ + (config_all_devices.has_key('CONFIG_STM32L4X5_SOC') and + config_all_devices.has_key('CONFIG_DM163')? qtests_dm163 : []) + \ With qtests_dm163 preferably replaced by ['dm163-test'] : Acked-by: Thomas Huth

[PATCH v2 05/13] .travis.yml: Update the jobs to Ubuntu 22.04

2024-04-12 Thread Thomas Huth
can drop the entries from the individual jobs and use the global setting again. Signed-off-by: Thomas Huth --- .travis.yml | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/.travis.yml b/.travis.yml index 8a3ae76a7c..56a2a01e14 100644 --- a/.travis.yml +++ b/.tra

[PATCH v2 11/13] block/nfs: Use URI parsing code from glib

2024-04-12 Thread Thomas Huth
Since version 2.66, glib has useful URI parsing functions, too. Use those instead of the QEMU-internal ones to be finally able to get rid of the latter. Signed-off-by: Thomas Huth --- block/nfs.c | 110 ++-- 1 file changed, 54 insertions(+), 56

[PATCH v2 12/13] block/ssh: Use URI parsing code from glib

2024-04-12 Thread Thomas Huth
Since version 2.66, glib has useful URI parsing functions, too. Use those instead of the QEMU-internal ones to be finally able to get rid of the latter. Reviewed-by: Richard W.M. Jones Signed-off-by: Thomas Huth --- block/ssh.c | 75 - 1 file

[PATCH v2 08/13] Remove glib compatibility code that is not required anymore

2024-04-12 Thread Thomas Huth
Now that we bumped the minumum glib version to 2.66, we can drop the old code. Suggested-by: Paolo Bonzini Signed-off-by: Thomas Huth --- qga/commands-posix-ssh.c | 8 util/error-report.c | 10 -- 2 files changed, 18 deletions(-) diff --git a/qga/commands-posix-ssh.c b

[PATCH v2 03/13] tests/docker/dockerfiles: Run lcitool-refresh after the lcitool update

2024-04-12 Thread Thomas Huth
This update adds the removing of the EXTERNALLY-MANAGED marker files that has been added to the lcitool recently. Signed-off-by: Thomas Huth --- tests/docker/dockerfiles/alpine.docker| 3 ++- tests/docker/dockerfiles/centos8.docker | 1 + tests/docker/dockerfiles

[PATCH v2 10/13] block/nbd: Use URI parsing code from glib

2024-04-12 Thread Thomas Huth
. Reviewed-by: Richard W.M. Jones Signed-off-by: Thomas Huth --- block/nbd.c | 76 ++--- 1 file changed, 37 insertions(+), 39 deletions(-) diff --git a/block/nbd.c b/block/nbd.c index ef05f7cdfd..589d28af83 100644 --- a/block/nbd.c +++ b/block/nbd.c

[PATCH v2 09/13] block/gluster: Use URI parsing code from glib

2024-04-12 Thread Thomas Huth
Since version 2.66, glib has useful URI parsing functions, too. Use those instead of the QEMU-internal ones to be finally able to get rid of the latter. Signed-off-by: Thomas Huth --- block/gluster.c | 71 - 1 file changed, 35 insertions(+), 36

[PATCH v2 00/13] Drop old distros, bump glib and switch to glib URI parsing code

2024-04-12 Thread Thomas Huth
to drop more glib compatibility hunks - Use g_autoptr() in the URI patches for simplification - Don't allow port 0 in the URIs Paolo Bonzini (1): ci: move external build environment setups to CentOS Stream 9 Thomas Huth (12): tests: Remove Ubuntu 20.04 container tests/lcitool/libvirt-ci: Update

[PATCH v2 07/13] Bump minimum glib version to v2.66

2024-04-12 Thread Thomas Huth
which will allow further clean-ups in the following patches. Signed-off-by: Thomas Huth --- meson.build | 16 +--- include/glib-compat.h| 27 ++- qga/commands-posix-ssh.c | 4 ++-- 3 files changed, 5 insertions(+), 42 deletions(-) diff --git

[PATCH v2 04/13] tests: Update our CI to use CentOS Stream 9 instead of 8

2024-04-12 Thread Thomas Huth
RHEL 9 (and thus also the derivatives) are available since two years now, so according to QEMU's support policy, we can drop the active support for the previous major version 8 now. Thus upgrade our CentOS Stream container to major version 9 now. Signed-off-by: Thomas Huth --- .gitlab-ci.d

[PATCH v2 13/13] util/uri: Remove the old URI parsing code

2024-04-12 Thread Thomas Huth
Now that we switched all consumers of the URI code to use the URI parsing functions from glib instead, we can remove our internal URI parsing code since it is not used anymore. Signed-off-by: Thomas Huth --- include/qemu/uri.h | 99 --- util/uri.c | 1466

[PATCH v2 01/13] tests: Remove Ubuntu 20.04 container

2024-04-12 Thread Thomas Huth
Since Ubuntu 22.04 is now available since two years, we can stop actively supporting the previous LTS version of Ubuntu now. Signed-off-by: Thomas Huth --- tests/docker/dockerfiles/ubuntu2004.docker | 157 - tests/lcitool/refresh | 1 - 2 files changed

[PATCH v2 02/13] tests/lcitool/libvirt-ci: Update to the latest master branch

2024-04-12 Thread Thomas Huth
We need the latest fixes for the lcitool to be able to properly update our CentOS docker file to CentOS Stream 9. Signed-off-by: Thomas Huth --- tests/lcitool/libvirt-ci | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/lcitool/libvirt-ci b/tests/lcitool/libvirt-ci index

[PATCH v2 06/13] ci: move external build environment setups to CentOS Stream 9

2024-04-12 Thread Thomas Huth
-off-by: Paolo Bonzini Reviewed-by: Thomas Huth Message-ID: <20240412103708.27650-1-pbonz...@redhat.com> Signed-off-by: Thomas Huth --- .../stream/{8 => 9}/build-environment.yml | 31 ++--- .../stream/{8 => 9}/x86_64/configure | 4 +- .../stream/{8 => 9}/x86_

Re: [PATCH 1/2] hw: Fix problem with the A*MPCORE switches in the Kconfig files

2024-04-12 Thread Thomas Huth
On 12/04/2024 13.10, Philippe Mathieu-Daudé wrote: On 12/4/24 08:20, Thomas Huth wrote: A9MPCORE, ARM11MPCORE and A15MPCORE are defined twice, once in hw/cpu/Kconfig and once in hw/arm/Kconfig. This is only possible by accident, since hw/cpu/Kconfig is never included from hw/Kconfig. Fix

Re: [PATCH for-9.1 4/9] Bump minimum glib version to v2.66

2024-04-12 Thread Thomas Huth
On 12/04/2024 12.16, Paolo Bonzini wrote: On Thu, Mar 28, 2024 at 3:06 PM Thomas Huth wrote: Now that we dropped support for CentOS 8 and Ubuntu 20.04, we can look into bumping the glib version to a new minimum for further clean-ups. According to repology.org, available versions

Re: [PATCH] ci: move external build environment setups to CentOS Stream 9

2024-04-12 Thread Thomas Huth
e to me! Reviewed-by: Thomas Huth

Re: [PATCH 2/2] hw: Add a Kconfig switch for the TYPE_CPU_CLUSTER device

2024-04-12 Thread Thomas Huth
On 12/04/2024 08.20, Thomas Huth wrote: The cpu-cluster device is only needed for some few arm and riscv machines. Let's avoid compiling and linking it if it is not really necessary. Signed-off-by: Thomas Huth --- hw/arm/Kconfig | 3 +++ hw/cpu/Kconfig | 3 +++ hw/cpu/meson.build

[PATCH 1/2] hw: Fix problem with the A*MPCORE switches in the Kconfig files

2024-04-12 Thread Thomas Huth
/ folder) and by making sure that the file hw/cpu/Kconfig is now properly included from hw/Kconfig. Signed-off-by: Thomas Huth --- hw/Kconfig | 1 + hw/arm/Kconfig | 15 --- hw/cpu/Kconfig | 12 +--- 3 files changed, 10 insertions(+), 18 deletions(-) diff --git a/hw

[PATCH 2/2] hw: Add a Kconfig switch for the TYPE_CPU_CLUSTER device

2024-04-12 Thread Thomas Huth
The cpu-cluster device is only needed for some few arm and riscv machines. Let's avoid compiling and linking it if it is not really necessary. Signed-off-by: Thomas Huth --- hw/arm/Kconfig | 3 +++ hw/cpu/Kconfig | 3 +++ hw/cpu/meson.build | 2 +- hw/riscv/Kconfig | 2 ++ 4 files

[PATCH 0/2] Improvements for switches in hw/cpu/Kconfig

2024-04-12 Thread Thomas Huth
First patch fixes the problem that the file hw/cpu/Kconfig is currently ignored and the switches there are duplicated in hw/arm/. The second patch introduces a proper config switch for the cpu-cluster device. Thomas Huth (2): hw: Fix problem with the A*MPCORE switches in the Kconfig files hw

Re: [PATCH for-9.0] meson.build: Disable -fzero-call-used-regs on OpenBSD

2024-04-11 Thread Thomas Huth
On 11/04/2024 14.08, Thomas Huth wrote: QEMU currently does not work on OpenBSD since the -fzero-call-used-regs That should be "OpenBSD 7.5" ... older versions are fine since they are using an older version of Clang that does not have -fzero-call-used-regs yet, I think. Thomas

[PATCH for-9.0] meson.build: Disable -fzero-call-used-regs on OpenBSD

2024-04-11 Thread Thomas Huth
ves: https://gitlab.com/qemu-project/qemu/-/issues/2278 Signed-off-by: Thomas Huth --- Note: Given that we're close to the release, I think the host_os check is the best we can do ... the problem does not seem to trigger in all functions, only if certain registers are used by the compiler,

Re: [PATCH 05/12] system/qtest: Replace sprintf() by g_string_append_printf()

2024-04-11 Thread Thomas Huth
* 2], "%02x", data[i]); ^ 1 warning generated. Signed-off-by: Philippe Mathieu-Daudé --- system/qtest.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH v9] arm/kvm: Enable support for KVM_ARM_VCPU_PMU_V3_FILTER

2024-04-10 Thread Thomas Huth
On 09/04/2024 09.47, Shaoqin Huang wrote: Hi Thmoas, On 4/9/24 13:33, Thomas Huth wrote: +    assert_has_feature(qts, "host", "kvm-pmu-filter"); So you assert here that the feature is available ...   assert_has_feature(qts, &qu

Re: [PATCH v9] arm/kvm: Enable support for KVM_ARM_VCPU_PMU_V3_FILTER

2024-04-08 Thread Thomas Huth
nt, and, when enabled, issue further tests. */ +assert_has_feature(qts, "host", "kvm-pmu-filter"); So you assert here that the feature is available ... assert_has_feature(qts, "host", "kvm-steal-time");

Re: [PATCH-for-9.1 v2 3/3] block/gluster: Remove RDMA protocol handling

2024-03-28 Thread Thomas Huth
cs/system/qemu-block-drivers.rst.inc | 1 - block/gluster.c| 39 -- 3 files changed, 2 insertions(+), 42 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH-for-9.1 v2 1/3] hw/rdma: Remove pvrdma device and rdmacm-mux helper

2024-03-28 Thread Thomas Huth
m-mux tool from contrib/ Cc: Yuval Shaia Cc: Marcel Apfelbaum Signed-off-by: Philippe Mathieu-Daudé --- Reviewed-by: Thomas Huth

Re: [PATCH-for-9.0 v2] hw/i386/pc: Deprecate 64-bit CPUs on ISA-only PC machine

2024-03-28 Thread Thomas Huth
quot;isapc") and warn that way? Why don't you simply pass it as a parameter from pc_init_isa() instead? Or do the whole check in pc_init_isa() instead? Thomas

Re: [PATCH for-9.1 6/9] block/nbd: Use URI parsing code from glib

2024-03-28 Thread Thomas Huth
On 28/03/2024 15.59, Daniel P. Berrangé wrote: On Thu, Mar 28, 2024 at 09:54:49AM -0500, Eric Blake wrote: On Thu, Mar 28, 2024 at 03:06:03PM +0100, Thomas Huth wrote: Since version 2.66, glib has useful URI parsing functions, too. Use those instead of the QEMU-internal ones to be finally able

Re: [PATCH-for-9.1 v2 2/3] migration: Remove RDMA protocol handling

2024-03-28 Thread Thomas Huth
ybe rather add a separate deprecation note for the migration part, and add a proper warning message to the migration code in case someone tries to use it there, and then only remove the rdma migration code after two more releases? Thomas

[PATCH for-9.1 7/9] block/nfs: Use URI parsing code from glib

2024-03-28 Thread Thomas Huth
Since version 2.66, glib has useful URI parsing functions, too. Use those instead of the QEMU-internal ones to be finally able to get rid of the latter. Signed-off-by: Thomas Huth --- block/nfs.c | 102 ++-- 1 file changed, 52 insertions(+), 50

[PATCH for-9.1 8/9] block/ssh: Use URI parsing code from glib

2024-03-28 Thread Thomas Huth
Since version 2.66, glib has useful URI parsing functions, too. Use those instead of the QEMU-internal ones to be finally able to get rid of the latter. Signed-off-by: Thomas Huth --- block/ssh.c | 69 +++-- 1 file changed, 40 insertions(+), 29

[PATCH for-9.1 4/9] Bump minimum glib version to v2.66

2024-03-28 Thread Thomas Huth
which will allow further clean-ups in the following patches. Signed-off-by: Thomas Huth --- meson.build | 16 +--- include/glib-compat.h| 27 ++- qga/commands-posix-ssh.c | 4 ++-- 3 files changed, 5 insertions(+), 42 deletions(-) diff --git

[PATCH for-9.1 6/9] block/nbd: Use URI parsing code from glib

2024-03-28 Thread Thomas Huth
. Signed-off-by: Thomas Huth --- block/nbd.c | 66 ++--- 1 file changed, 38 insertions(+), 28 deletions(-) diff --git a/block/nbd.c b/block/nbd.c index ef05f7cdfd..95b507f872 100644 --- a/block/nbd.c +++ b/block/nbd.c @@ -31,7 +31,6 @@ #include "

[PATCH for-9.1 9/9] util/uri: Remove the old URI parsing code

2024-03-28 Thread Thomas Huth
Now that we switched all consumers of the URI code to use the URI parsing functions from glib instead, we can remove our internal URI parsing code since it is not used anymore. Signed-off-by: Thomas Huth --- include/qemu/uri.h | 99 --- util/uri.c | 1466

[PATCH for-9.1 1/9] tests: Remove Ubuntu 20.04 container

2024-03-28 Thread Thomas Huth
Since Ubuntu 22.04 is now available since two years, we can stop actively supporting the previous LTS version of Ubuntu now. Signed-off-by: Thomas Huth --- tests/docker/dockerfiles/ubuntu2004.docker | 157 - tests/lcitool/refresh | 1 - 2 files changed

[PATCH for-9.1 3/9] tests: Update our CI to use CentOS Stream 9 instead of 8

2024-03-28 Thread Thomas Huth
RHEL 9 (and thus also the derivatives) are available since two years now, so according to QEMU's support policy, we can drop the active support for the previous major version 8 now. Thus upgrade our CentOS Stream container to major version 9 now. Signed-off-by: Thomas Huth --- .gitlab-ci.d

[PATCH for-9.1 5/9] block/gluster: Use URI parsing code from glib

2024-03-28 Thread Thomas Huth
Since version 2.66, glib has useful URI parsing functions, too. Use those instead of the QEMU-internal ones to be finally able to get rid of the latter. Cc: integrat...@gluster.org Signed-off-by: Thomas Huth --- block/gluster.c | 63 + 1 file

[PATCH for-9.1 0/9] Switch to glib URI parsing code

2024-03-28 Thread Thomas Huth
. By switching to these parsing functions, we can finally drop our own URI parsing code in util/uri.c. NB: We also need to update some of the custom runners in our CI environment first (since they still use Ubuntu 20.04). Thomas Huth (9): tests: Remove Ubuntu 20.04 container tests/lcitool

[PATCH for-9.1 2/9] tests/lcitool/libvirt-ci: Update to the latest master branch

2024-03-28 Thread Thomas Huth
We need the latest fixes for the lcitool to be able to properly update our CentOS docker file to CentOS Stream 9. Signed-off-by: Thomas Huth --- tests/lcitool/libvirt-ci | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/lcitool/libvirt-ci b/tests/lcitool/libvirt-ci index

Re: [PATCH v3 1/3] docs/interop/firmware.json: add new enum FirmwareFormat

2024-03-28 Thread Thomas Weißschuh
Hi Hanna and Kevin, any updates? On Mon, Mar 11, 2024 at 02:29:25PM +0100, Markus Armbruster wrote: > Thomas Weißschuh writes: > > > Only a small subset of all blockdev drivers make sense for firmware > > images. Introduce and use a new enum to represent this. > &g

Re: [PATCH-for-9.1] rdma: Remove RDMA subsystem and pvrdma device

2024-03-28 Thread Thomas Huth
val of the rdma migration code is in a separate patch? That way we can discuss that separately (and maybe also revert it more easily in the future if necessary). Thanks, Thomas

Re: [PATCH for-9.0 v3 0/2] qtest/virtio-9p-test.c: fix slow tests

2024-03-28 Thread Thomas Huth
file changed, 11 insertions(+), 21 deletions(-) Works for me, too! Tested-by: Thomas Huth

Re: [PATCH-for-9.0? v2 1/3] fpu/softfloat: Remove mention of TILE-Gx target

2024-03-27 Thread Thomas Huth
have floating-point. */ if (snan_bit_is_one(status)) { /* set all bits other than msb */ Reviewed-by: Thomas Huth

Re: [PATCH-for-9.1] target/nios2: Remove machines and system emulation

2024-03-27 Thread Thomas Huth
On 27/03/2024 15.15, Philippe Mathieu-Daudé wrote: On 27/3/24 14:19, Thomas Huth wrote: On 27/03/2024 13.45, Philippe Mathieu-Daudé wrote: On 27/3/24 13:35, Philippe Mathieu-Daudé wrote: Remove the Nios II machines and the system emulation code (deprecated since v8.2 in commit 9997771bc1

Re: [PATCH-for-9.1] target/nios2: Remove machines and system emulation

2024-03-27 Thread Thomas Huth
body later needs it again, it can be restored by simply reverting the patch again. Thomas

Re: [PATCH for-9.0] docs/about: Mark the iaspc machine type as deprecated

2024-03-27 Thread Thomas Huth
On 27/03/2024 14.09, Igor Mammedov wrote: On Wed, 27 Mar 2024 10:49:43 + Daniel P. Berrangé wrote: On Tue, Mar 26, 2024 at 05:16:32PM +0100, Igor Mammedov wrote: On Tue, 26 Mar 2024 14:29:58 +0100 Philippe Mathieu-Daudé wrote: Hi Igor, On 26/3/24 14:08, Thomas Huth wrote: s

Re: [RFC] util/error-report: Add "error: " prefix for error-level report

2024-03-27 Thread Thomas Huth
ane/xen-block.c:error_report("error: access beyond end of file"); hw/rdma/rdma_backend.c:rdma_error_report("Error: Not a MAD request, skipping"); hw/s390x/s390-skeys.c:error_report("Error: Setting storage keys for pages with unallocated " hw/s390x/s390-skeys.c:error_report("Error: Getting storage keys for pages with unallocated " hw/usb/bus.c:error_report("Error: no usb bus to attach usbdevice %s, " gdbstub/gdbstub.c:error_report("Error: Bad gdb register numbering for '%s', " Thomas

Re: [PULL 35/38] spapr: nested: Introduce H_GUEST_[GET|SET]_STATE hcalls.

2024-03-27 Thread Thomas Huth
to take that into consideration? Thomas

Re: [PATCH-for-9.0? v2 4/4] meson: Enable -Wstatic-in-inline

2024-03-26 Thread Thomas Huth
a pre-processor flag, so s/CPPFLAG/CFLAGS/ ? Anyway: Reviewed-by: Thomas Huth inline function to be added in the code base. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20240313184954.42513-5-phi...@linaro.org> --- meson.build | 1 + 1 file chan

Re: [PATCH-for-9.0? v2 3/4] qtest/libqos: Reduce size_to_prdtl() declaration scope

2024-03-26 Thread Thomas Huth
Signed-off-by: Philippe Mathieu-Daudé --- Reviewed-by: Thomas Huth

Re: [PATCH for-9.0 0/3] qtest/virtio-9p-test.c: fix slow tests

2024-03-26 Thread Thomas Huth
On 26/03/2024 14.26, Daniel Henrique Barboza wrote: Hi, Thomas reported in [1] a problem that happened with the RISC-V machine where some tests from virtio-9p-test.c were failing with '-m slow', i.e. enabling slow tests. In the end it wasn't a RISC-V specific problem. It just so happens

Re: [PATCH for-9.0] docs/about: Mark the iaspc machine type as deprecated

2024-03-26 Thread Thomas Huth
On 26/03/2024 14.29, Philippe Mathieu-Daudé wrote: Hi Igor, On 26/3/24 14:08, Thomas Huth wrote: s/iaspc/isapc/ in the subject On 26/03/2024 13.51, Igor Mammedov wrote: ISAPC machine was introduced 25 years ago and it's a lot of time since such machine was around with real ISA only PC

Re: [PATCH for-9.0] docs/about: Mark the iaspc machine type as deprecated

2024-03-26 Thread Thomas Huth
ion, since it's an unversioned machine type, so I think it would be better to not mention live migration here. Thomas

Re: how do the iotests pick a machine model to run on ?

2024-03-25 Thread Thomas Huth
y non-migratable device 'cpu' How should a test indicate "I need a machine type that supports migration" ? We could maybe add a flag to the machine_map to indicate whether the machine is capable of migration or not. In the latter case, we could skip all tests that are in the "migration" group ? Thomas

[PATCH] tests/qemu-iotests: Test 157 and 227 require virtio-blk

2024-03-25 Thread Thomas Huth
Tests 157 and 227 use the virtio-blk device, so we have to mark these tests accordingly to be skipped if this devices is not available (e.g. when running the tests with qemu-system-avr only). Signed-off-by: Thomas Huth --- tests/qemu-iotests/157 | 2 ++ tests/qemu-iotests/227 | 2 ++ 2 files

Re: [PATCH for-9.1 v5 1/3] hw: Add compat machines for 9.1

2024-03-25 Thread Thomas Huth
On 25/03/2024 15.14, Paolo Bonzini wrote: Add 9.1 machine types for arm/i440fx/m68k/q35/s390x/spapr. Cc: Cornelia Huck Cc: Thomas Huth Cc: Harsh Prateek Bora Cc: Gavin Shan Signed-off-by: Paolo Bonzini --- include/hw/boards.h| 3 +++ include/hw/i386/pc.h | 3 +++ hw/arm

[PULL 5/9] aspeed: Make the ast1030-a1 SoC not user creatable

2024-03-25 Thread Thomas Huth
From: Cédric Le Goater Aspeed SoCs are complex devices that can not be specified on the command line. Fix that to avoid QEMU aborts. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2227 Fixes: 356b230ed138 ("aspeed/soc : Add AST1030 support") Reported-by: Thomas Huth

[PULL 3/9] hw/microblaze: Do not allow xlnx-zynqmp-pmu-soc to be created by the user

2024-03-25 Thread Thomas Huth
reatable = false" to avoid that this can happen. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2229 Message-ID: <20240322183153.1023359-1-th...@redhat.com> Signed-off-by: Thomas Huth --- hw/microblaze/xlnx-zynqmp-pmu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a

[PULL 4/9] aspeed: Make the ast2600-a3 SoC not user creatable

2024-03-25 Thread Thomas Huth
From: Cédric Le Goater Aspeed SoCs are complex devices that can not be specified on the command line. Fix that to avoid QEMU aborts. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2227 Fixes: f25c0ae1079d ("aspeed/soc: Add AST2600 support") Reported-by: Thomas Huth

[PULL 8/9] target/s390x: Use mutable temporary value for op_ts

2024-03-25 Thread Thomas Huth
y: Richard Henderson [iii: Adjust a newline and capitalization, add tags] Signed-off-by: Ido Plat Signed-off-by: Ilya Leoshkevich Reviewed-by: David Hildenbrand Message-ID: <20240318202722.20675-1-...@linux.ibm.com> Signed-off-by: Thomas Huth --- target/s390x/tcg/translate.c | 5 +++-- 1

[PULL 7/9] libqos/virtio.c: Correct 'flags' reading in qvirtqueue_kick

2024-03-25 Thread Thomas Huth
athieu-Daudé Reviewed-by: Stefan Hajnoczi Message-ID: <20240320090442.267525-1-zheyum...@gmail.com> Signed-off-by: Thomas Huth --- tests/qtest/libqos/virtio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qtest/libqos/virtio.c b/tests/qtest/libqos/virtio.c inde

[PULL 6/9] misc/pca955*: Move models under hw/gpio

2024-03-25 Thread Thomas Huth
com> Reviewed-by: Thomas Huth Signed-off-by: Thomas Huth --- MAINTAINERS | 4 ++-- include/hw/{misc => gpio}/pca9552.h | 0 include/hw/{misc => gpio}/pca9552_regs.h | 0 include/hw/{misc => gpio}/pca9554.h | 0 include/hw/{misc => gpio}/pca9554_

[PULL 2/9] .travis.yml: Remove the unused xfslib-dev package

2024-03-25 Thread Thomas Huth
Drop the "xfslibs-dev" package which should not be necessary anymore since commit a5730b8bd3 ("block/file-posix: Simplify the XFS_IOC_DIOINFO handling"). Message-ID: <20240320104144.823425-3-th...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Thomas

[PULL 0/9] Patches for QEMU 9.0-rc1

2024-03-25 Thread Thomas Huth
misc/pca955*: Move models under hw/gpio Ido Plat (1): target/s390x: Use mutable temporary value for op_ts Ilya Leoshkevich (1): tests/tcg/s390x: Test TEST AND SET Thomas Huth (3): .travis.yml: Shorten the runtime of the problematic jobs .travis.yml: Remove

<    1   2   3   4   5   6   7   8   9   10   >