[Qemu-devel] [PATCH v2] tap: fix memory leak on success to create a tap device

2018-05-31 Thread wangyunjian
From: Yunjian Wang The memory leak on success to create a tap device. And the nfds and nvhosts may not be the same and need to be processed separately. Fixes: 07825977 ("tap: fix memory leak on failure to create a multiqueue tap device") Fixes: 264986e2 ("tap: multiqueue support") CC: QEMU Sta

[Qemu-devel] [PATCH] tap: fix memory leak on success to create a tap device

2018-05-30 Thread wangyunjian
From: Yunjian Wang Signed-off-by: Yunjian Wang --- net/tap.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/net/tap.c b/net/tap.c index de05f20..6d7710f 100644 --- a/net/tap.c +++ b/net/tap.c @@ -803,7 +803,8 @@ int net_init_tap(const Netdev *netdev, const

Re: [Qemu-devel] [PATCH] vhost-user: fix watcher need be removed when vhost-user hotplug

2017-05-09 Thread wangyunjian
On Tue, May 9, 2017 at 5:04 PM Yunjian Wang wrote: > > From: w00273186 > > > > "nc" is freed after hotplug vhost-user, but the watcher don't be removed. > > > > > > The QEMU crash when the watcher access the "nc" on socket disconnect. > > > > > Do you have a reproducer? thanks > reproduce ste

Re: [Qemu-devel] [PATCH] virtio-net: fix wild pointer when remove virtio-net queues

2017-04-26 Thread wangyunjian
> -Original Message- > From: Jason Wang [mailto:jasow...@redhat.com] > Sent: Wednesday, April 26, 2017 5:18 PM > To: wangyunjian ; m...@redhat.com; > qemu-devel@nongnu.org > Cc: caihe > Subject: Re: [Qemu-devel] [PATCH] virtio-net: fix wild pointer when remove

Re: [Qemu-devel] [BUG] QEMU crashes with dpdk virtio pmd

2017-04-25 Thread wangyunjian
= NULL; } else { qemu_bh_delete(q->tx_bh); +q->tx_bh = NULL; } +q->tx_waiting = 0; virtio_del_queue(vdev, index * 2 + 1); } From: wangyunjian Sent: Monday, April 24, 2017 6:10 PM To: qemu-devel@nongnu.org; Michael S. Tsirkin ; 'Jason Wang' Cc: wangyunjian ;

[Qemu-devel] [BUG] QEMU crashes with dpdk virtio pmd

2017-04-24 Thread wangyunjian
Qemu crashes, with pre-condition: vm xml config with multiqueue, and the vm's driver virtio-net support multi-queue reproduce steps: i. start dpdk testpmd in VM with the virtio nic ii. stop testpmd iii. reboot the VM This commit "f9d6dbf0 remove virtio queues if the guest doesn't support multi

Re: [Qemu-devel] A question about this commit "char: convert from GIOChannel to QIOChannel"

2016-10-17 Thread wangyunjian
Message- From: Paolo Bonzini [mailto:pbonz...@redhat.com] Sent: Monday, October 17, 2016 9:20 PM To: wangyunjian Cc: berra...@redhat.com; qemu-devel@nongnu.org; caihe Subject: Re: A question about this commit "char: convert from GIOChannel to QIOChannel" - Original Messa

[Qemu-devel] A question about this commit "char: convert from GIOChannel to QIOChannel"

2016-10-17 Thread wangyunjian
Commit 9894dc0cdcc397ee5b26370bc53da6d360a363c2 “char: convert from GIOChannel to QIOChannel”, about the below code segment: ・・・ ・・・ @@ -3107,22 +2965,16 @@ static void tcp_chr_close(CharDriverState *chr) s->reconnect_timer = 0; } qapi_free_SocketAddress(s->addr); -if (s->f