Re: [Qemu-devel] [PATCH v5 2/6] fsdev-throttle-qmp: Rename the ThrottleLimits member names

2018-11-29 Thread xiezhide
> > Eric Blake writes: > > > On 11/28/18 3:25 AM, Markus Armbruster wrote: > >> xiezhide writes: > >> > >>> Rename the ThrottleLimits member names and modify related code > >>> > >>> Signed-off-by: xiezhide > >&g

Re: [Qemu-devel] [PATCH v5 2/6] fsdev-throttle-qmp: Rename the ThrottleLimits member names

2018-11-28 Thread xiezhide
> Subject: Re: [Qemu-devel] [PATCH v5 2/6] fsdev-throttle-qmp: Rename the > ThrottleLimits member names > > On 11/28/18 3:25 AM, Markus Armbruster wrote: > > xiezhide writes: > > > >> Rename the ThrottleLimits member names and modify related code

Re: [Qemu-devel] [PATCH v5 2/6] fsdev-throttle-qmp: Rename the ThrottleLimits member names

2018-11-28 Thread xiezhide
> Subject: Re: [Qemu-devel] [PATCH v5 2/6] fsdev-throttle-qmp: Rename the > ThrottleLimits member names > > xiezhide writes: > > > Rename the ThrottleLimits member names and modify related code > > > > Signed-off-by: xiezhide > &

Re: [Qemu-devel] [PATCH v5 1/6] fsdev-throttle-qmp: factor out throttle code to reuse code

2018-11-22 Thread xiezhide
> -Original Message- > From: Greg Kurz [mailto:gr...@kaod.org] > Sent: Thursday, November 22, 2018 10:46 PM > To: xiezhide > Cc: qemu-devel@nongnu.org; aneesh.ku...@linux.vnet.ibm.com; > ebl...@redhat.com; arm...@redhat.com; be...@igalia.com; zengcanfu >

Re: [Qemu-devel] [PATCH v4 1/4] fsdev-throttle-qmp: factor out throttle code to reuse code

2018-11-16 Thread xiezhide
-Original Message- From: Eric Blake [mailto:ebl...@redhat.com] Sent: 2018年11月16日 4:56 To: xiezhide ; qemu-devel@nongnu.org Cc: gr...@kaod.org; aneesh.ku...@linux.vnet.ibm.com; arm...@redhat.com; be...@igalia.com; zengcanfu 00215970 ; Jinxuefeng ; Chenhui (Felix, Euler) Subject: Re

Re: [Qemu-devel] [PATCH v4 2/4] fsdev-throttle-qmp: move struct ThrottleLimits to new file

2018-11-16 Thread xiezhide
-Original Message- From: Eric Blake [mailto:ebl...@redhat.com] Sent: 2018年11月16日 5:41 To: xiezhide ; qemu-devel@nongnu.org Cc: gr...@kaod.org; aneesh.ku...@linux.vnet.ibm.com; arm...@redhat.com; be...@igalia.com; zengcanfu 00215970 ; Jinxuefeng ; Chenhui (Felix, Euler) Subject: Re

Re: [Qemu-devel] [PATCH v4 2/4] fsdev-throttle-qmp: move struct ThrottleLimits to new file

2018-11-16 Thread xiezhide
-Original Message- From: Eric Blake [mailto:ebl...@redhat.com] Sent: 2018年11月16日 6:03 To: xiezhide ; qemu-devel@nongnu.org Cc: be...@igalia.com; arm...@redhat.com; zengcanfu 00215970 ; gr...@kaod.org; aneesh.ku...@linux.vnet.ibm.com; Jinxuefeng ; Chenhui (Felix, Euler) Subject: Re

[Qemu-devel] [PATCH v5 4/6] fsdev-throttle-qmp: Move ThrottleLimits into a new file for future reuse

2018-11-16 Thread xiezhide
Move ThrottleLimits into a new file for future reuse. Signed-off-by: xiezhide --- Makefile | 9 + Makefile.objs | 4 qapi/block-core.json | 49 +-- qapi/qapi-schema.json | 1 + qapi/tlimits.json | 53

[Qemu-devel] [PATCH v5 6/6] fsdev-throttle-qmp: hmp interface for fsdev io throttling

2018-11-16 Thread xiezhide
introduces io throttling hmp interfaces for the fsdev devices Signed-off-by: xiezhide --- hmp-commands-info.hx | 15 ++ hmp-commands.hx | 15 ++ hmp.c| 81 ++-- hmp.h| 4 +++ 4 files changed

[Qemu-devel] [PATCH v5 2/6] fsdev-throttle-qmp: Rename the ThrottleLimits member names

2018-11-16 Thread xiezhide
Rename the ThrottleLimits member names and modify related code Signed-off-by: xiezhide --- qapi/block-core.json | 70 +++--- util/throttle.c | 163 +-- 2 files changed, 116 insertions(+), 117 deletions(-) diff --git a/qapi

[Qemu-devel] [PATCH v5 3/6] fsdev-throttle-qmp: Rewrite BlockIOThrottle with ThrottleLimits as its base class

2018-11-16 Thread xiezhide
Rewrite BlockIOThrottle with ThrottleLimits as its base class and modify related code Signed-off-by: xiezhide --- blockdev.c | 2 ++ qapi/block-core.json | 73 ++-- 2 files changed, 4 insertions(+), 71 deletions(-) diff --git a

[Qemu-devel] [PATCH v5 5/6] fsdev-throttle-qmp: qmp interface for fsdev io throttling

2018-11-16 Thread xiezhide
provides two interfaces: 1. set the IO limits for the required fsdev device 2. query info of all the fsdev devices. Signed-off-by: xiezhide --- Makefile| 27 - Makefile.objs | 12 -- fsdev/qemu-fsdev-dummy.c| 11 + fsdev/qemu-fsdev

[Qemu-devel] [PATCH v5 1/6] fsdev-throttle-qmp: factor out throttle code to reuse code

2018-11-16 Thread xiezhide
Factor out throttle parameter parsing code to a new common function which will be used by block and fsdev. Rename function throttle_parse_options to throttle_parse_group to resolve function name conflict Reviewed-by: Eric Blake Signed-off-by: xiezhide --- block/throttle.c| 6

[Qemu-devel] [PATCH v5 0/6] fsdev-throttle-qmp: qmp interface for fsdev io throttling

2018-11-16 Thread xiezhide
This patches provide qmp interface to query/set io throttle parameters of a fsdev. Some of patches also refactor the code and structure that was present in block and fsdev files. xiezhide (6): fsdev-throttle-qmp: factor out throttle code to reuse code fsdev-throttle-qmp: Rename the

[Qemu-devel] [PATCH v4 1/4] fsdev-throttle-qmp: factor out throttle code to reuse code

2018-11-15 Thread xiezhide
This patch factor out throttle parameter parse code to common function which will be used by block and fsdev. rename function throttle_parse_options to throttle_parse_group to resolve function name conflict Signed-off-by: xiezhide --- block/throttle.c| 6 ++-- blockdev.c

[Qemu-devel] [PATCH v4 4/4] fsdev-throttle-qmp: hmp interface for fsdev io throttling

2018-11-15 Thread xiezhide
introduces io throttling hmp interfaces for the fsdev devices Signed-off-by: xiezhide --- hmp-commands-info.hx | 15 ++ hmp-commands.hx | 15 ++ hmp.c| 83 +++- hmp.h| 4 +++ qapi/tlimits.json

[Qemu-devel] [PATCH v4 3/4] fsdev-throttle-qmp: qmp interface for fsdev io throttling

2018-11-15 Thread xiezhide
provides two interfaces: 1. set the IO limits for the required fsdev device 2. query info of all the fsdev devices. Signed-off-by: xiezhide --- Makefile| 9 + Makefile.objs | 4 ++ fsdev/qemu-fsdev-dummy.c| 11 + fsdev/qemu-fsdev-throttle.c | 98

[Qemu-devel] [PATCH v4 0/4] fsdev-throttle-qmp: qmp interface for fsdev io throttling

2018-11-15 Thread xiezhide
This patches provide qmp interface to query/set io throttle parameters of a fsdev. Some of patches also refactor the code and structure that was present in block and fsdev files. xiezhide (4): fsdev-throttle-qmp: factor out throttle code to reuse code fsdev-throttle-qmp: move struct

[Qemu-devel] [PATCH v4 2/4] fsdev-throttle-qmp: move struct ThrottleLimits to new file

2018-11-15 Thread xiezhide
this patch move ThrottleLimits to new file and rename struct field with common format Signed-off-by: xiezhide --- Makefile | 9 +++ Makefile.objs | 4 ++ blockdev.c| 51 +--- qapi/block-core.json | 122

[Qemu-devel] [PATCH v3 3/4] fsdev-throttle-qmp: qmp interface for fsdev io throttling

2018-11-14 Thread xiezhide
provides two interfaces: 1. set the IO limits for the required fsdev device 2. query info of all the fsdev devices. Signed-off-by: xiezhide --- Makefile| 9 + Makefile.objs | 4 ++ fsdev/qemu-fsdev-dummy.c| 11 + fsdev/qemu-fsdev-throttle.c | 98

[Qemu-devel] [PATCH v3 4/4] fsdev-throttle-qmp: hmp interface for fsdev io throttling

2018-11-14 Thread xiezhide
introduces io throttling hmp interfaces for the fsdev devices Signed-off-by: xiezhide --- hmp-commands-info.hx | 15 ++ hmp-commands.hx | 15 ++ hmp.c| 83 +++- hmp.h| 4 +++ qapi/tlimits.json

[Qemu-devel] [PATCH v3 2/4] fsdev-throttle-qmp: move struct ThrottleLimits to new file

2018-11-14 Thread xiezhide
this patch move ThrottleLimits to new file and rename struct field with common format Signed-off-by: xiezhide --- Makefile | 9 +++ Makefile.objs | 4 ++ blockdev.c| 51 +--- qapi/block-core.json | 122

[Qemu-devel] [PATCH v3 1/4] fsdev-throttle-qmp: factor out throttle code to reuse code

2018-11-14 Thread xiezhide
This patch factor out throttle parameter parse code to common function which will be used by block and fsdev. rename function throttle_parse_options to throttle_parse_group to resolve function name conflict Signed-off-by: xiezhide --- block/throttle.c| 6 ++-- blockdev.c

[Qemu-devel] [PATCH v3 0/4] fsdev-throttle-qmp: qmp interface for fsdev io throttling

2018-11-14 Thread xiezhide
This patches provide qmp interface to query/set io throttle parameters of a fsdev. Some of patches also refactor the code and structure that was present in block and fsdev files. xiezhide (4): fsdev-throttle-qmp: factor out throttle code to reuse code fsdev-throttle-qmp: move struct

Re: [Qemu-devel] [PATCH v2 1/3] fsdev-throttle-qmp: refactor code for qmp interface for io throttling

2018-11-14 Thread xiezhide
-Original Message- From: Eric Blake [mailto:ebl...@redhat.com] Sent: 2018年11月14日 7:25 To: xiezhide ; qemu-devel@nongnu.org Cc: gr...@kaod.org; aneesh.ku...@linux.vnet.ibm.com; arm...@redhat.com; be...@igalia.com; zengcanfu 00215970 ; Jinxuefeng ; Chenyi (johnny, RTOS) Subject: Re

Re: [Qemu-devel] [PATCH v1 0/3] fsdev-throttle-qmp: refactor code for qmp interface

2018-11-13 Thread xiezhide
] [PATCH v2 3/3] fsdev-throttle-qmp: hmp interface for fsdev io throttling Thanks Kidd -Original Message- From: Greg Kurz [mailto:gr...@kaod.org] Sent: 2018年11月13日 20:04 To: xiezhide Cc: qemu-devel@nongnu.org; Eric Blake ; arm...@redhat.com; dgilb...@redhat.com; be...@igalia.com

[Qemu-devel] [PATCH v2 3/3] fsdev-throttle-qmp: hmp interface for fsdev io throttling

2018-11-13 Thread xiezhide
introduces io throttling hmp interfaces for the fsdev devices Signed-off-by: xiezhide --- hmp-commands-info.hx | 15 ++ hmp-commands.hx | 15 ++ hmp.c| 83 +++- hmp.h| 4 +++ 4 files changed

[Qemu-devel] [PATCH v2 1/3] fsdev-throttle-qmp: refactor code for qmp interface for io throttling

2018-11-13 Thread xiezhide
This patch includes two parts: 1. factor out throttle code to reuse code 2. use ThrottleLimits structure Signed-off-by: xiezhide --- Makefile| 20 +++- Makefile.objs | 8 ++ block/throttle.c| 6 +- blockdev.c

[Qemu-devel] [PATCH v2 0/3] fsdev-throttle-qmp: qmp interface for fsdev io throttling

2018-11-13 Thread xiezhide
This patches provide qmp interface to query/set io throttle parameters of a fsdev. Some of patches also refactor the code and structure that was present in block and fsdev files. xiezhide (3): fsdev-throttle-qmp: refactor code for qmp interface for io throttling fsdev-throttle-qmp: qmp

[Qemu-devel] [PATCH v2 2/3] fsdev-throttle-qmp: qmp interface for fsdev io throttling

2018-11-13 Thread xiezhide
provides two interfaces: 1. set the IO limits for the required fsdev device 2. query info of all the fsdev devices. Signed-off-by: xiezhide --- fsdev/qemu-fsdev-dummy.c| 11 fsdev/qemu-fsdev-throttle.c | 144 +--- fsdev/qemu-fsdev-throttle.h

Re: [Qemu-devel] [PATCH v1 0/3] fsdev-throttle-qmp: refactor code for qmp interface

2018-11-13 Thread xiezhide
年11月13日 18:29 To: xiezhide Cc: qemu-devel@nongnu.org; Eric Blake ; arm...@redhat.com; dgilb...@redhat.com; be...@igalia.com; aneesh.ku...@linux.vnet.ibm.com Subject: Re: [Qemu-devel][PATCH v1 0/3] fsdev-throttle-qmp: refactor code for qmp interface Hi Kidd, This posting is still broken: no

Re: [Qemu-devel] [PATCH 2/2] virtio-9p: fix coding style issue

2018-11-13 Thread xiezhide
-Original Message- From: Greg Kurz [mailto:gr...@kaod.org] Sent: 2018年11月13日 1:55 To: xiezhide Cc: qemu-devel@nongnu.org; be...@igalia.com; arm...@redhat.com; dgilb...@redhat.com; aneesh.ku...@linux.vnet.ibm.com Subject: Re: [Qemu-devel] [PATCH 2/2] virtio-9p: fix coding style issue

Re: [Qemu-devel] [PATCH 1/2] virtio-9p: qmp interface to set/query io throttle for fsdev devices

2018-11-13 Thread xiezhide
-Original Message- From: Eric Blake [mailto:ebl...@redhat.com] Sent: 2018年11月13日 0:27 To: xiezhide ; qemu-devel@nongnu.org Cc: arm...@redhat.com; gr...@kaod.org; dgilb...@redhat.com; be...@igalia.com; aneesh.ku...@linux.vnet.ibm.com Subject: Re: [Qemu-devel] [PATCH 1/2] virtio-9p: qmp

Re: [Qemu-devel] [PATCH 0/2] virtio-9p: qmp interface for set/query io throttle for fsdev devices

2018-11-13 Thread xiezhide
> These patches provide the qmp interface, to set/query the io throttle > status of the all fsdev devices that are present in a vm. > Some of the patches also remove the > duplicate code that was present in block and fsdev files. > > Zhide Xie (2): > fsdev-qmp: qmp interface for set/query io

[Qemu-devel] [PATCH v1 3/3] fsdev-throttle-qmp: hmp interface for fsdev io throttling

2018-11-13 Thread xiezhide
introduces io throttling hmp interfaces for the fsdev devices Signed-off-by: x00390961 --- hmp-commands-info.hx | 15 ++ hmp-commands.hx | 15 ++ hmp.c| 83 +++- hmp.h| 4 +++ 4 files changed, 1

[Qemu-devel] [PATCH v1 1/3] fsdev-throttle-qmp: refactor code for qmp interface

2018-11-13 Thread xiezhide
This patch includes two parts: 1. factor out throttle code to reuse code 2. use ThrottleLimits structure Signed-off-by: x00390961 --- Makefile| 20 +++- Makefile.objs | 8 ++ block/throttle.c| 6 +- blockdev.c |

[Qemu-devel] [PATCH v1 0/3] fsdev-throttle-qmp: refactor code for qmp interface

2018-11-13 Thread xiezhide
This patches provide qmp interface to query/set io throttle parameters of a fsdev. Some of patches also refactor the code and structure that was present in block and fsdev files. x00390961 (3): fsdev-throttle-qmp: refactor code for qmp interface for io throttling fsdev-throttle-qmp: qmp inte

[Qemu-devel] [PATCH v1 2/3] fsdev-throttle-qmp: qmp interface for fsdev io

2018-11-13 Thread xiezhide
provides two interfaces: 1. set the IO limits for the required fsdev device 2. query info of all the fsdev devices. Signed-off-by: x00390961 --- fsdev/qemu-fsdev-dummy.c| 11 fsdev/qemu-fsdev-throttle.c | 144 +--- fsdev/qemu-fsdev-throttle.h |

[Qemu-devel] [PATCH 0/2] virtio-9p: qmp interface for set/query io throttle for fsdev devices

2018-11-11 Thread xiezhide
These patches provide the qmp interface, to set/query the io throttle status of the all fsdev devices that are present in a vm. Some of the patches also remove the duplicate code that was present in block and fsdev files. Zhide Xie (2): fsdev-qmp: qmp interface for set/query io throttle for fsde

Re: [Qemu-devel] [PATCH 2/2] virtio-9p: fix coding style issue

2018-11-11 Thread xiezhide
fix two coding style issue Signed-off-by: x00390961 mailto:xiezh...@huawei.com>> --- fsdev/qemu-fsdev-throttle.c | 2 +- include/qemu/throttle-options.h | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/fsdev/qemu-fsdev-throttle.c b/fsdev/qemu-fsdev-throttle.c index 7d31

[Qemu-devel] [PATCH 1/2] virtio-9p: qmp interface to set/query io throttle for fsdev devices

2018-11-11 Thread xiezhide
This patch provide qmp interface to set/query io throttle for fsdev devices. This patch include following work: 1. port Pradeep Jagadeesh's patches, details please review http://lists.gnu.org/archive/html/qemu-devel/2017-10/msg00173.html 2. fix two issue: (1). qmp set io throttle code dump when q

[Qemu-devel] [PATCH 0/2] virtio-9p: qmp interface for set/query io throttle for fsdev devices

2018-11-09 Thread xiezhide
These patches provide the qmp interface, to set/query the io throttle status of the all fsdev devices that are present in a vm. Some of the patches also remove the duplicate code that was present in block and fsdev files. Zhide Xie (2): fsdev-qmp: qmp interface for set/query io throttle for fsde