[Bug 1889288] Re: aarch64 BICS instruciton doesn't set flags

2020-07-28 Thread Robert
Oh yes I see. Sorry for the false report. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1889288 Title: aarch64 BICS instruciton doesn't set flags Status in QEMU: Invalid Bug description: When

[Bug 1889288] Re: aarch64 BICS instruciton doesn't set flags

2020-07-28 Thread Peter Maydell
The code is correct (though it is admittedly not entirely obvious at first glance). The switch statement at line 4753 is on "(opc | (invert << 2))" (where opc is a 2 bit field and invert a 1 bit field). Both ANDS and BICS have opc==3 and so will cause a call to gen_logic_CC(). The difference betwee