New version of the patches posted:
[PATCH 0/4] Convert remaining submodules to meson, cleanup env var
handling
This will sidestep the issue that broke in the Sep 24 pull request.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
Intentional because they possibly broke one of the build scenarios that
are tested pre-pull (even though the GitLab CI was fine, it does not yet
cover everything).
The plan is to flush my queue until there's only the current 5 pending
meson patches, and then submit those in isolation.
--
You
Hi Paolo,
The CFLAGS patches seem to have missed your last big pull req:
[PULL v8 00/86] Misc QEMU patches for 2020-09-24
Apparently disappeared between v3 and v4. Oversight or intentional?
Thanks.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is
Yes, of course.
Il mer 30 set 2020, 21:25 Frederic Bezies <1896...@bugs.launchpad.net> ha
scritto:
> Just asking: any hope to see this patch added to qemu git source code?
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
>
Just asking: any hope to see this patch added to qemu git source code?
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1896096
Title:
Git version: Build process is broken in block_curl.c.o
Status
v2 patches appear to work fine in both test scenarios. Thanks again.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1896096
Title:
Git version: Build process is broken in block_curl.c.o
Status in
Yes that's a silly mistake that invokes the linker with a dummy empty
argument. I'll fix it and repost, thanks for testing on Arch!
Paolo
Il mar 22 set 2020, 23:41 Toolybird <1896...@bugs.launchpad.net> ha
scritto:
> ** Attachment added: "meson-log.txt"
>
>
** Attachment added: "meson-log.txt"
https://bugs.launchpad.net/qemu/+bug/1896096/+attachment/5413347/+files/meson-log.txt
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1896096
Title:
Git
> Posted "[PATCH 0/4] configure: bugfixes and cleanups for CFLAGS".
(sorry for delay)
Thanks for the patches. They seem to fix the Arch case i.e. build
succeeds without hacks and FLAGS in the build env are being respected.
However, I tested the "unset FLAGS" case and patch 4/4 seems to cause a
Posted "[PATCH 0/4] configure: bugfixes and cleanups for CFLAGS".
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1896096
Title:
Git version: Build process is broken in block_curl.c.o
Status in
> But --extra-cflags="my additional compiler switch" seems to
> also add it to the link line which seems a bit odd?
That's due to LTO. IIRC autotools do the same (after all
the linking step is a "cc" invocation), but I may be wrong.
> I wonder why you didn't just bite the bullet and go full
> So we need to unset CFLAGS and LDFLAGS in the configure script.
Yes, but is this what you really want? It seems to go against standard
practice. The usual expectation is even documented in Meson docs:
https://mesonbuild.com/howtox.html#set-extra-compiler-and-linker-flags-
Il dom 20 set 2020, 00:40 Toolybird <1896...@bugs.launchpad.net> ha
scritto:
> Looking deeper into this... I believe there are indeed qemu bugs here.
>
You're right.
$ cat test
#! /bin/sh
echo before
env | grep LDFLAGS
LDFLAGS="-pie $LDFLAGS"
echo after
env | grep LDFLAGS
$ ./test
before
after
Looking deeper into this... I believe there are indeed qemu bugs here.
It's actually the qemu configure script which is adding `-pie'
$ echo $LDFLAGS
-Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now
Yet meson-logs/meson-log.txt tells me that:
Using 'LDFLAGS' from environment with value: '-g
Well, I'll wait until qemu 5.2.0 is released to see how archlinux work
around this problem. Thanks anyway for your help.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1896096
Title:
Git version:
Nope, something is overriding your LDFLAGS and adding -pie back. Please
open a bug on Arch, if they want to enable PIE by default they can do it in
gcc and binutils.
Adding -pie to LDFLAGS is as nonsensical as adding -shared.
--
You received this bug notification because you are a member of
Building log while settings LDFLAGS as is: export LDFLAGS="-Wl,-O1
,--sort-common,--as-needed,-z,relro,-z,now"
** Attachment added: "qemuv1-2.log"
https://bugs.launchpad.net/qemu/+bug/1896096/+attachment/5412418/+files/qemuv1-2.log
--
You received this bug notification because you are a
You can include the output of the build to help debugging this further
failure.
LDFLAGS has legitimate used but I think it would make sense to fail
configure if LDFLAGS contains -pie. Perhaps Meson could do so as well.
--
You received this bug notification because you are a member of qemu-
Just for your information, I added this before configure and it is still
broken: export LDFLAGS="-Wl,-O1,--sort-common,--as-
needed,-z,relro,-z,now"
I think I'll wait until Qemu 5.2.0 is released to see how Archlinux will fix
this annoying behaviour.
--
You received this bug notification
Huh. I thought we ignored the environment LDFLAGS/CFLAGS from much
earlier than 5.0 and was about to ask if honouring it was a change
introduced with the Meson switch! My (not necessarily very considered)
opinion is that generally it's better not to honour the environment
CFLAGS and LDFLAGS
Chiming in here as the user who initially suggested Arch use this:
--extra-ldflags="$LDFLAGS"
qemu-5.0.0 introduced a breaking change whereby LDFLAGS from the
environment were ignored. For Arch, this resulted in exclusion of `--as-
needed' from the link, which naturally caused dependency chaos.
You have to unset LDFLAGS, or remove -pie. Specifying --extra-ldflags is
useless because Meson already obeys the LDFLAGS environment variable.
Il ven 18 set 2020, 19:11 Frederic Bezies <1896...@bugs.launchpad.net> ha
scritto:
> And qemu log build using make -V=1.
>
> Hope it helps.
>
> **
Configure line: configure \
--prefix=/usr \
--sysconfdir=/etc \
--localstatedir=/var \
--libexecdir=/usr/lib/qemu \
--smbd=/usr/bin/smbd \
--extra-ldflags="-Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now" \
--enable-modules \
--enable-sdl \
--disable-werror \
And qemu log build using make -V=1.
Hope it helps.
** Attachment added: "qemuv1-2.log"
https://bugs.launchpad.net/qemu/+bug/1896096/+attachment/5412260/+files/qemuv1-2.log
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
FWIW, I reproduced the original failure using your LDFLAGS, and tested
that removing '-pie' made it work
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1896096
Title:
Git version: Build process is
What's your new configure command line? Attach the config.log and make V=1
log again please.
That said, I noticed that the flags were included twice in the linker
command line so maybe you've only removed them in one place.
Il ven 18 set 2020, 18:20 Frederic Bezies <1896...@bugs.launchpad.net>
Even with LDFLAGS tweaking, it breaks. Anyway, thanks for your help
here.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1896096
Title:
Git version: Build process is broken in block_curl.c.o
So, I'll try to tweak LDFLAGS and if it doesn't work, well... That's
life. Thanks for the infos.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1896096
Title:
Git version: Build process is broken
Before the meson port, the "-pie" arg was on the CLI *before* the
"-shared" arg so the "-shared" wins and results in a shared library.
After the meson port, "-shared" appears first, and so "-pie" wins and
tries to create an executable.
IOW, this passing of -pie was always wrong, and it was only
FYI, QEMU automatically enables PIC/PIE as needed, so there's no need to
set it via these flags.
In fact everything in your $CFLAGS is already set by QEMU out of the box
too.
For LDFLAGS you can cull the -g and -pie
--
You received this bug notification because you are a member of qemu-
I used these settings until Qemu 5.1.0 was released and it worked. These
flags are used by archlinux for stable qemu release packaging.
See https://github.com/archlinux/svntogit-
packages/blob/packages/qemu/trunk/PKGBUILD
Since qemu moved to meson, it breaks. I don't know why it used to work
** Attachment added: "config.log asked for"
https://bugs.launchpad.net/qemu/+bug/1896096/+attachment/5412210/+files/config.log
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1896096
Title:
Git
** Attachment added: "config-host.mak asked for"
https://bugs.launchpad.net/qemu/+bug/1896096/+attachment/5412211/+files/config-host.mak
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1896096
The problem is caused by the extra flags you're forcing on the compiler:
Using 'CFLAGS' from environment with value: '-O2 -g -fPIE -DPIE -std=gnu99
-Wall'
Using 'LDFLAGS' from environment with value: '-g -pie
-Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now'
Using 'CPPFLAGS' from environment
Please attach config-host.mak and config.log. Hopefully that is enough
to blame one of you, :) configure, meson.build or Meson itself.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1896096
Title:
When I looked at /etc/makepkg.conf on my Archlinux, I found;
LDFLAGS="-Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now"
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1896096
Title:
Git version:
cc -o block-curl.so -Wl,--as-needed -Wl,--allow-shlib-undefined
-shared -fPIC -Wl,--start-group -Wl,-soname,block-curl.so -Wl,--whole-
archive libblock-curl.a -Wl,--no-whole-archive -Wl,--warn-common
-Wl,-z,relro -Wl,-z,now -m64 -Wl,-O1,--sort-common,--as-
needed,-z,relro,-z,now
Log with make V=1 as requested.
** Attachment added: "qemuv1.log"
https://bugs.launchpad.net/qemu/+bug/1896096/+attachment/5412193/+files/qemuv1.log
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
Can you do the build using "make V=1" so that we actually see the
compiler command lines used in the log file.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1896096
Title:
Git version: Build
Tried meson-git, and it is still breaking on the same file. No luck
here.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1896096
Title:
Git version: Build process is broken in block_curl.c.o
Added Paolo for his Meson expertize in case he can spot the flaw
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1896096
Title:
Git version: Build process is broken in block_curl.c.o
Status in
>From log:
> The Meson build system
> Version: 0.55.3
Perhaps a(nother) problem with meson?
Try "meson=git"
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1896096
Title:
Git version: Build
Nothing looks especially unusual there, but clear it is failing to link
the block-curl.so as a library and is instead linking it as an
executable and thus failing to find "main". I can't explain why that
would be the case.
--
You received this bug notification because you are a member of qemu-
Full build log from start to crash.
** Attachment added: "qemu.log"
https://bugs.launchpad.net/qemu/+bug/1896096/+attachment/5412152/+files/qemu.log
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
Can you attach the full build log, including all the "configure" output,
and ideally pass "V=1" as an arg to 'make'
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1896096
Title:
Git version: Build
Build process is still broken even with a blank new version of git
source code.
Once again, everything start while processing block_curl.so.
Here is the beginning of the error log:
Linking target block-curl.so
/usr/bin/ld: /usr/lib/gcc/x86_64-pc-linux-gnu/10.2.0/../../../../lib/Scrt1.o:
in
I'm using Archlinux. Trying right now a build from scratch and I will
report asap. Keeping fingers crossed.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1896096
Title:
Git version: Build process
Please give more info on your host OS build environment, and most
importantly confirm that you have tried doing a build from a
*completely* clean git checkout. Recent build system changes introduced
risk of problems if you have not done a full clean. "git clean -f -x -d"
will delete every file in
48 matches
Mail list logo
