[Bug 1908551] Re: aarch64 SVE emulation breaks strnlen and strrchr

2021-04-30 Thread Thomas Huth
https://gitlab.com/qemu-project/qemu/-/commit/70acaafef2e053a3 ** Changed in: qemu Status: Confirmed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1908551 Title: aarch64 SVE

[Bug 1908551] Re: aarch64 SVE emulation breaks strnlen and strrchr

2020-12-30 Thread Richard Henderson
Patch fixing strrchr: https://patchew.org/QEMU/20201230172522.33629-1-richard.hender...@linaro.org/ -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1908551 Title: aarch64 SVE emulation breaks strnlen

[Bug 1908551] Re: aarch64 SVE emulation breaks strnlen and strrchr

2020-12-29 Thread Richard Henderson
... but you also mentioned strrchr, and there is a qemu bug there. The REV (predicate) instruction doesn't seem to be doing the right thing -- input 0x1 -> output 0x8000 which is not correct for the current vector length (64). ** Changed in: qemu Status: Invalid => Confirmed -- You r

[Bug 1908551] Re: aarch64 SVE emulation breaks strnlen and strrchr

2020-12-29 Thread Richard Henderson
Bah. The code at label 9 does not match the comment. Best fixed thus. ** Patch added: "z.patch" https://bugs.launchpad.net/qemu/+bug/1908551/+attachment/5447736/+files/z.patch -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. http

[Bug 1908551] Re: aarch64 SVE emulation breaks strnlen and strrchr

2020-12-29 Thread Richard Henderson
FWIW, as I think on this further, this probably isn't the ideal fix -- I recall now that INCP is a "reduction" class instruction and thus its overhead is non-trivial. We could instead add an integer min operation at label 9, which is outside of the main loop. -- You received this bug notificatio

[Bug 1908551] Re: aarch64 SVE emulation breaks strnlen and strrchr

2020-12-29 Thread Richard Henderson
I don't know why the test worked previously, and I did not investigate, but as far as I can tell, the test is broken. The test is returning a value >= maxlen because it it using the wrong increment. Fixed thus. ** Patch added: "z.patch" https://bugs.launchpad.net/qemu/+bug/1908551/+attachme

[Bug 1908551] Re: aarch64 SVE emulation breaks strnlen and strrchr

2020-12-28 Thread Richard Henderson
** Changed in: qemu Status: New => Confirmed ** Changed in: qemu Assignee: (unassigned) => Richard Henderson (rth) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1908551 Title: aarch64