Re: [External] Re: [PATCH v2 3/7] migration/multifd: Zero page transmission on the multifd thread.

2024-02-25 Thread Peter Xu
On Sat, Feb 24, 2024 at 02:56:15PM -0800, Hao Xiang wrote: > > > > I don't think it's super clean to have three arrays offset, zero and > > > > normal, all sized for the full packet size. It might be possible to just > > > > carry a bitmap of non-zero pages along with pages->offset and operate on

Re: [External] Re: [PATCH v2 3/7] migration/multifd: Zero page transmission on the multifd thread.

2024-02-24 Thread Hao Xiang
On Thu, Feb 22, 2024 at 9:15 PM Hao Xiang wrote: > > On Thu, Feb 22, 2024 at 6:21 PM Peter Xu wrote: > > > > On Wed, Feb 21, 2024 at 06:04:10PM -0300, Fabiano Rosas wrote: > > > Hao Xiang writes: > > > > > > > 1. Implements the zero page detection and handling on the multifd > > > > threads for

Re: [External] Re: [PATCH v2 3/7] migration/multifd: Zero page transmission on the multifd thread.

2024-02-24 Thread Hao Xiang
On Thu, Feb 22, 2024 at 8:38 PM Hao Xiang wrote: > > On Fri, Feb 16, 2024 at 9:08 PM Richard Henderson > wrote: > > > > On 2/16/24 12:39, Hao Xiang wrote: > > > +void multifd_zero_page_check_recv(MultiFDRecvParams *p) > > > +{ > > > +for (int i = 0; i < p->zero_num; i++) { > > > +

Re: [External] Re: [PATCH v2 3/7] migration/multifd: Zero page transmission on the multifd thread.

2024-02-23 Thread Fabiano Rosas
Hao Xiang writes: > On Wed, Feb 21, 2024 at 1:04 PM Fabiano Rosas wrote: >> >> Hao Xiang writes: >> >> > 1. Implements the zero page detection and handling on the multifd >> > threads for non-compression, zlib and zstd compression backends. >> > 2. Added a new value 'multifd' in

Re: [External] Re: [PATCH v2 3/7] migration/multifd: Zero page transmission on the multifd thread.

2024-02-22 Thread Hao Xiang
On Wed, Feb 21, 2024 at 1:04 PM Fabiano Rosas wrote: > > Hao Xiang writes: > > > 1. Implements the zero page detection and handling on the multifd > > threads for non-compression, zlib and zstd compression backends. > > 2. Added a new value 'multifd' in ZeroPageDetection enumeration. > > 3. Add

Re: [External] Re: [PATCH v2 3/7] migration/multifd: Zero page transmission on the multifd thread.

2024-02-22 Thread Hao Xiang
On Thu, Feb 22, 2024 at 6:21 PM Peter Xu wrote: > > On Wed, Feb 21, 2024 at 06:04:10PM -0300, Fabiano Rosas wrote: > > Hao Xiang writes: > > > > > 1. Implements the zero page detection and handling on the multifd > > > threads for non-compression, zlib and zstd compression backends. > > > 2.

Re: [External] Re: [PATCH v2 3/7] migration/multifd: Zero page transmission on the multifd thread.

2024-02-22 Thread Hao Xiang
On Wed, Feb 21, 2024 at 8:00 AM Elena Ufimtseva wrote: > > > > On Fri, Feb 16, 2024 at 2:42 PM Hao Xiang wrote: >> >> 1. Implements the zero page detection and handling on the multifd >> threads for non-compression, zlib and zstd compression backends. >> 2. Added a new value 'multifd' in

Re: [External] Re: [PATCH v2 3/7] migration/multifd: Zero page transmission on the multifd thread.

2024-02-22 Thread Hao Xiang
On Fri, Feb 16, 2024 at 9:08 PM Richard Henderson wrote: > > On 2/16/24 12:39, Hao Xiang wrote: > > +void multifd_zero_page_check_recv(MultiFDRecvParams *p) > > +{ > > +for (int i = 0; i < p->zero_num; i++) { > > +void *page = p->host + p->zero[i]; > > +if