Re: [External] Re: [PATCH v2 4/7] migration/multifd: Enable zero page checking from multifd threads.

2024-02-25 Thread Peter Xu
On Sat, Feb 24, 2024 at 03:03:15PM -0800, Hao Xiang wrote: > So I just want to make sure I am coding the right solution. I added > setting "zero-page-detection" to "legacy" in hw_compat_8_2 and tested > it. The behavior is that if I set machine type to pc-q35-8.2, > zero-page-detection will

Re: [External] Re: [PATCH v2 4/7] migration/multifd: Enable zero page checking from multifd threads.

2024-02-24 Thread Hao Xiang
On Thu, Feb 22, 2024 at 10:02 PM Hao Xiang wrote: > > On Thu, Feb 22, 2024 at 6:33 PM Peter Xu wrote: > > > > On Wed, Feb 21, 2024 at 06:06:19PM -0300, Fabiano Rosas wrote: > > > Hao Xiang writes: > > > > > > > This change adds a dedicated handler for > > > > MigrationOps::ram_save_target_page

Re: [External] Re: [PATCH v2 4/7] migration/multifd: Enable zero page checking from multifd threads.

2024-02-23 Thread Fabiano Rosas
Hao Xiang writes: > On Wed, Feb 21, 2024 at 1:06 PM Fabiano Rosas wrote: >> >> Hao Xiang writes: >> >> > This change adds a dedicated handler for >> > MigrationOps::ram_save_target_page in >> >> nit: Add a dedicated handler... >> >> Usually "this patch/change" is used only when necessary to

Re: [External] Re: [PATCH v2 4/7] migration/multifd: Enable zero page checking from multifd threads.

2024-02-22 Thread Hao Xiang
On Thu, Feb 22, 2024 at 6:33 PM Peter Xu wrote: > > On Wed, Feb 21, 2024 at 06:06:19PM -0300, Fabiano Rosas wrote: > > Hao Xiang writes: > > > > > This change adds a dedicated handler for > > > MigrationOps::ram_save_target_page in > > > > nit: Add a dedicated handler... > > > > Usually "this

Re: [External] Re: [PATCH v2 4/7] migration/multifd: Enable zero page checking from multifd threads.

2024-02-22 Thread Hao Xiang
On Wed, Feb 21, 2024 at 1:06 PM Fabiano Rosas wrote: > > Hao Xiang writes: > > > This change adds a dedicated handler for MigrationOps::ram_save_target_page > > in > > nit: Add a dedicated handler... > > Usually "this patch/change" is used only when necessary to avoid > ambiguity. Will do. >

Re: [External] Re: [PATCH v2 4/7] migration/multifd: Enable zero page checking from multifd threads.

2024-02-22 Thread Hao Xiang
On Wed, Feb 21, 2024 at 8:11 AM Elena Ufimtseva wrote: > > > > On Fri, Feb 16, 2024 at 2:42 PM Hao Xiang wrote: >> >> This change adds a dedicated handler for MigrationOps::ram_save_target_page >> in >> multifd live migration. Now zero page checking can be done in the multifd >> threads >> and