Re: [PATCH] Implement backend program convention command for vhost-user-blk

2019-11-15 Thread Stefan Hajnoczi
On Fri, Nov 15, 2019 at 02:09:25PM +0800, Micky Yun Chan wrote: Thanks for the patch! > +context = g_option_context_new(NULL); Missing g_option_context_free() later in this function. g_auto() is the easiest way to ensure that. > +g_option_context_add_main_entries(context, entries, NULL

Re: [PATCH] Implement backend program convention command for vhost-user-blk

2019-11-14 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191115060925.12346-1-mic...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH] Implement backend program convention command for vhost-user-blk Type: series Message-id

[PATCH] Implement backend program convention command for vhost-user-blk

2019-11-14 Thread Micky Yun Chan
From: michan Signed-off-by: Micky Yun Chan (michiboo) --- contrib/vhost-user-blk/vhost-user-blk.c | 95 +++-- 1 file changed, 57 insertions(+), 38 deletions(-) diff --git a/contrib/vhost-user-blk/vhost-user-blk.c b/contrib/vhost-user-blk/vhost-user-blk.c index ae61034656..