Re: [PATCH] Makefile: fix use of -j without an argument

2024-04-12 Thread Matheus Tavares Bernardino
On Fri, 12 Apr 2024 10:02:54 +0200 Paolo Bonzini wrote: > > On Thu, Apr 11, 2024 at 5:46 PM Matheus Tavares Bernardino > wrote: > > +$(if $(filter -j, $(MAKEFLAGS)) \ > > +,, \ > > +$(or \ > > + $(filter -l% -j%, $(MAKEFLAGS)), \ > > +

Re: [PATCH] Makefile: fix use of -j without an argument

2024-04-12 Thread Paolo Bonzini
On Thu, Apr 11, 2024 at 5:46 PM Matheus Tavares Bernardino wrote: > +$(if $(filter -j, $(MAKEFLAGS)) \ > +,, \ > +$(or \ > + $(filter -l% -j%, $(MAKEFLAGS)), \ > + $(if $(filter --jobserver-auth=%, $(MAKEFLAGS)),, -j1)) \ > +

Re: [PATCH] Makefile: fix use of -j without an argument

2024-04-11 Thread Philippe Mathieu-Daudé
On 11/4/24 17:38, Matheus Tavares Bernardino wrote: Hi, Philippe On Thu, 11 Apr 2024 17:29:58 +0200 =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= wrote: Hi Matheus, On 11/4/24 17:09, Matheus Tavares Bernardino wrote: Our Makefile massages the given make arguments to invoke ninja accordingly.

Re: [PATCH] Makefile: fix use of -j without an argument

2024-04-11 Thread Matheus Tavares Bernardino
Hi, Philippe On Thu, 11 Apr 2024 17:29:58 +0200 =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= wrote: > > Hi Matheus, > > On 11/4/24 17:09, Matheus Tavares Bernardino wrote: > > Our Makefile massages the given make arguments to invoke ninja > > accordingly. One key difference is that ninja will

Re: [PATCH] Makefile: fix use of -j without an argument

2024-04-11 Thread Philippe Mathieu-Daudé
Hi Matheus, On 11/4/24 17:09, Matheus Tavares Bernardino wrote: Our Makefile massages the given make arguments to invoke ninja accordingly. One key difference is that ninja will parallelize by default, whereas make only does so with -j or -j. The make man page says that "if the -j option is

[PATCH] Makefile: fix use of -j without an argument

2024-04-11 Thread Matheus Tavares Bernardino
Our Makefile massages the given make arguments to invoke ninja accordingly. One key difference is that ninja will parallelize by default, whereas make only does so with -j or -j. The make man page says that "if the -j option is given without an argument, make will not limit the number of jobs that