Re: [PATCH] Remove inclusion of hw/hw.h from files that don't need it

2024-07-01 Thread Philippe Mathieu-Daudé
On 1/7/24 15:26, Thomas Huth wrote: hw/hw.h only contains the prototype of hw_error() nowadays, so files that don't use this function don't need to include this header. Signed-off-by: Thomas Huth --- include/hw/misc/xlnx-cfi-if.h | 1 - hw/misc/edu.c | 1 - hw/vfio/container

Re: [PATCH] Remove inclusion of hw/hw.h from files that don't need it

2024-07-01 Thread Cédric Le Goater
On 7/1/24 3:26 PM, Thomas Huth wrote: hw/hw.h only contains the prototype of hw_error() nowadays, so files that don't use this function don't need to include this header. Signed-off-by: Thomas Huth --- include/hw/misc/xlnx-cfi-if.h | 1 - hw/misc/edu.c | 1 - hw/vfio/contain

Re: [PATCH] Remove inclusion of hw/hw.h from files that don't need it

2024-07-01 Thread Peter Maydell
On Mon, 1 Jul 2024 at 14:27, Thomas Huth wrote: > > hw/hw.h only contains the prototype of hw_error() nowadays, so > files that don't use this function don't need to include this > header. > > Signed-off-by: Thomas Huth Reviewed-by: Peter Maydell thanks -- PMM

[PATCH] Remove inclusion of hw/hw.h from files that don't need it

2024-07-01 Thread Thomas Huth
hw/hw.h only contains the prototype of hw_error() nowadays, so files that don't use this function don't need to include this header. Signed-off-by: Thomas Huth --- include/hw/misc/xlnx-cfi-if.h | 1 - hw/misc/edu.c | 1 - hw/vfio/container.c | 1 - 3 files changed, 3 de