Re: [PATCH] Wrong unpacked structure for epoll_event on qemu-or1k (openrisc user-space)

2023-08-02 Thread Richard Henderson
On 8/2/23 12:55, Thomas Huth wrote: On 19/07/2023 14.38, Luca Bonissi wrote: On 19/07/23 10:49, Laurent Vivier wrote: According to linux/glibc sourced, epoll is only packed for x86_64. And, in recent glibc, also for i386, even it seems not necessary: even if the __alignof__(long long) is

Re: [PATCH] Wrong unpacked structure for epoll_event on qemu-or1k (openrisc user-space)

2023-08-02 Thread Thomas Huth
On 19/07/2023 14.38, Luca Bonissi wrote: On 19/07/23 10:49, Laurent Vivier wrote: According to linux/glibc sourced, epoll is only packed for x86_64. And, in recent glibc, also for i386, even it seems not necessary: even if the __alignof__(long long) is 8, structures like epoll_event are

Re: [PATCH] Wrong unpacked structure for epoll_event on qemu-or1k (openrisc user-space)

2023-07-19 Thread Luca Bonissi
On 19/07/23 10:49, Laurent Vivier wrote: According to linux/glibc sourced, epoll is only packed for x86_64. And, in recent glibc, also for i386, even it seems not necessary: even if the __alignof__(long long) is 8, structures like epoll_event are only 12 bytes, maybe "packed" for historical

Re: [PATCH] Wrong unpacked structure for epoll_event on qemu-or1k (openrisc user-space)

2023-07-19 Thread Laurent Vivier
Le 18/07/2023 à 17:06, Luca Bonissi a écrit : On 18/07/23 16:40, Peter Maydell wrote: Hi; thanks for this patch. Unfortunately we need patches to include a Signed-off-by: line that says you're legally OK with it being contributed to QEMU, or we can't take them. Sorry for the missing

Re: [PATCH] Wrong unpacked structure for epoll_event on qemu-or1k (openrisc user-space)

2023-07-18 Thread Luca Bonissi
On 18/07/23 16:40, Peter Maydell wrote: Hi; thanks for this patch. Unfortunately we need patches to include a Signed-off-by: line that says you're legally OK with it being contributed to QEMU, or we can't take them. Sorry for the missing "signed-off-by" line, adding it just now: