Re: [PATCH] accel/tcg/plugin: Fix inject_mem_cb rw masking

On 6/5/24 15:39, Pierrick Bouvier wrote: Thanks for catching this Richard. I did the same mistake in plugins/core.c as well, could you fix it as well as part of this patch? For complement, rw are enums, R is 0b01, W is 0b10, and RW is 0b11, thus it work as expected with &. Thanks, Pierrick

Re: [PATCH] accel/tcg/plugin: Fix inject_mem_cb rw masking

Thanks for catching this Richard. I did the same mistake in plugins/core.c as well, could you fix it as well as part of this patch? For complement, rw are enums, R is 0b01, W is 0b10, and RW is 0b11, thus it work as expected with &. Thanks, Pierrick Reviewed-by: Pierrick Bouvier On 6/5/24

[PATCH] accel/tcg/plugin: Fix inject_mem_cb rw masking

These are not booleans, but masks. Fixes: f86fd4d8721 ("plugins: distinct types for callbacks") Signed-off-by: Richard Henderson --- accel/tcg/plugin-gen.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/accel/tcg/plugin-gen.c b/accel/tcg/plugin-gen.c index