Re: [PATCH] bcm2836: Remove redundant typedef and macros

2021-08-06 Thread Daniel P . Berrangé
On Thu, Aug 05, 2021 at 05:47:39PM -0400, Eduardo Habkost wrote: > commit 58b350280e97 ("hw/arm/bcm2836: Restrict BCM283XInfo > declaration to C source") didn't just move the struct > BCM283XClass definition to bcm2836.c. It also introduced a > typedef (BCM283XClass) and two type checking macros >

[PATCH] bcm2836: Remove redundant typedef and macros

2021-08-05 Thread Eduardo Habkost
commit 58b350280e97 ("hw/arm/bcm2836: Restrict BCM283XInfo declaration to C source") didn't just move the struct BCM283XClass definition to bcm2836.c. It also introduced a typedef (BCM283XClass) and two type checking macros (BCM283X_CLASS, BCM283X_GET_CLASS). The typedef and macros duplicate what