Re: [PATCH] block/rbd: support driver-specific reopen

2022-07-18 Thread Raphael Pour
On 7/1/22 11:41, Hanna Reitz wrote: On 13.04.22 14:26, Raphael Pour wrote: >>   } -    return ret; +    /* + * Remove all keys from the generic layer which + * can't be converted by rbd + * > Does any other driver do this?  Shouldn’t we leave them there so that the generic

Re: [PATCH] block/rbd: support driver-specific reopen

2022-07-01 Thread Hanna Reitz
On 13.04.22 14:26, Raphael Pour wrote: This patch completes the reopen functionality for an attached RBD where altered driver options can be passed to. This is necessary to move RBDs between ceph clusters without interrupting QEMU, where some ceph settings need to be adjusted. The

Re: [PATCH] block/rbd: support driver-specific reopen

2022-06-17 Thread Raphael Pour
Hello everyone, what do you think? Please tell me if something needs to be clarified or improved. Raphael PS: Hopefully this second reply attempt isn't messed up (first: https://lists.nongnu.org/archive/html/qemu-block/2022-06/msg00344.html) On 4/13/22 14:26, Raphael Pour wrote: This

[PATCH] block/rbd: support driver-specific reopen

2022-06-16 Thread Raphael Pour
Hello everyone, what do you think? Tell me if something needs to be clarified or improved. Raphael OpenPGP_0xCDB1EBB785C5EB7E.asc Description: OpenPGP public key OpenPGP_signature Description: OpenPGP digital signature

[PATCH] block/rbd: support driver-specific reopen

2022-04-13 Thread Raphael Pour
This patch completes the reopen functionality for an attached RBD where altered driver options can be passed to. This is necessary to move RBDs between ceph clusters without interrupting QEMU, where some ceph settings need to be adjusted. The reopen_prepare method early returns if no