Re: [PATCH] block/vhost-user-blk: Fix hang on boot for some odd guests

2023-04-21 Thread Michael S. Tsirkin
On Tue, Apr 18, 2023 at 07:20:29PM +0200, Andrey Ryabinin wrote: > > > On 4/18/23 08:17, Michael S. Tsirkin wrote: > > On Tue, Apr 18, 2023 at 05:13:11AM +, Raphael Norwitz wrote: > >> Hey Andrey - apologies for the late reply here. > >> > >> It sounds like you are dealing with a buggy guest,

Re: [PATCH] block/vhost-user-blk: Fix hang on boot for some odd guests

2023-04-18 Thread Andrey Ryabinin
On 4/18/23 08:17, Michael S. Tsirkin wrote: > On Tue, Apr 18, 2023 at 05:13:11AM +, Raphael Norwitz wrote: >> Hey Andrey - apologies for the late reply here. >> >> It sounds like you are dealing with a buggy guest, rather than a QEMU issue. >> >>> On Apr 10, 2023, at 11:39 AM, Andrey Ryabini

Re: [PATCH] block/vhost-user-blk: Fix hang on boot for some odd guests

2023-04-18 Thread Michael S. Tsirkin
On Tue, Apr 18, 2023 at 06:37:04PM +0200, Andrey Ryabinin wrote: > On 4/18/23 07:13, Raphael Norwitz wrote: > > Hey Andrey - apologies for the late reply here. > > > > It sounds like you are dealing with a buggy guest, rather than a QEMU issue. > > No arguing here, the guest is buggy. > However,

Re: [PATCH] block/vhost-user-blk: Fix hang on boot for some odd guests

2023-04-18 Thread Andrey Ryabinin
On 4/18/23 07:13, Raphael Norwitz wrote: > Hey Andrey - apologies for the late reply here. > > It sounds like you are dealing with a buggy guest, rather than a QEMU issue. No arguing here, the guest is buggy. However, the issue with QEMU is that virtio-blk tolerate such buggy guest while vhost-us

Re: [PATCH] block/vhost-user-blk: Fix hang on boot for some odd guests

2023-04-17 Thread Michael S. Tsirkin
On Tue, Apr 18, 2023 at 05:13:11AM +, Raphael Norwitz wrote: > Hey Andrey - apologies for the late reply here. > > It sounds like you are dealing with a buggy guest, rather than a QEMU issue. > > > On Apr 10, 2023, at 11:39 AM, Andrey Ryabinin wrote: > > > > > > > > On 4/10/23 10:35, Andr

Re: [PATCH] block/vhost-user-blk: Fix hang on boot for some odd guests

2023-04-17 Thread Raphael Norwitz
Hey Andrey - apologies for the late reply here. It sounds like you are dealing with a buggy guest, rather than a QEMU issue. > On Apr 10, 2023, at 11:39 AM, Andrey Ryabinin wrote: > > > > On 4/10/23 10:35, Andrey Ryabinin wrote: >> Some guests hang on boot when using the vhost-user-blk-pci de

Re: [PATCH] block/vhost-user-blk: Fix hang on boot for some odd guests

2023-04-10 Thread Andrey Ryabinin
On 4/10/23 10:35, Andrey Ryabinin wrote: > Some guests hang on boot when using the vhost-user-blk-pci device, > but boot normally when using the virtio-blk device. The problem occurs > because the guest advertises VIRTIO_F_VERSION_1 but kicks the virtqueue > before setting VIRTIO_CONFIG_S_DRIVER

[PATCH] block/vhost-user-blk: Fix hang on boot for some odd guests

2023-04-10 Thread Andrey Ryabinin
Some guests hang on boot when using the vhost-user-blk-pci device, but boot normally when using the virtio-blk device. The problem occurs because the guest advertises VIRTIO_F_VERSION_1 but kicks the virtqueue before setting VIRTIO_CONFIG_S_DRIVER_OK, causing vdev->start_on_kick to be false in vhos