Re: [PATCH] build: Silence clang warning on older glib autoptr usage

2020-03-18 Thread John Snow
On 3/18/20 8:55 AM, Eric Blake wrote: > On 3/17/20 1:11 PM, Peter Maydell wrote: >> On Tue, 17 Mar 2020 at 17:55, Eric Blake wrote: >>> >>> glib's G_DEFINE_AUTOPTR_CLEANUP_FUNC() macro defines several static >>> inline functions, often with some of them unused, but prior to 2.57.2 >>> did not

Re: [PATCH] build: Silence clang warning on older glib autoptr usage

2020-03-18 Thread Eric Blake
On 3/17/20 1:11 PM, Peter Maydell wrote: On Tue, 17 Mar 2020 at 17:55, Eric Blake wrote: glib's G_DEFINE_AUTOPTR_CLEANUP_FUNC() macro defines several static inline functions, often with some of them unused, but prior to 2.57.2 did not mark the functions as such. As a result, clang (but not

Re: [PATCH] build: Silence clang warning on older glib autoptr usage

2020-03-18 Thread Eric Blake
On 3/18/20 6:19 AM, Eric Blake wrote: This wasn't a NetBSD failure. I hit it on my clang-on-x86-64-Ubuntu setup, and also on FreeBSD. (The latter is just the tests/vm FreeBSD config, so you can repro that if you need to.) The ubuntu setup is libglib 2.56.4-0ubuntu0.18.04.4 and clang

Re: [PATCH] build: Silence clang warning on older glib autoptr usage

2020-03-18 Thread Eric Blake
On 3/17/20 1:11 PM, Peter Maydell wrote: On Tue, 17 Mar 2020 at 17:55, Eric Blake wrote: glib's G_DEFINE_AUTOPTR_CLEANUP_FUNC() macro defines several static inline functions, often with some of them unused, but prior to 2.57.2 did not mark the functions as such. As a result, clang (but not

Re: [PATCH] build: Silence clang warning on older glib autoptr usage

2020-03-17 Thread John Snow
On 3/17/20 1:55 PM, Eric Blake wrote: > glib's G_DEFINE_AUTOPTR_CLEANUP_FUNC() macro defines several static > inline functions, often with some of them unused, but prior to 2.57.2 > did not mark the functions as such. As a result, clang (but not gcc) > fails to build with older glib unless

Re: [PATCH] build: Silence clang warning on older glib autoptr usage

2020-03-17 Thread Peter Maydell
On Tue, 17 Mar 2020 at 17:55, Eric Blake wrote: > > glib's G_DEFINE_AUTOPTR_CLEANUP_FUNC() macro defines several static > inline functions, often with some of them unused, but prior to 2.57.2 > did not mark the functions as such. As a result, clang (but not gcc) > fails to build with older glib

[PATCH] build: Silence clang warning on older glib autoptr usage

2020-03-17 Thread Eric Blake
glib's G_DEFINE_AUTOPTR_CLEANUP_FUNC() macro defines several static inline functions, often with some of them unused, but prior to 2.57.2 did not mark the functions as such. As a result, clang (but not gcc) fails to build with older glib unless -Wno-unused-function is enabled. Reported-by: Peter