Re: [PATCH] configure: move malloc_trim/tcmalloc/jemalloc to meson

2020-09-18 Thread Paolo Bonzini
On 18/09/20 14:55, 罗勇刚(Yonggang Luo) wrote: > >>  if test "$tcmalloc" = "yes" && test "$jemalloc" = "yes" ; then >>      echo "ERROR: tcmalloc && jemalloc can't be used at the same time" >>      exit 1 >> -fi > This patch looks good for me, but I still have a small advice than move > thse

Re: [PATCH] configure: move malloc_trim/tcmalloc/jemalloc to meson

2020-09-18 Thread Yonggang Luo
On Wed, Sep 16, 2020 at 4:07 PM Paolo Bonzini wrote: > > Because LIBS is not used anymore, tcmalloc/jemalloc does > not work with binaries whose description is in Meson. > The fix is simply to move them to Meson too. > > For consistency with other configure options, specifying >

Re: [PATCH] configure: move malloc_trim/tcmalloc/jemalloc to meson

2020-09-16 Thread Richard Henderson
On 9/16/20 1:06 AM, Paolo Bonzini wrote: > Because LIBS is not used anymore, tcmalloc/jemalloc does > not work with binaries whose description is in Meson. > The fix is simply to move them to Meson too. > > For consistency with other configure options, specifying > --enable-malloc-trim together

Re: [PATCH] configure: move malloc_trim/tcmalloc/jemalloc to meson

2020-09-16 Thread Stefan Hajnoczi
On Wed, Sep 16, 2020 at 04:06:08AM -0400, Paolo Bonzini wrote: > Because LIBS is not used anymore, tcmalloc/jemalloc does > not work with binaries whose description is in Meson. > The fix is simply to move them to Meson too. > > For consistency with other configure options, specifying >

[PATCH] configure: move malloc_trim/tcmalloc/jemalloc to meson

2020-09-16 Thread Paolo Bonzini
Because LIBS is not used anymore, tcmalloc/jemalloc does not work with binaries whose description is in Meson. The fix is simply to move them to Meson too. For consistency with other configure options, specifying --enable-malloc-trim together with --enable-{tc,je}malloc becomes a fatal error.