Re: [PATCH] exec: Remove the duplicated check in parse_cpu_option()

2019-12-08 Thread Gavin Shan
On 12/8/19 3:51 AM, Greg Kurz wrote: On Sat, 7 Dec 2019 23:56:55 +1100 Gavin Shan wrote: On 12/7/19 3:58 AM, Greg Kurz wrote: On Fri, 6 Dec 2019 17:33:37 +1100 Gavin Shan wrote: The @cpu_option shouldn't be NULL, otherwise assertion from g_strsplit() should be raised as below message

Re: [PATCH] exec: Remove the duplicated check in parse_cpu_option()

2019-12-07 Thread Gavin Shan
On 12/7/19 3:58 AM, Greg Kurz wrote: On Fri, 6 Dec 2019 17:33:37 +1100 Gavin Shan wrote: The @cpu_option shouldn't be NULL, otherwise assertion from g_strsplit() should be raised as below message indicates. So it's meaningless to validate @model_pices[0] in parse_cpu_option() as it shouldn't

Re: [PATCH] exec: Remove the duplicated check in parse_cpu_option()

2019-12-07 Thread Greg Kurz
On Sat, 7 Dec 2019 23:56:55 +1100 Gavin Shan wrote: > On 12/7/19 3:58 AM, Greg Kurz wrote: > > On Fri, 6 Dec 2019 17:33:37 +1100 > > Gavin Shan wrote: > > > >> The @cpu_option shouldn't be NULL, otherwise assertion from g_strsplit() > >> should be raised as below message indicates. So it's

Re: [PATCH] exec: Remove the duplicated check in parse_cpu_option()

2019-12-06 Thread Greg Kurz
On Fri, 6 Dec 2019 17:33:37 +1100 Gavin Shan wrote: > The @cpu_option shouldn't be NULL, otherwise assertion from g_strsplit() > should be raised as below message indicates. So it's meaningless to validate > @model_pices[0] in parse_cpu_option() as it shouldn't be NULL either. > >

[PATCH] exec: Remove the duplicated check in parse_cpu_option()

2019-12-06 Thread Gavin Shan
The @cpu_option shouldn't be NULL, otherwise assertion from g_strsplit() should be raised as below message indicates. So it's meaningless to validate @model_pices[0] in parse_cpu_option() as it shouldn't be NULL either. qemu-system-aarch64: GLib: g_strsplit: assertion 'string != NULL' failed