Re: [PATCH] exec: fetch the alignment of Linux devdax pmem character device nodes

2020-04-09 Thread Liu, Jingqi
On 4/10/2020 12:46 AM, Dan Williams wrote: On Thu, Apr 9, 2020 at 7:33 AM Liu, Jingqi wrote: On 4/8/2020 5:42 PM, Joao Martins wrote: On 4/8/20 3:25 AM, Liu, Jingqi wrote: On 4/8/2020 2:28 AM, Joao Martins wrote: On 4/7/20 5:55 PM, Dan Williams wrote: On Tue, Apr 7, 2020 at 4:01 AM Joao Mar

Re: [PATCH] exec: fetch the alignment of Linux devdax pmem character device nodes

2020-04-09 Thread Paolo Bonzini
On 09/04/20 18:46, Dan Williams wrote: > Alternatively maybe you can use libdaxctl that automatically handles > the ABI differences between compat-dax-class and dax-bus layouts? I > didn't recommend it before because I was not sure about qemu's policy > about taking on new library dependencies In

Re: [PATCH] exec: fetch the alignment of Linux devdax pmem character device nodes

2020-04-09 Thread Dan Williams
On Thu, Apr 9, 2020 at 7:33 AM Liu, Jingqi wrote: > > On 4/8/2020 5:42 PM, Joao Martins wrote: > > On 4/8/20 3:25 AM, Liu, Jingqi wrote: > >> On 4/8/2020 2:28 AM, Joao Martins wrote: > >>> On 4/7/20 5:55 PM, Dan Williams wrote: > On Tue, Apr 7, 2020 at 4:01 AM Joao Martins > wrote: > >

Re: [PATCH] exec: fetch the alignment of Linux devdax pmem character device nodes

2020-04-09 Thread Liu, Jingqi
On 4/8/2020 5:42 PM, Joao Martins wrote: On 4/8/20 3:25 AM, Liu, Jingqi wrote: On 4/8/2020 2:28 AM, Joao Martins wrote: On 4/7/20 5:55 PM, Dan Williams wrote: On Tue, Apr 7, 2020 at 4:01 AM Joao Martins wrote: Perhaps, you meant instead: /sys/dev/char/%d:%d/align Hmm, are you su

Re: [PATCH] exec: fetch the alignment of Linux devdax pmem character device nodes

2020-04-08 Thread Joao Martins
On 4/8/20 3:25 AM, Liu, Jingqi wrote: > On 4/8/2020 2:28 AM, Joao Martins wrote: >> On 4/7/20 5:55 PM, Dan Williams wrote: >>> On Tue, Apr 7, 2020 at 4:01 AM Joao Martins >>> wrote: On 4/1/20 4:13 AM, Jingqi Liu wrote: > If the backend file is devdax pmem character device, the alignment

Re: [PATCH] exec: fetch the alignment of Linux devdax pmem character device nodes

2020-04-08 Thread Joao Martins
On 4/8/20 2:16 AM, Liu, Jingqi wrote: > On 4/7/2020 11:51 PM, Joao Martins wrote: >> On 4/7/20 3:31 PM, Paolo Bonzini wrote: >>> On 07/04/20 12:59, Joao Martins wrote: Perhaps, you meant instead: /sys/dev/char/%d:%d/align ? > Hi Joao, > > In my machine with real

Re: [PATCH] exec: fetch the alignment of Linux devdax pmem character device nodes

2020-04-07 Thread Liu, Jingqi
On 4/8/2020 2:28 AM, Joao Martins wrote: On 4/7/20 5:55 PM, Dan Williams wrote: On Tue, Apr 7, 2020 at 4:01 AM Joao Martins wrote: On 4/1/20 4:13 AM, Jingqi Liu wrote: If the backend file is devdax pmem character device, the alignment specified by the option 'align=NUM' in the '-object memory

Re: [PATCH] exec: fetch the alignment of Linux devdax pmem character device nodes

2020-04-07 Thread Liu, Jingqi
On 4/7/2020 11:51 PM, Joao Martins wrote: On 4/7/20 3:31 PM, Paolo Bonzini wrote: On 07/04/20 12:59, Joao Martins wrote: Perhaps, you meant instead: /sys/dev/char/%d:%d/align ? Hi Joao, In my machine with real NVDIMM, the devdax device is as follows: $ ll /dev/dax0.0 crw---

Re: [PATCH] exec: fetch the alignment of Linux devdax pmem character device nodes

2020-04-07 Thread Paolo Bonzini
On 07/04/20 20:28, Joao Martins wrote: > On 4/7/20 5:55 PM, Dan Williams wrote: >> On Tue, Apr 7, 2020 at 4:01 AM Joao Martins >> wrote: >>> On 4/1/20 4:13 AM, Jingqi Liu wrote: If the backend file is devdax pmem character device, the alignment specified by the option 'align=NUM' in the

Re: [PATCH] exec: fetch the alignment of Linux devdax pmem character device nodes

2020-04-07 Thread Joao Martins
On 4/7/20 5:55 PM, Dan Williams wrote: > On Tue, Apr 7, 2020 at 4:01 AM Joao Martins wrote: >> On 4/1/20 4:13 AM, Jingqi Liu wrote: >>> If the backend file is devdax pmem character device, the alignment >>> specified by the option 'align=NUM' in the '-object memory-backend-file' >>> needs to match

Re: [PATCH] exec: fetch the alignment of Linux devdax pmem character device nodes

2020-04-07 Thread Dan Williams
On Tue, Apr 7, 2020 at 4:01 AM Joao Martins wrote: > > > > On 4/1/20 4:13 AM, Jingqi Liu wrote: > > If the backend file is devdax pmem character device, the alignment > > specified by the option 'align=NUM' in the '-object memory-backend-file' > > needs to match the alignment requirement of the de

Re: [PATCH] exec: fetch the alignment of Linux devdax pmem character device nodes

2020-04-07 Thread Joao Martins
On 4/7/20 3:31 PM, Paolo Bonzini wrote: > On 07/04/20 12:59, Joao Martins wrote: >> Perhaps, you meant instead: >> >> /sys/dev/char/%d:%d/align >> >> ? >> > > So it works with that change? Yeah. Joao

Re: [PATCH] exec: fetch the alignment of Linux devdax pmem character device nodes

2020-04-07 Thread Paolo Bonzini
On 07/04/20 12:59, Joao Martins wrote: > Perhaps, you meant instead: > > /sys/dev/char/%d:%d/align > > ? > So it works with that change? Paolo

Re: [PATCH] exec: fetch the alignment of Linux devdax pmem character device nodes

2020-04-07 Thread Joao Martins
On 4/7/20 9:16 AM, Dan Williams wrote: > On Tue, Apr 7, 2020 at 1:08 AM Paolo Bonzini wrote: >> On 07/04/20 09:29, Liu, Jingqi wrote: >>> Ping. >>> >>> Any comments are appreciated. >>> >>> Hi Paolo, Richard, >>> >>> Any comments about this ? >> >> I was hoping to get a review from someone else be

Re: [PATCH] exec: fetch the alignment of Linux devdax pmem character device nodes

2020-04-07 Thread Joao Martins
On 4/1/20 4:13 AM, Jingqi Liu wrote: > If the backend file is devdax pmem character device, the alignment > specified by the option 'align=NUM' in the '-object memory-backend-file' > needs to match the alignment requirement of the devdax pmem character device. > > This patch fetches the devdax

Re: [PATCH] exec: fetch the alignment of Linux devdax pmem character device nodes

2020-04-07 Thread Liu, Jingqi
On 4/7/2020 4:08 PM, Paolo Bonzini wrote: On 07/04/20 09:29, Liu, Jingqi wrote: Ping. Any comments are appreciated. Hi Paolo, Richard, Any comments about this ? I was hoping to get a review from someone else because I have no way to test it. But I've now queued the patch, thanks. Hi Paolo

Re: [PATCH] exec: fetch the alignment of Linux devdax pmem character device nodes

2020-04-07 Thread Dan Williams
On Tue, Apr 7, 2020 at 1:08 AM Paolo Bonzini wrote: > > On 07/04/20 09:29, Liu, Jingqi wrote: > > Ping. > > > > Any comments are appreciated. > > > > Hi Paolo, Richard, > > > > Any comments about this ? > > I was hoping to get a review from someone else because I have no way to > test it. But I'v

Re: [PATCH] exec: fetch the alignment of Linux devdax pmem character device nodes

2020-04-07 Thread Paolo Bonzini
On 07/04/20 09:29, Liu, Jingqi wrote: > Ping. > > Any comments are appreciated. > > Hi Paolo, Richard, > > Any comments about this ? I was hoping to get a review from someone else because I have no way to test it. But I've now queued the patch, thanks. Paolo > > Thanks, > > Jingqi > > On

Re: [PATCH] exec: fetch the alignment of Linux devdax pmem character device nodes

2020-04-07 Thread Liu, Jingqi
Ping. Any comments are appreciated. Hi Paolo, Richard, Any comments about this ? Thanks, Jingqi On 4/1/2020 11:13 AM, Liu, Jingqi wrote: If the backend file is devdax pmem character device, the alignment specified by the option 'align=NUM' in the '-object memory-backend-file' needs to matc

[PATCH] exec: fetch the alignment of Linux devdax pmem character device nodes

2020-03-31 Thread Jingqi Liu
If the backend file is devdax pmem character device, the alignment specified by the option 'align=NUM' in the '-object memory-backend-file' needs to match the alignment requirement of the devdax pmem character device. This patch fetches the devdax pmem file 'align', so that we can compare it with