Re: [PATCH] file-win32: Fix "locking" option

2020-09-07 Thread Max Reitz
On 07.09.20 11:27, Kevin Wolf wrote: > The intended behaviour was that locking=off/auto work and have no > effect (to remain compatible with file-posix), whereas locking=on would > return an error. Unfortunately, the code forgot to remove "locking" from > the options QDict, so any attempt to use th

Re: [PATCH] file-win32: Fix "locking" option

2020-09-07 Thread Philippe Mathieu-Daudé
On 9/7/20 11:27 AM, Kevin Wolf wrote: > The intended behaviour was that locking=off/auto work and have no > effect (to remain compatible with file-posix), whereas locking=on would > return an error. Unfortunately, the code forgot to remove "locking" from > the options QDict, so any attempt to use t

[PATCH] file-win32: Fix "locking" option

2020-09-07 Thread Kevin Wolf
The intended behaviour was that locking=off/auto work and have no effect (to remain compatible with file-posix), whereas locking=on would return an error. Unfortunately, the code forgot to remove "locking" from the options QDict, so any attempt to use the option would fail. Replace the option pars