Re: [PATCH] fw_cfg: Allow reboot-timeout=-1 again

2019-10-31 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Han Han (h...@redhat.com) wrote: >> However, another important question is: how can we avoid such undocumented >> incompatibility appears again? > > The reboot-timeout one was accidental - it was a documented qemu > feature; just no one noticed it when the

Re: [PATCH] fw_cfg: Allow reboot-timeout=-1 again

2019-10-31 Thread Dr. David Alan Gilbert
* Han Han (h...@redhat.com) wrote: > However, another important question is: how can we avoid such undocumented > incompatibility appears again? The reboot-timeout one was accidental - it was a documented qemu feature; just no one noticed it when the input check was added. Officially if we

Re: [PATCH] fw_cfg: Allow reboot-timeout=-1 again

2019-10-30 Thread Han Han
However, another important question is: how can we avoid such undocumented incompatibility appears again? I can show another case caused by such incompatibile change: https://bugzilla.redhat.com/show_bug.cgi?id=1745868#c0 For the qemu devices, attributes, values, qmp cmds, qmp cmds arguments used

Re: [PATCH] fw_cfg: Allow reboot-timeout=-1 again

2019-10-29 Thread Philippe Mathieu-Daudé
On 10/29/19 3:26 AM, Dr. David Alan Gilbert wrote: * Laszlo Ersek (ler...@redhat.com) wrote: On 10/25/19 18:57, Dr. David Alan Gilbert (git) wrote: From: "Dr. David Alan Gilbert" Commit ee5d0f89de3e53cdb0dc added range checking on reboot-timeout to only allow the range 0..65535; however both

Re: [PATCH] fw_cfg: Allow reboot-timeout=-1 again

2019-10-29 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > "Dr. David Alan Gilbert" writes: > > > * Markus Armbruster (arm...@redhat.com) wrote: > >> "Dr. David Alan Gilbert (git)" writes: > >> > >> > From: "Dr. David Alan Gilbert" > >> > > >> > Commit ee5d0f89de3e53cdb0dc added range checking on

Re: [PATCH] fw_cfg: Allow reboot-timeout=-1 again

2019-10-29 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Markus Armbruster (arm...@redhat.com) wrote: >> "Dr. David Alan Gilbert (git)" writes: >> >> > From: "Dr. David Alan Gilbert" >> > >> > Commit ee5d0f89de3e53cdb0dc added range checking on reboot-timeout >> > to only allow the range 0..65535; however both

Re: [PATCH] fw_cfg: Allow reboot-timeout=-1 again

2019-10-28 Thread Dr. David Alan Gilbert
* Laszlo Ersek (ler...@redhat.com) wrote: > On 10/25/19 18:57, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > Commit ee5d0f89de3e53cdb0dc added range checking on reboot-timeout > > to only allow the range 0..65535; however both qemu and libvirt document > > the

Re: [PATCH] fw_cfg: Allow reboot-timeout=-1 again

2019-10-28 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > "Dr. David Alan Gilbert (git)" writes: > > > From: "Dr. David Alan Gilbert" > > > > Commit ee5d0f89de3e53cdb0dc added range checking on reboot-timeout > > to only allow the range 0..65535; however both qemu and libvirt document > > the special

Re: [PATCH] fw_cfg: Allow reboot-timeout=-1 again

2019-10-25 Thread Laszlo Ersek
On 10/25/19 18:57, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Commit ee5d0f89de3e53cdb0dc added range checking on reboot-timeout > to only allow the range 0..65535; however both qemu and libvirt document > the special value -1 to mean don't reboot. > Allow it again.

Re: [PATCH] fw_cfg: Allow reboot-timeout=-1 again

2019-10-25 Thread Markus Armbruster
"Dr. David Alan Gilbert (git)" writes: > From: "Dr. David Alan Gilbert" > > Commit ee5d0f89de3e53cdb0dc added range checking on reboot-timeout > to only allow the range 0..65535; however both qemu and libvirt document > the special value -1 to mean don't reboot. > Allow it again. > > Fixes:

[PATCH] fw_cfg: Allow reboot-timeout=-1 again

2019-10-25 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Commit ee5d0f89de3e53cdb0dc added range checking on reboot-timeout to only allow the range 0..65535; however both qemu and libvirt document the special value -1 to mean don't reboot. Allow it again. Fixes: ee5d0f89de3e53cdb0dc ("fw_cfg: Fix -boot reboot-timeout