Re: [PATCH] gdbstub: Fix client Ctrl-C handling

2023-08-10 Thread Alex Bennée
Matheus Tavares Bernardino writes: > Hi, Nick. > >> Nicholas Piggin wrote: >> >> On Tue Jul 11, 2023 at 9:03 PM AEST, Matheus Tavares Bernardino wrote: >> > > Nicholas Piggin wrote: >> > > >> > > diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c >> > > index 6911b73c07..ce8b42eb15 100644 >>

Re: [PATCH] gdbstub: Fix client Ctrl-C handling

2023-08-08 Thread Richard Henderson
On 8/1/23 11:40, Matheus Tavares Bernardino wrote: Hi, Nick. Nicholas Piggin wrote: On Tue Jul 11, 2023 at 9:03 PM AEST, Matheus Tavares Bernardino wrote: Nicholas Piggin wrote: diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c index 6911b73c07..ce8b42eb15 100644 --- a/gdbstub/gdbstub.c

Re: [PATCH] gdbstub: Fix client Ctrl-C handling

2023-08-01 Thread Philippe Mathieu-Daudé
On 31/7/23 15:59, Peter Maydell wrote: On Mon, 31 Jul 2023 at 07:59, Joel Stanley wrote: On Sun, 30 Jul 2023 at 09:43, Nicholas Piggin wrote: On Wed Jul 26, 2023 at 4:35 PM AEST, Joel Stanley wrote: On Wed, 12 Jul 2023 at 02:12, Nicholas Piggin wrote: I was taking a look at -rc1 and

Re: [PATCH] gdbstub: Fix client Ctrl-C handling

2023-08-01 Thread Matheus Tavares Bernardino
Hi, Nick. > Nicholas Piggin wrote: > > On Tue Jul 11, 2023 at 9:03 PM AEST, Matheus Tavares Bernardino wrote: > > > Nicholas Piggin wrote: > > > > > > diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c > > > index 6911b73c07..ce8b42eb15 100644 > > > --- a/gdbstub/gdbstub.c > > > +++

Re: [PATCH] gdbstub: Fix client Ctrl-C handling

2023-07-31 Thread Peter Maydell
On Mon, 31 Jul 2023 at 07:59, Joel Stanley wrote: > > On Sun, 30 Jul 2023 at 09:43, Nicholas Piggin wrote: > > > > On Wed Jul 26, 2023 at 4:35 PM AEST, Joel Stanley wrote: > > > On Wed, 12 Jul 2023 at 02:12, Nicholas Piggin wrote: > > > > > > > > On Tue Jul 11, 2023 at 9:03 PM AEST, Matheus

Re: [PATCH] gdbstub: Fix client Ctrl-C handling

2023-07-31 Thread Joel Stanley
On Sun, 30 Jul 2023 at 09:43, Nicholas Piggin wrote: > > On Wed Jul 26, 2023 at 4:35 PM AEST, Joel Stanley wrote: > > On Wed, 12 Jul 2023 at 02:12, Nicholas Piggin wrote: > > > > > > On Tue Jul 11, 2023 at 9:03 PM AEST, Matheus Tavares Bernardino wrote: > > > > > Nicholas Piggin wrote: > > > >

Re: [PATCH] gdbstub: Fix client Ctrl-C handling

2023-07-30 Thread Nicholas Piggin
On Wed Jul 26, 2023 at 4:35 PM AEST, Joel Stanley wrote: > On Wed, 12 Jul 2023 at 02:12, Nicholas Piggin wrote: > > > > On Tue Jul 11, 2023 at 9:03 PM AEST, Matheus Tavares Bernardino wrote: > > > > Nicholas Piggin wrote: > > > > > > > > diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c > > > >

Re: [PATCH] gdbstub: Fix client Ctrl-C handling

2023-07-26 Thread Joel Stanley
On Wed, 12 Jul 2023 at 02:12, Nicholas Piggin wrote: > > On Tue Jul 11, 2023 at 9:03 PM AEST, Matheus Tavares Bernardino wrote: > > > Nicholas Piggin wrote: > > > > > > diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c > > > index 6911b73c07..ce8b42eb15 100644 > > > --- a/gdbstub/gdbstub.c > >

Re: [PATCH] gdbstub: Fix client Ctrl-C handling

2023-07-12 Thread Michael Tokarev
12.07.2023 05:13, Nicholas Piggin wrote: On Tue Jul 11, 2023 at 6:59 PM AEST, Nicholas Piggin wrote: The gdb remote protocol has a special interrupt character (0x03) that is transmitted outside the regular packet processing, and represents a Ctrl-C pressed in the client. Despite not being a

Re: [PATCH] gdbstub: Fix client Ctrl-C handling

2023-07-11 Thread Nicholas Piggin
On Tue Jul 11, 2023 at 6:59 PM AEST, Nicholas Piggin wrote: > The gdb remote protocol has a special interrupt character (0x03) that is > transmitted outside the regular packet processing, and represents a > Ctrl-C pressed in the client. Despite not being a regular packet, it > does expect a

Re: [PATCH] gdbstub: Fix client Ctrl-C handling

2023-07-11 Thread Nicholas Piggin
On Tue Jul 11, 2023 at 9:03 PM AEST, Matheus Tavares Bernardino wrote: > > Nicholas Piggin wrote: > > > > diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c > > index 6911b73c07..ce8b42eb15 100644 > > --- a/gdbstub/gdbstub.c > > +++ b/gdbstub/gdbstub.c > > @@ -2051,8 +2051,17 @@ void

Re: [PATCH] gdbstub: Fix client Ctrl-C handling

2023-07-11 Thread Matheus Tavares Bernardino
> Nicholas Piggin wrote: > > diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c > index 6911b73c07..ce8b42eb15 100644 > --- a/gdbstub/gdbstub.c > +++ b/gdbstub/gdbstub.c > @@ -2051,8 +2051,17 @@ void gdb_read_byte(uint8_t ch) > return; > } > if (runstate_is_running()) { > -

[PATCH] gdbstub: Fix client Ctrl-C handling

2023-07-11 Thread Nicholas Piggin
The gdb remote protocol has a special interrupt character (0x03) that is transmitted outside the regular packet processing, and represents a Ctrl-C pressed in the client. Despite not being a regular packet, it does expect a regular stop response if the stub successfully stops the running program.