Re: [PATCH] gitlab: compare CIRRUS_nn vars against 'null' not ""

2022-06-09 Thread Alex Bennée
Daniel P. Berrangé writes: > The GitLab variable comparisons don't have shell like semantics where > an unset variable compares equal to empty string. We need to explicitly > test against 'null' to detect an unset variable. > > Signed-off-by: Daniel P. Berrangé Queued to testing/next, thanks.

Re: [PATCH] gitlab: compare CIRRUS_nn vars against 'null' not ""

2022-06-08 Thread Thomas Huth
On 08/06/2022 18.06, Daniel P. Berrangé wrote: The GitLab variable comparisons don't have shell like semantics where an unset variable compares equal to empty string. We need to explicitly test against 'null' to detect an unset variable. Signed-off-by: Daniel P. Berrangé --- .gitlab-ci.d/base

Re: [PATCH] gitlab: compare CIRRUS_nn vars against 'null' not ""

2022-06-08 Thread Richard Henderson
On 6/8/22 09:06, Daniel P. Berrangé wrote: The GitLab variable comparisons don't have shell like semantics where an unset variable compares equal to empty string. We need to explicitly test against 'null' to detect an unset variable. Signed-off-by: Daniel P. Berrangé --- .gitlab-ci.d/base.yml

[PATCH] gitlab: compare CIRRUS_nn vars against 'null' not ""

2022-06-08 Thread Daniel P . Berrangé
The GitLab variable comparisons don't have shell like semantics where an unset variable compares equal to empty string. We need to explicitly test against 'null' to detect an unset variable. Signed-off-by: Daniel P. Berrangé --- .gitlab-ci.d/base.yml | 2 +- 1 file changed, 1 insertion(+), 1 del