Re: [PATCH] gtk: Add show_tabs=on|off command line option.

2022-07-12 Thread Felix Queißner
Heya! On 27.06.22 18:44, Felix xq Queißner wrote: The patch adds "show_tabs" command line option for GTK ui similar to "grab_on_hover". This option allows tabbed view mode to not have to be enabled by hand at each start of the VM. On 30.06.22 16:09, Hanna Reitz wrote: > [snip] On 30.06.22

Re: [PATCH] gtk: Add show_tabs=on|off command line option.

2022-07-12 Thread Hanna Reitz
On 12.07.22 09:35, Felix Queißner wrote: Heya! On 27.06.22 18:44, Felix xq Queißner wrote: The patch adds "show_tabs" command line option for GTK ui similar to "grab_on_hover". This option allows tabbed view mode to not have to be enabled by hand at each start of the VM. On 30.06.22 16:09,

Re: [PATCH] gtk: Add show_tabs=on|off command line option.

2022-07-01 Thread Gerd Hoffmann
Hi, > But a bit more verbosity might be nice, too.  What about “Display the tab > bar for switching between the various graphical interfaces (e.g. VGA and > virtual console character devices) by default”?  (Note the imperative on > “Display”, I think we generally use the imperative to document

Re: [PATCH] gtk: Add show_tabs=on|off command line option.

2022-07-01 Thread kra...@redhat.com
On Fri, Jul 01, 2022 at 09:14:02AM +, Zhang, Chen wrote: > > > > Signed-off-by: Felix "xq" Queißner > > Thanks your patch, but please use your real name to sign a patch. > For the details: > docs/devel/submitting-a-patch.rst Hmm? Felix Queißner looks like a real name to me ... take

RE: [PATCH] gtk: Add show_tabs=on|off command line option.

2022-07-01 Thread Zhang, Chen
; Subject: [PATCH] gtk: Add show_tabs=on|off command line option. > > The patch adds "show_tabs" command line option for GTK ui similar to > "grab_on_hover". This option allows tabbed view mode to not have to be > enabled by hand at each start of the VM. > >

Re: [PATCH] gtk: Add show_tabs=on|off command line option.

2022-06-30 Thread Markus Armbruster
Hanna Reitz writes: > Hi, > > (Thanks for the patch!) > > On 27.06.22 18:44, Felix xq Queißner wrote: >> The patch adds "show_tabs" command line option for GTK ui similar to >> "grab_on_hover". This option allows tabbed view mode to not have to be >> enabled by hand at each start of the VM. >

Re: [PATCH] gtk: Add show_tabs=on|off command line option.

2022-06-30 Thread Hanna Reitz
On 30.06.22 16:09, Hanna Reitz wrote: Hi, (Thanks for the patch!) On 27.06.22 18:44, Felix xq Queißner wrote: The patch adds "show_tabs" command line option for GTK ui similar to "grab_on_hover". This option allows tabbed view mode to not have to be enabled by hand at each start of the VM.

Re: [PATCH] gtk: Add show_tabs=on|off command line option.

2022-06-30 Thread Hanna Reitz
Hi, (Thanks for the patch!) On 27.06.22 18:44, Felix xq Queißner wrote: The patch adds "show_tabs" command line option for GTK ui similar to "grab_on_hover". This option allows tabbed view mode to not have to be enabled by hand at each start of the VM. I’m not sure we have a hard rule on

[PATCH] gtk: Add show_tabs=on|off command line option.

2022-06-27 Thread Felix xq Queißner
The patch adds "show_tabs" command line option for GTK ui similar to "grab_on_hover". This option allows tabbed view mode to not have to be enabled by hand at each start of the VM. Signed-off-by: Felix "xq" Queißner --- qapi/ui.json| 5 - qemu-options.hx | 2 +- ui/gtk.c| 4

Re: [Qemu-devel] [PATCH] gtk: Add show_tabs=on|off command line option.

2022-06-23 Thread Thomas Huth
On 23/06/2022 17.05, Felix Queißner wrote: Not sure why it was never picked up That patch certainly needs a re-spin since it won't apply as-is anymore. Want to have a try? I guess the semantics of the code stay the same, but the boilerplate might change a bit? If so, i guess i can give

Re: [Qemu-devel] [PATCH] gtk: Add show_tabs=on|off command line option.

2022-06-23 Thread Felix Queißner
Not sure why it was never picked up That patch certainly needs a re-spin since it won't apply as-is anymore. Want to have a try? I guess the semantics of the code stay the same, but the boilerplate might change a bit? If so, i guess i can give it a try tomorrow and see if i can make it

Re: [Qemu-devel] [PATCH] gtk: Add show_tabs=on|off command line option.

2022-06-23 Thread Thomas Huth
On 23/06/2022 16.59, Thomas Huth wrote: On 23/06/2022 16.36, Felix Queißner wrote: Heya! The patch adds "show_tabs" command line option for GTK ui similar to "grab_on_hover". This option allows tabbed view mode to not have to be enabled by hand at each start of the VM. It's been a while

Re: [Qemu-devel] [PATCH] gtk: Add show_tabs=on|off command line option.

2022-06-23 Thread Thomas Huth
On 23/06/2022 16.36, Felix Queißner wrote: Heya! The patch adds "show_tabs" command line option for GTK ui similar to "grab_on_hover". This option allows tabbed view mode to not have to be enabled by hand at each start of the VM. It's been a while now, but i was always missing this feature

Re: [Qemu-devel] [PATCH] gtk: Add show_tabs=on|off command line option.

2022-06-23 Thread Felix Queißner
Heya! The patch adds "show_tabs" command line option for GTK ui similar to "grab_on_hover". This option allows tabbed view mode to not have to be enabled by hand at each start of the VM. It's been a while now, but i was always missing this feature in QEMU and i'd love to see that patch

[Qemu-devel] [PATCH] gtk: Add show_tabs=on|off command line option.

2016-02-26 Thread Igor S
The patch adds "show_tabs" command line option for GTK ui similar to "grab_on_hover". This option allows tabbed view mode to not have to be enabled by hand at each start of the VM. Signed-off-by: Igor Sudarikov <4se...@gmail.com> --- include/ui/console.h | 2 +- qemu-options.hx | 2 +-