Re: [PATCH] hmp/migration: Fix documents for "migrate" command

2024-05-03 Thread Peter Xu
On Fri, May 03, 2024 at 04:08:45PM +0200, Markus Armbruster wrote: > If there's still time, suggest to tweak the subject to > > hmp/migration: Fix "migrate" command's documentation Yes there is. :) > > Peter Xu writes: > > > On Fri, May 03, 2024 at 08:58:09AM +0200, Markus Armbruster wrot

Re: [PATCH] hmp/migration: Fix documents for "migrate" command

2024-05-03 Thread Markus Armbruster
If there's still time, suggest to tweak the subject to hmp/migration: Fix "migrate" command's documentation Peter Xu writes: > On Fri, May 03, 2024 at 08:58:09AM +0200, Markus Armbruster wrote: >> Peter Xu writes: >> >> > Peter missed the Sphinx HMP document for the "resume/-r" flag in co

Re: [PATCH] hmp/migration: Fix documents for "migrate" command

2024-05-03 Thread Peter Xu
On Fri, May 03, 2024 at 08:58:09AM +0200, Markus Armbruster wrote: > Peter Xu writes: > > > Peter missed the Sphinx HMP document for the "resume/-r" flag in commit > > 7a4da28b26 ("qmp: hmp: add migrate "resume" option"). Add it. Avoid > > adding a Fixes to make life easier for the stable maint

Re: [PATCH] hmp/migration: Fix documents for "migrate" command

2024-05-02 Thread Markus Armbruster
Peter Xu writes: > Peter missed the Sphinx HMP document for the "resume/-r" flag in commit > 7a4da28b26 ("qmp: hmp: add migrate "resume" option"). Add it. Avoid > adding a Fixes to make life easier for the stable maintainer. I'm curious: how does not adding Fixes: make life easier? > When at

Re: [PATCH] hmp/migration: Fix documents for "migrate" command

2024-05-02 Thread Fabiano Rosas
Peter Xu writes: > Peter missed the Sphinx HMP document for the "resume/-r" flag in commit > 7a4da28b26 ("qmp: hmp: add migrate "resume" option"). Add it. Avoid > adding a Fixes to make life easier for the stable maintainer. > > When at it, slightly cleanup the lines, move "detach/-d" to a sepa

[PATCH] hmp/migration: Fix documents for "migrate" command

2024-05-02 Thread Peter Xu
Peter missed the Sphinx HMP document for the "resume/-r" flag in commit 7a4da28b26 ("qmp: hmp: add migrate "resume" option"). Add it. Avoid adding a Fixes to make life easier for the stable maintainer. When at it, slightly cleanup the lines, move "detach/-d" to a separate section rather than app