Re: [PATCH] hv-balloon: avoid alloca() usage

2023-11-13 Thread Peter Maydell
On Mon, 13 Nov 2023 at 08:59, David Hildenbrand wrote: > > On 09.11.23 17:02, Maciej S. Szmigiero wrote: > > From: "Maciej S. Szmigiero" > > > > alloca() is frowned upon, replace it with g_malloc0() + g_autofree. > > > > Reviewed-by: David Hildenbrand > > If this fixes a coverity issue of #numbe

Re: [PATCH] hv-balloon: avoid alloca() usage

2023-11-13 Thread Maciej S. Szmigiero
On 13.11.2023 09:59, David Hildenbrand wrote: On 09.11.23 17:02, Maciej S. Szmigiero wrote: From: "Maciej S. Szmigiero" alloca() is frowned upon, replace it with g_malloc0() + g_autofree. Reviewed-by: David Hildenbrand If this fixes a coverity issue of #number, we usually indicate that us

Re: [PATCH] hv-balloon: avoid alloca() usage

2023-11-13 Thread David Hildenbrand
On 09.11.23 17:02, Maciej S. Szmigiero wrote: From: "Maciej S. Szmigiero" alloca() is frowned upon, replace it with g_malloc0() + g_autofree. Reviewed-by: David Hildenbrand If this fixes a coverity issue of #number, we usually indicate that using "CID: #number" or Fixes: CID: #number" -

Re: [PATCH] hv-balloon: avoid alloca() usage

2023-11-09 Thread Philippe Mathieu-Daudé
On 9/11/23 17:02, Maciej S. Szmigiero wrote: From: "Maciej S. Szmigiero" alloca() is frowned upon, replace it with g_malloc0() + g_autofree. Signed-off-by: Maciej S. Szmigiero --- hw/hyperv/hv-balloon.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) Reviewed-by: Philipp

[PATCH] hv-balloon: avoid alloca() usage

2023-11-09 Thread Maciej S. Szmigiero
From: "Maciej S. Szmigiero" alloca() is frowned upon, replace it with g_malloc0() + g_autofree. Signed-off-by: Maciej S. Szmigiero --- hw/hyperv/hv-balloon.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/hw/hyperv/hv-balloon.c b/hw/hyperv/hv-balloon.c index 66f