Re: [PATCH] hw/9pfs: virtio-9p: Ensure config space is a multiple of 4 bytes

2020-11-04 Thread Christian Schoenebeck
On Mittwoch, 4. November 2020 08:44:44 CET Bin Meng wrote: > Hi Michael, > > On Tue, Nov 3, 2020 at 8:05 PM Michael S. Tsirkin wrote: > > On Tue, Nov 03, 2020 at 02:26:10PM +0800, Bin Meng wrote: > > > Hi Michael, > > > > > > On Fri, Oct 30, 2020 at 5:29 PM Michael S. Tsirkin wrote: > > > >

Re: [PATCH] hw/9pfs: virtio-9p: Ensure config space is a multiple of 4 bytes

2020-11-03 Thread Bin Meng
Hi Michael, On Tue, Nov 3, 2020 at 8:05 PM Michael S. Tsirkin wrote: > > On Tue, Nov 03, 2020 at 02:26:10PM +0800, Bin Meng wrote: > > Hi Michael, > > > > On Fri, Oct 30, 2020 at 5:29 PM Michael S. Tsirkin wrote: > > > > > > On Thu, Oct 29, 2020 at 04:25:41PM +0800, Bin Meng wrote: > > > >

Re: [PATCH] hw/9pfs: virtio-9p: Ensure config space is a multiple of 4 bytes

2020-11-03 Thread Michael S. Tsirkin
On Tue, Nov 03, 2020 at 02:26:10PM +0800, Bin Meng wrote: > Hi Michael, > > On Fri, Oct 30, 2020 at 5:29 PM Michael S. Tsirkin wrote: > > > > On Thu, Oct 29, 2020 at 04:25:41PM +0800, Bin Meng wrote: > > > From: Bin Meng > > > > > > At present the virtio device config space access is handled by

Re: [PATCH] hw/9pfs: virtio-9p: Ensure config space is a multiple of 4 bytes

2020-11-02 Thread Bin Meng
On Tue, Nov 3, 2020 at 2:26 PM Bin Meng wrote: > > Hi Michael, > > On Fri, Oct 30, 2020 at 5:29 PM Michael S. Tsirkin wrote: > > > > On Thu, Oct 29, 2020 at 04:25:41PM +0800, Bin Meng wrote: > > > From: Bin Meng > > > > > > At present the virtio device config space access is handled by the > >

Re: [PATCH] hw/9pfs: virtio-9p: Ensure config space is a multiple of 4 bytes

2020-11-02 Thread Bin Meng
Hi Michael, On Fri, Oct 30, 2020 at 5:29 PM Michael S. Tsirkin wrote: > > On Thu, Oct 29, 2020 at 04:25:41PM +0800, Bin Meng wrote: > > From: Bin Meng > > > > At present the virtio device config space access is handled by the > > virtio_config_readX() and virtio_config_writeX() APIs. They

Re: [PATCH] hw/9pfs: virtio-9p: Ensure config space is a multiple of 4 bytes

2020-10-30 Thread Michael S. Tsirkin
On Thu, Oct 29, 2020 at 04:25:41PM +0800, Bin Meng wrote: > From: Bin Meng > > At present the virtio device config space access is handled by the > virtio_config_readX() and virtio_config_writeX() APIs. They perform > a sanity check on the result of address plus size against the config > space

Re: [PATCH] hw/9pfs: virtio-9p: Ensure config space is a multiple of 4 bytes

2020-10-29 Thread Bin Meng
Hi Christian, On Thu, Oct 29, 2020 at 8:52 PM Christian Schoenebeck wrote: > > On Donnerstag, 29. Oktober 2020 09:25:41 CET Bin Meng wrote: > > From: Bin Meng > > > > At present the virtio device config space access is handled by the > > virtio_config_readX() and virtio_config_writeX() APIs.

Re: [PATCH] hw/9pfs: virtio-9p: Ensure config space is a multiple of 4 bytes

2020-10-29 Thread Christian Schoenebeck
On Donnerstag, 29. Oktober 2020 09:25:41 CET Bin Meng wrote: > From: Bin Meng > > At present the virtio device config space access is handled by the > virtio_config_readX() and virtio_config_writeX() APIs. They perform > a sanity check on the result of address plus size against the config >

[PATCH] hw/9pfs: virtio-9p: Ensure config space is a multiple of 4 bytes

2020-10-29 Thread Bin Meng
From: Bin Meng At present the virtio device config space access is handled by the virtio_config_readX() and virtio_config_writeX() APIs. They perform a sanity check on the result of address plus size against the config space size before the access occurs. For unaligned access, the last