Re: [PATCH] hw/acpi: specify 64-bit acpi table

2020-06-22 Thread Igor Mammedov
On Tue, 16 Jun 2020 13:20:17 -0600 "Jason A. Donenfeld" wrote: > > > increment the revision to '2' so that these larger addresses are > > > addressable. This matters because the DSDT revision represents the > > > maximum capability of all other SSDTs. This is also what arm does. > > it was

Re: [PATCH] hw/acpi: specify 64-bit acpi table

2020-06-16 Thread Jason A. Donenfeld
> > increment the revision to '2' so that these larger addresses are > > addressable. This matters because the DSDT revision represents the > > maximum capability of all other SSDTs. This is also what arm does. > it was keept at 1 for compat reasons with WindowsXP. > by now it is long time EOL, so

Re: [PATCH] hw/acpi: specify 64-bit acpi table

2020-06-16 Thread Jason A. Donenfeld
On Tue, Jun 16, 2020 at 2:16 AM Igor Mammedov wrote: > On Mon, 15 Jun 2020 18:36:54 -0600 > "Jason A. Donenfeld" wrote: > > SSDTs cannot address 64-bit physical addresses in 32-bit tables, so we > please clarify what accesses waht within tables (i.e. be more concrete). If you add an ssdt or a

Re: [PATCH] hw/acpi: specify 64-bit acpi table

2020-06-16 Thread Igor Mammedov
On Mon, 15 Jun 2020 18:36:54 -0600 "Jason A. Donenfeld" wrote: > SSDTs cannot address 64-bit physical addresses in 32-bit tables, so we please clarify what accesses waht within tables (i.e. be more concrete). > increment the revision to '2' so that these larger addresses are > addressable. This

Re: [PATCH] hw/acpi: specify 64-bit acpi table

2020-06-15 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200616003654.1058035-1-ja...@zx2c4.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash

Re: [PATCH] hw/acpi: specify 64-bit acpi table

2020-06-15 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200616003654.1058035-1-ja...@zx2c4.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

[PATCH] hw/acpi: specify 64-bit acpi table

2020-06-15 Thread Jason A. Donenfeld
SSDTs cannot address 64-bit physical addresses in 32-bit tables, so we increment the revision to '2' so that these larger addresses are addressable. This matters because the DSDT revision represents the maximum capability of all other SSDTs. This is also what arm does. Signed-off-by: Jason A.