Re: [PATCH] hw/arm/aspeed: Add board model for Supermicro X11 BMC

2020-07-15 Thread Erik Smit
Hey Cédric, On Wed, 15 Jul 2020 at 15:07, Cédric Le Goater wrote: > > Signed-off-by: erik-smit > > -- > > checkpatch was complaining about the length of > > aspeed_machine_supermicrox11_bmc_class_init(ObjectClass *oc, void *data) > > in which way ? line too long ? Yes. > If so, you can insert

Re: [PATCH] hw/arm/aspeed: Add board model for Supermicro X11 BMC

2020-07-15 Thread Cédric Le Goater
> Signed-off-by: erik-smit > -- > checkpatch was complaining about the length of > aspeed_machine_supermicrox11_bmc_class_init(ObjectClass *oc, void *data) in which way ? line too long ? If so, you can insert a return inside the parameter list. > so I renamed it to aspeed_machine_smx11_bmc_cl

[PATCH] hw/arm/aspeed: Add board model for Supermicro X11 BMC

2020-07-14 Thread erik-smit
Signed-off-by: erik-smit -- checkpatch was complaining about the length of aspeed_machine_supermicrox11_bmc_class_init(ObjectClass *oc, void *data) so I renamed it to aspeed_machine_smx11_bmc_class_init. Not sure if that's the right way to go, since then it's out of sync with the machine name "s