Re: [PATCH] hw/arm/virt: Remove virt machine state 'smp_cpus'

2021-01-07 Thread Peter Maydell
On Wed, 16 Dec 2020 at 06:44, Andrew Jones wrote: > > On Tue, Dec 15, 2020 at 06:20:48PM +, David Edmondson wrote: > > On Tuesday, 2020-12-15 at 18:48:15 +01, Andrew Jones wrote: > > > > > virt machine's 'smp_cpus' and machine->smp.cpus must always have the > > > same value. And, anywhere we h

Re: [PATCH] hw/arm/virt: Remove virt machine state 'smp_cpus'

2020-12-16 Thread Ying Fang
On 12/16/2020 1:48 AM, Andrew Jones wrote: virt machine's 'smp_cpus' and machine->smp.cpus must always have the same value. And, anywhere we have virt machine state we have machine state. So let's remove the redundancy. Also, to make it easier to see that machine->smp is the true source for "s

Re: [PATCH] hw/arm/virt: Remove virt machine state 'smp_cpus'

2020-12-16 Thread David Edmondson
On Wednesday, 2020-12-16 at 07:43:53 +01, Andrew Jones wrote: > On Tue, Dec 15, 2020 at 06:20:48PM +, David Edmondson wrote: >> On Tuesday, 2020-12-15 at 18:48:15 +01, Andrew Jones wrote: >> >> > static void fdt_add_cpu_nodes(const VirtMachineState *vms) >> > { >> > -int cpu; >> > -

Re: [PATCH] hw/arm/virt: Remove virt machine state 'smp_cpus'

2020-12-15 Thread Andrew Jones
On Tue, Dec 15, 2020 at 06:20:48PM +, David Edmondson wrote: > On Tuesday, 2020-12-15 at 18:48:15 +01, Andrew Jones wrote: > > > virt machine's 'smp_cpus' and machine->smp.cpus must always have the > > same value. And, anywhere we have virt machine state we have machine > > state. So let's rem

Re: [PATCH] hw/arm/virt: Remove virt machine state 'smp_cpus'

2020-12-15 Thread David Edmondson
On Tuesday, 2020-12-15 at 18:48:15 +01, Andrew Jones wrote: > virt machine's 'smp_cpus' and machine->smp.cpus must always have the > same value. And, anywhere we have virt machine state we have machine > state. So let's remove the redundancy. Also, to make it easier to see > that machine->smp is t

[PATCH] hw/arm/virt: Remove virt machine state 'smp_cpus'

2020-12-15 Thread Andrew Jones
virt machine's 'smp_cpus' and machine->smp.cpus must always have the same value. And, anywhere we have virt machine state we have machine state. So let's remove the redundancy. Also, to make it easier to see that machine->smp is the true source for "smp_cpus" and "max_cpus", avoid passing them in f