Re: [PATCH] hw/arm/virt: Validate memory size on the first NUMA node

2022-03-06 Thread Shan Gavin
Hi Laszlo, Yes, I think it's enough to provide the user-friendly error message in EDK2. The command lines to start the VM/guest can be adjusted to have more than 128MB memory associated for NUMA node#0 when it's seen by users. Thanks, Gavin Laszlo Ersek 于2022年3月4日周五 22:24写道: > > Gerd, > > On 03

Re: [PATCH] hw/arm/virt: Validate memory size on the first NUMA node

2022-03-04 Thread Laszlo Ersek
Gerd, On 03/04/22 11:58, Peter Maydell wrote: > On Fri, 4 Mar 2022 at 10:52, Igor Mammedov wrote: >> if firmware is not an option, I wouldn't opposed to printing warning >> message from QEMU if you can detect that you are running broken edk2 >> and under condition that no new infa/hooks are inven

Re: [PATCH] hw/arm/virt: Validate memory size on the first NUMA node

2022-03-04 Thread Peter Maydell
On Fri, 4 Mar 2022 at 10:52, Igor Mammedov wrote: > if firmware is not an option, I wouldn't opposed to printing warning > message from QEMU if you can detect that you are running broken edk2 > and under condition that no new infa/hooks are invented for this. > (assuming it's worth all the effort

Re: [PATCH] hw/arm/virt: Validate memory size on the first NUMA node

2022-03-04 Thread Igor Mammedov
On Thu, 3 Mar 2022 11:25:25 +0800 Gavin Shan wrote: > Hi Gerd, > > On 3/1/22 7:42 PM, Gerd Hoffmann wrote: > >>> Unless it architecturally wrong thing i.e. (node size less than 128Mb) > >>> ,in which case limiting it in QEMU would be justified, I'd prefer > >>> firmware being fixed or it reporti

Re: [PATCH] hw/arm/virt: Validate memory size on the first NUMA node

2022-03-04 Thread Gerd Hoffmann
Hi, > because 128MB node memory size isn't used in practice. If the EDK2 error > message can be improved, we might have something like below: > > ASSERT [MemoryInit] > /home/lacos/src/upstream/qemu/roms/edk2/ArmVirtPkg/Library/QemuVirtMemInfoLib/QemuVirtMemInfoPeiLibConstructor.c(93): > NewSi

Re: [PATCH] hw/arm/virt: Validate memory size on the first NUMA node

2022-03-02 Thread Gavin Shan
Hi Gerd, On 3/1/22 7:42 PM, Gerd Hoffmann wrote: Unless it architecturally wrong thing i.e. (node size less than 128Mb) ,in which case limiting it in QEMU would be justified, I'd prefer firmware being fixed or it reporting more useful for user error message. [include EDK2 developers] I don't

Re: [PATCH] hw/arm/virt: Validate memory size on the first NUMA node

2022-03-01 Thread Gerd Hoffmann
Hi, > > Unless it architecturally wrong thing i.e. (node size less than 128Mb) > > ,in which case limiting it in QEMU would be justified, I'd prefer > > firmware being fixed or it reporting more useful for user error message. > > [include EDK2 developers] > > I don't think 128MB node memory si

Re: [PATCH] hw/arm/virt: Validate memory size on the first NUMA node

2022-03-01 Thread Gavin Shan
Hi Igor, On 2/28/22 5:08 PM, Igor Mammedov wrote: On Mon, 28 Feb 2022 15:52:03 +0800 Gavin Shan wrote: When the memory size on the first NUMA node is less than 128MB, the guest hangs inside EDK2 as the following logs show. /home/gavin/sandbox/qemu.main/build/qemu-system-aarch64 \

Re: [PATCH] hw/arm/virt: Validate memory size on the first NUMA node

2022-02-28 Thread Igor Mammedov
On Mon, 28 Feb 2022 15:52:03 +0800 Gavin Shan wrote: > When the memory size on the first NUMA node is less than 128MB, the > guest hangs inside EDK2 as the following logs show. > > /home/gavin/sandbox/qemu.main/build/qemu-system-aarch64 \ > -accel kvm -machine virt,gic-version=host

[PATCH] hw/arm/virt: Validate memory size on the first NUMA node

2022-02-27 Thread Gavin Shan
When the memory size on the first NUMA node is less than 128MB, the guest hangs inside EDK2 as the following logs show. /home/gavin/sandbox/qemu.main/build/qemu-system-aarch64 \ -accel kvm -machine virt,gic-version=host \ -cpu host -smp 8,sockets=2,cores=2,threa