Re: [PATCH] hw/core: define stack variable to NULL to fix qtest with sanitizers

2023-11-24 Thread Dan Hoffman
Yes, that fixes my issue. I was receiving two errors with the sanitizers: 1. UBsan complaining that the (garbage) value didn't have the required alignment of the type 2. ASan complaining about some memory failure by read/write/accessing it On Fri, Nov 24, 2023 at 8:02 AM Markus Armbruster wrote:

Re: [PATCH] hw/core: define stack variable to NULL to fix qtest with sanitizers

2023-11-24 Thread Markus Armbruster
Daniel, please have a look at Kevin's patch: Subject: [PATCH for-8.2 1/2] qdev: Fix crash in array property getter Date: Tue, 21 Nov 2023 18:34:15 +0100 (2 days, 20 hours, 26 minutes ago) Message-ID: <20231121173416.346610-2-kw...@redhat.com>

Re: [PATCH] hw/core: define stack variable to NULL to fix qtest with sanitizers

2023-11-24 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > (Cc'ing QAPI maintainer) > > On 24/11/23 02:53, Daniel Hoffman wrote: >> This was the only failure preventing `make check` from passing with >> sanitizers >> enabled on my configuration. > > IIUC this is due to visit_start_list() which expects a NULL list, > see

Re: [PATCH] hw/core: define stack variable to NULL to fix qtest with sanitizers

2023-11-24 Thread Philippe Mathieu-Daudé
(Cc'ing QAPI maintainer) On 24/11/23 02:53, Daniel Hoffman wrote: This was the only failure preventing `make check` from passing with sanitizers enabled on my configuration. IIUC this is due to visit_start_list() which expects a NULL list, see qapi/qapi-visit-core.c: bool

[PATCH] hw/core: define stack variable to NULL to fix qtest with sanitizers

2023-11-23 Thread Daniel Hoffman
This was the only failure preventing `make check` from passing with sanitizers enabled on my configuration. Signed-off-by: Daniel Hoffman --- hw/core/qdev-properties.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/core/qdev-properties.c b/hw/core/qdev-properties.c index