Re: [PATCH] hw/i386: fix microvm segfault with virtio cmdline

2023-02-22 Thread Michael S. Tsirkin
didn't read the patch yet but just formatting comments: On Wed, Feb 22, 2023 at 10:39:10PM -0800, Daniel Hoffman wrote: > The 'microvm' machine type allows for disabling ACPI, in which case > the VirtIO device configuration is passed via appending it to the > kernel cmdline. > > If no cmdline par

[PATCH] hw/i386: fix microvm segfault with virtio cmdline

2023-02-22 Thread Daniel Hoffman
The 'microvm' machine type allows for disabling ACPI, in which case the VirtIO device configuration is passed via appending it to the kernel cmdline. If no cmdline parameter was passed, then a null pointer is dereferenced when the new cmdline is copied back. A solution is to always define the cmdl