Re: [PATCH] hw/i386: fix short-circuit logic with non-optimizing builds

Submitted a v3 with the minimum reproducible build configuration On Sun, Nov 19, 2023 at 2:25 PM Michael S. Tsirkin wrote: > > On Sun, Nov 19, 2023 at 02:19:25PM -0600, Dan Hoffman wrote: > > Clang 16.0.6 > > > > I can re-submit with the compiler and version if that helps. > > Worth mentioning th

Re: [PATCH] hw/i386: fix short-circuit logic with non-optimizing builds

On Sun, Nov 19, 2023 at 02:19:25PM -0600, Dan Hoffman wrote: > Clang 16.0.6 > > I can re-submit with the compiler and version if that helps. Worth mentioning this and the flags used I think. > On Sun, Nov 19, 2023 at 2:02 PM Michael S. Tsirkin wrote: > > > > On Sun, Nov 19, 2023 at 11:03:54AM -

Re: [PATCH] hw/i386: fix short-circuit logic with non-optimizing builds

Clang 16.0.6 I can re-submit with the compiler and version if that helps. On Sun, Nov 19, 2023 at 2:02 PM Michael S. Tsirkin wrote: > > On Sun, Nov 19, 2023 at 11:03:54AM -0600, Dan Hoffman wrote: > > On Sun, Nov 19, 2023 at 1:23 AM Michael S. Tsirkin wrote: > > > > > > On Sat, Nov 18, 2023 at

Re: [PATCH] hw/i386: fix short-circuit logic with non-optimizing builds

On Sun, Nov 19, 2023 at 11:03:54AM -0600, Dan Hoffman wrote: > On Sun, Nov 19, 2023 at 1:23 AM Michael S. Tsirkin wrote: > > > > On Sat, Nov 18, 2023 at 10:25:31AM -0800, Daniel Hoffman wrote: > > > `kvm_enabled()` is compiled down to `0` and short-circuit logic is > > > used to remmove references

Re: [PATCH] hw/i386: fix short-circuit logic with non-optimizing builds

On Sun, Nov 19, 2023 at 1:23 AM Michael S. Tsirkin wrote: > > On Sat, Nov 18, 2023 at 10:25:31AM -0800, Daniel Hoffman wrote: > > `kvm_enabled()` is compiled down to `0` and short-circuit logic is > > used to remmove references to undefined symbols at the compile stage. > > Some build configuratio

Re: [PATCH] hw/i386: fix short-circuit logic with non-optimizing builds

On Sat, Nov 18, 2023 at 10:25:31AM -0800, Daniel Hoffman wrote: > `kvm_enabled()` is compiled down to `0` and short-circuit logic is > used to remmove references to undefined symbols at the compile stage. > Some build configurations with some compilers don't attempt to > simplify this logic down in

[PATCH] hw/i386: fix short-circuit logic with non-optimizing builds

`kvm_enabled()` is compiled down to `0` and short-circuit logic is used to remmove references to undefined symbols at the compile stage. Some build configurations with some compilers don't attempt to simplify this logic down in some cases (the pattern appears to be that the literal false must be th