Re: [PATCH] hw/ide: Remove unuseful IDE_DMA__COUNT definition

2023-05-17 Thread John Snow
On Fri, Feb 24, 2023 at 10:34 AM Philippe Mathieu-Daudé wrote: > > First, IDE_DMA__COUNT represents the number of enumerated > values, but is incorrectly listed as part of the enum. > > Second, IDE_DMA_CMD_str() is internal to core.c and only > takes sane enums from ide_dma_cmd. So no need to

Re: [PATCH] hw/ide: Remove unuseful IDE_DMA__COUNT definition

2023-03-14 Thread Philippe Mathieu-Daudé
ping? On 24/2/23 16:34, Philippe Mathieu-Daudé wrote: First, IDE_DMA__COUNT represents the number of enumerated values, but is incorrectly listed as part of the enum. Second, IDE_DMA_CMD_str() is internal to core.c and only takes sane enums from ide_dma_cmd. So no need to check the 'enval'

[PATCH] hw/ide: Remove unuseful IDE_DMA__COUNT definition

2023-02-24 Thread Philippe Mathieu-Daudé
First, IDE_DMA__COUNT represents the number of enumerated values, but is incorrectly listed as part of the enum. Second, IDE_DMA_CMD_str() is internal to core.c and only takes sane enums from ide_dma_cmd. So no need to check the 'enval' argument is within the enum range. Only checks