Re: [PATCH] hw/net/i82596: Correct command bitmask (CID 1419392)

2020-03-16 Thread Jason Wang
On 2020/3/13 下午7:01, Peter Maydell wrote: On Fri, 14 Feb 2020 at 00:48, Philippe Mathieu-Daudé wrote: The command is 32-bit, but we are loading the 16 upper bits with the 'get_uint16(s->scb + 2)' call. Once shifted by 16, the command bits match the status bits: - Command Bit 31 ACK-CX

Re: [PATCH] hw/net/i82596: Correct command bitmask (CID 1419392)

2020-03-13 Thread Peter Maydell
On Fri, 14 Feb 2020 at 00:48, Philippe Mathieu-Daudé wrote: > > The command is 32-bit, but we are loading the 16 upper bits with > the 'get_uint16(s->scb + 2)' call. > > Once shifted by 16, the command bits match the status bits: > > - Command > Bit 31 ACK-CX Acknowledges that the CU completed

[PATCH] hw/net/i82596: Correct command bitmask (CID 1419392)

2020-02-13 Thread Philippe Mathieu-Daudé
The command is 32-bit, but we are loading the 16 upper bits with the 'get_uint16(s->scb + 2)' call. Once shifted by 16, the command bits match the status bits: - Command Bit 31 ACK-CX Acknowledges that the CU completed an Action Command. Bit 30 ACK-FR Acknowledges that the RU received a f