Re: [PATCH] hw/nvme: actually implement abort

2024-07-11 Thread Keith Busch
On Wed, Jul 10, 2024 at 11:09:43AM +0200, Klaus Jensen wrote: > On Jul 2 20:55, Klaus Jensen wrote: > > On Jul 2 09:24, Keith Busch wrote: > > > On Tue, Jul 02, 2024 at 01:32:32PM +0530, Ayush Mishra wrote: > > > > Abort was not implemented previously, but we can implement it for AERs > > > >

Re: [PATCH] hw/nvme: actually implement abort

2024-07-10 Thread Klaus Jensen
On Jul 2 20:55, Klaus Jensen wrote: > On Jul 2 09:24, Keith Busch wrote: > > On Tue, Jul 02, 2024 at 01:32:32PM +0530, Ayush Mishra wrote: > > > Abort was not implemented previously, but we can implement it for AERs > > > and asynchrnously for I/O. > > > > Not implemented for a reason. The

Re: [PATCH] hw/nvme: actually implement abort

2024-07-02 Thread Klaus Jensen
On Jul 2 09:24, Keith Busch wrote: > On Tue, Jul 02, 2024 at 01:32:32PM +0530, Ayush Mishra wrote: > > Abort was not implemented previously, but we can implement it for AERs and > > asynchrnously for I/O. > > Not implemented for a reason. The target has no idea if the CID the > host requested

Re: [PATCH] hw/nvme: actually implement abort

2024-07-02 Thread Keith Busch
On Tue, Jul 02, 2024 at 01:32:32PM +0530, Ayush Mishra wrote: > Abort was not implemented previously, but we can implement it for AERs and > asynchrnously for I/O. Not implemented for a reason. The target has no idea if the CID the host requested to be aborted is from the same context that the

[PATCH] hw/nvme: actually implement abort

2024-07-02 Thread Ayush Mishra
Abort was not implemented previously, but we can implement it for AERs and asynchrnously for I/O. Signed-off-by: Ayush Mishra --- hw/nvme/ctrl.c | 32 1 file changed, 32 insertions(+) diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c index 127c3d2383..a38037b5f8