Re: [PATCH] hw/pci-host: Use register definitions from PCI standard

2023-01-07 Thread Mark Cave-Ayland
On 05/01/2023 14:41, Philippe Mathieu-Daudé wrote: No need to document magic values when the definition names from "standard-headers/linux/pci_regs.h" are self-explicit. Signed-off-by: Philippe Mathieu-Daudé --- hw/pci-host/grackle.c | 2 +- hw/pci-host/raven.c| 6 +++--- hw/pci-hos

Re: [PATCH] hw/pci-host: Use register definitions from PCI standard

2023-01-05 Thread Bernhard Beschow
Am 5. Januar 2023 16:02:48 UTC schrieb BALATON Zoltan : >On Thu, 5 Jan 2023, Philippe Mathieu-Daudé wrote: >> No need to document magic values when the definition names >> from "standard-headers/linux/pci_regs.h" are self-explicit. >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> hw/pci-h

Re: [PATCH] hw/pci-host: Use register definitions from PCI standard

2023-01-05 Thread Philippe Mathieu-Daudé
On 5/1/23 17:02, BALATON Zoltan wrote: On Thu, 5 Jan 2023, Philippe Mathieu-Daudé wrote: No need to document magic values when the definition names from "standard-headers/linux/pci_regs.h" are self-explicit. Signed-off-by: Philippe Mathieu-Daudé --- hw/pci-host/grackle.c  |  2 +- hw/pci-host/r

Re: [PATCH] hw/pci-host: Use register definitions from PCI standard

2023-01-05 Thread BALATON Zoltan
On Thu, 5 Jan 2023, Philippe Mathieu-Daudé wrote: No need to document magic values when the definition names from "standard-headers/linux/pci_regs.h" are self-explicit. Signed-off-by: Philippe Mathieu-Daudé --- hw/pci-host/grackle.c | 2 +- hw/pci-host/raven.c| 6 +++--- hw/pci-host/uninor

[PATCH] hw/pci-host: Use register definitions from PCI standard

2023-01-05 Thread Philippe Mathieu-Daudé
No need to document magic values when the definition names from "standard-headers/linux/pci_regs.h" are self-explicit. Signed-off-by: Philippe Mathieu-Daudé --- hw/pci-host/grackle.c | 2 +- hw/pci-host/raven.c| 6 +++--- hw/pci-host/uninorth.c | 30 +++--- 3 files