Re: [PATCH] hw/ppc: fix decrementer with BookE timers

Hello Clément, Unless I'm wrong this patch has not been queued yet. Is there any reason for this ? I don't think there was a PPC PR yet. We are just starting the QEMU 9.2 cycle [*]. Since this is a fix that applies on older releases, may be we could have a PR in not too long. Thanks, C. [*]

Re: [PATCH] hw/ppc: fix decrementer with BookE timers

Hi Cédric, On Tue, Aug 27, 2024 at 7:40 PM Cédric Le Goater wrote: > > Hello Clément, > > On 7/15/24 10:46, Clément Chigot wrote: > > The BookE decrementer stops at 0, meaning that it won't decremented > > towards "negative" values. > > However, the current logic is inverted: decr is updated sole

Re: [PATCH] hw/ppc: fix decrementer with BookE timers

On Thu, Aug 29, 2024 at 2:33 PM Cédric Le Goater wrote: > > On 8/28/24 09:21, Clément Chigot wrote: > > On Tue, Aug 27, 2024 at 7:40 PM Cédric Le Goater wrote: > >> > >> Hello Clément, > >> > >> On 7/15/24 10:46, Clément Chigot wrote: > >>> The BookE decrementer stops at 0, meaning that it won't

Re: [PATCH] hw/ppc: fix decrementer with BookE timers

On 8/28/24 09:21, Clément Chigot wrote: On Tue, Aug 27, 2024 at 7:40 PM Cédric Le Goater wrote: Hello Clément, On 7/15/24 10:46, Clément Chigot wrote: The BookE decrementer stops at 0, meaning that it won't decremented towards "negative" values. However, the current logic is inverted: decr i

Re: [PATCH] hw/ppc: fix decrementer with BookE timers

On Tue, Aug 27, 2024 at 7:40 PM Cédric Le Goater wrote: > > Hello Clément, > > On 7/15/24 10:46, Clément Chigot wrote: > > The BookE decrementer stops at 0, meaning that it won't decremented > > towards "negative" values. > > However, the current logic is inverted: decr is updated solely when > >

Re: [PATCH] hw/ppc: fix decrementer with BookE timers

Hello Clément, On 7/15/24 10:46, Clément Chigot wrote: The BookE decrementer stops at 0, meaning that it won't decremented towards "negative" values. However, the current logic is inverted: decr is updated solely when the resulting value would be negative. How did you hit the issue ? which mac

Re: [PATCH] hw/ppc: fix decrementer with BookE timers

Adding Cédric On 27/8/24 13:49, Clément Chigot wrote: Hey, Gentle ping Thanks Clément On Mon, Jul 29, 2024 at 10:33 AM Clément Chigot wrote: Hi, Gentle ping + CC missing maintainers. Thanks Clément On Mon, Jul 15, 2024 at 10:46 AM Clément Chigot wrote: The BookE decrementer stops at

Re: [PATCH] hw/ppc: fix decrementer with BookE timers

Hey, Gentle ping Thanks Clément On Mon, Jul 29, 2024 at 10:33 AM Clément Chigot wrote: > > Hi, > > Gentle ping + CC missing maintainers. > > Thanks Clément > > On Mon, Jul 15, 2024 at 10:46 AM Clément Chigot wrote: > > > > The BookE decrementer stops at 0, meaning that it won't decremented > >

Re: [PATCH] hw/ppc: fix decrementer with BookE timers

Hi, Gentle ping + CC missing maintainers. Thanks Clément On Mon, Jul 15, 2024 at 10:46 AM Clément Chigot wrote: > > The BookE decrementer stops at 0, meaning that it won't decremented > towards "negative" values. > However, the current logic is inverted: decr is updated solely when > the result

[PATCH] hw/ppc: fix decrementer with BookE timers

The BookE decrementer stops at 0, meaning that it won't decremented towards "negative" values. However, the current logic is inverted: decr is updated solely when the resulting value would be negative. Signed-off-by: Clément Chigot Fixed: 8e0a5ac87800 ("hw/ppc: Avoid decrementer rounding errors")